bug: 204594 title: UVF exception for lsb-3.2 date-reported: Fri, 21 Mar 2008 11:55:51 -0000 date-updated: Fri, 04 Dec 2009 16:23:18 -0000 reporter: Matthias Klose (doko) duplicate-of: duplicates: attachments: patches: https://bugs.launchpad.net/bugs/204594/+attachment/235802/+files/lsb.debdiff text/plain https://bugs.launchpad.net/bugs/204594/+attachment/241708/+files/set-e-changes.diff text/plain https://bugs.launchpad.net/bugs/204594/+attachment/241709/+files/lsb.debdiff text/plain https://bugs.launchpad.net/bugs/204594/+attachment/304604/+files/lsb.204594.debdiff text/plain tags: subscribers: Matthias Klose (doko) Marc Tardif (cr3) Ubuntu Release Team (ubuntu-release) Onno Benschop (onno-itmaze) task: lsb (Ubuntu) status: Fix Released date-created: Fri, 21 Mar 2008 11:55:51 -0000 date-confirmed: Thu, 27 Mar 2008 23:44:52 -0000 date-inprogress: Thu, 27 Mar 2008 23:44:52 -0000 date-closed: Mon, 09 Jun 2008 09:24:35 -0000 date-fix-released: Mon, 09 Jun 2008 09:24:35 -0000 reporter: Matthias Klose (doko) importance: Undecided component: main assignee: milestone: Content-Type: multipart/mixed; boundary="===============2080958433171968867==" MIME-Version: 1.0 --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Binary package hint: lsb afaiu, we do want hardy to have certified against the current lsb release 3.2, but only have 3.1 packages in hardy. Updated packages are available at http://people.ubuntu.com/~doko/tmp/lsb/. --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Matthias Klose (doko) Date: Fri, 21 Mar 2008 11:57:42 -0000 Message-Id: <20080321115743.26981.13131.malone@potassium.ubuntu.com> Marc, any feedback about these packages? --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Matthias Klose (doko) Date: Fri, 21 Mar 2008 12:07:36 -0000 Message-Id: <20080321120736.14864.30926.malone@gangotri.canonical.com> $ cat lsb.diffstat debian/README.Debian | 36 ++++++++---- debian/changelog | 54 ++++++++++++++++++ debian/control | 104 +++++++++++++++++++++++++++++------ debian/copyright | 1=20 debian/po/fi.po | 38 ++++++++++++ debian/po/ja.po | 53 ++++-------------- debian/po/pt.po | 38 ++---------- debian/po/ro.po | 150 +++++++++++++++++++++-------------------------= ----- debian/rules | 4 + init-functions | 22 ++++--- lsb_release | 44 +++++++++++--- lsbinstall | 31 +++++++++- 12 files changed, 362 insertions(+), 213 deletions(-) --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Steve Langasek (vorlon) Date: Tue, 25 Mar 2008 20:01:14 -0000 Message-Id: <20080325200114.17146.37815.malone@gandwana.canonical.com> + [ -n "$sig" -o "$sig" =3D 15 -o "$sig" =3D TERM ] && is_term_sig=3Dyes Nack on this change; I know it's standard practice for the LSB functions to explode miserably under set -e, but killproc currently does not do this, and init scripts may reasonably rely on a set-e-clean killproc. In fact, there's one init script on my machine, /etc/init.d/atd, which does - the function doesn't behave in an *LSB*-clean manner under set -e, but it does function, so this would be a regression. Everything else changed here appears to be an improvement, so if you can correct this regression I'm ok with this. --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Matthias Klose (doko) Date: Wed, 26 Mar 2008 13:39:56 -0000 Message-Id: <20080326133956.1887.31131.malone@gangotri.canonical.com> --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Matthias Klose (doko) Date: Wed, 26 Mar 2008 13:40:17 -0000 Message-Id: <20080326134017.1887.86455.malone@gangotri.canonical.com> --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Steve Langasek (vorlon) Date: Thu, 27 Mar 2008 23:44:51 -0000 Message-Id: <20080327234452.2254.56127.malone@potassium.ubuntu.com> The new lsb package has been uploaded and passed through NEW, so closing out this bug. --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Onno Benschop (onno-itmaze) Date: Wed, 04 Jun 2008 13:47:40 -0000 Message-Id: <20080604134740.3979.4076.malone@potassium.ubuntu.com> This patch contains one more idiosyncrasy, namely, on line 90 and 91: /bin/pidof -o %PPID $1 status=3D"$?" I suspect that this needs to become: /bin/pidof -o %PPID $1 || status=3D"$?" Also, the changelog does not refer to this bug report in any way, which I u= nderstood to be a requirement for a patch. --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: =?utf-8?q?Dustin_Kirkland_=EE=83=BF_=28kirkland=29?= Date: Wed, 04 Jun 2008 14:38:00 -0000 Message-Id: <20080604143800.6163.85999.malone@gandwana.canonical.com> Debdiff attached, implementing Onno's changes. Matthias, should the lsb package be merged with Debian for Intrepid before applying this change? As it's only 2 lines changing, it may not matter... Thanks, :-Dustin --===============2080958433171968867== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Author: Martin Pitt (pitti) Date: Mon, 09 Jun 2008 09:24:34 -0000 Message-Id: <20080609092434.17754.13896.malone@palladium.canonical.com> Ah, already applied in current intrepid. --===============2080958433171968867==--