+faq should return a 404 if the id is not an int

Bug #205997 reported by Curtis Hovey
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned

Bug Description

We received an OOPS for:

   1 ValueError: invalid literal for int(): +logout
    POST: 1 Robots: 0 Local: 1
       1 https://answers.launchpad.net/phpldapadmin/+faq/+logout
        OOPS-811C1357

The user was on an bad URL /before/ he tried to logout. It appears that he edited the URL hoping to see all the faqs. He then choose to logout, which caused the oops.

We need to catch the ValueError exceptions and return a NotFoundError instead.

Tags: lp-answers
Revision history for this message
Curtis Hovey (sinzui) wrote :

kiko wants this RC-fixed. I will do the work.

Changed in launchpad:
assignee: nobody → sinzui-is
importance: Undecided → High
milestone: none → 1.2.3
status: New → Confirmed
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I don't think it's either necessary or desirable to show a notification when you do the redirect. Someone might have arrived on the /+faq URL by clicking on a mis-wrapped URL, for example. In that case, saying anything like "Your browser was redirected because you did not provide a valid FAQ ID" would be incomprehensible.

Changed in launchpad:
milestone: 1.2.3 → none
Changed in launchpad-answers:
milestone: none → 1.2.3
Curtis Hovey (sinzui)
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in RF 5959.

Changed in launchpad-answers:
status: Confirmed → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fix released in launchpad 1.2.3.

Changed in launchpad-answers:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.