[Hardy] Firebug broken with latest firefox

Bug #218519 reported by Andrew Hutchings
60
Affects Status Importance Assigned to Milestone
Mozilla Firefox
Fix Released
Medium
firefox (Ubuntu)
Fix Released
Undecided
Mozilla Bugs
Nominated for Hardy by Franck

Bug Description

Binary package hint: firefox

Release: Ubuntu Hardy i386 updated 17 Apr 2008
Package: firefox 3.0~b5+nobinonly-0ubuntu2

Expected:
Click on firebug button, a dialog pulls up from the bottom of the firefox window which can then be used for debugging.

What happens:
Click on firebug button, nothing happens. Go to tools->firebug->inspect element and a broken firebug loads.

Details:
Since firefox 3.0~b5+nobinonly-0ubuntu2 firebug won't run when the icon in the bottom right is clicked on. If you go through the tools menu and choose "Inspect Element" under the Firebug menu it will run but the main panel is just full of raw html and what appears to be broken images, no matter which tab you choose.

I have tried removing my profile, and even re-installing Ubuntu, both with the same effect. I have also tried the firebug package in Ubuntu, the 1.1b12 download from the Firebug site and 1.2 alpha from the site. All have the same problem.

Revision history for this message
In , Shaver (shaver) wrote :

Do you mean that it reports false for "instanceof Array", or do you mean that you can't call Array methods on it? The former isn't unlikely, due to the way instanceof is specified (ECMA 262-3 is pretty much hell-bent on there only being one global object), but might be fixable with some hackery on SJOWs. The latter would be more surprising.

If the issue is instanceof lying, do these work?

userObjects instanceof win.Array
userObjects instanceof win.wrappedJSObject.Array

Revision history for this message
In , Johnjbarton (johnjbarton) wrote :

For your first expression I get
invalid 'instanceof' operand win.Array;

One form of the problem is that "apply" does not take the object:
 subHandler.apply(context.firebugConsoleHandler, userObjects);
so even if your expression worked, I don't think it would help me: I need userObjects instanceof Array == true

Revision history for this message
In , Johnjbarton (johnjbarton) wrote :

Created attachment 311882
Test extension

This should have been a test for the bug, if it worked.

Revision history for this message
In , Johnjbarton (johnjbarton) wrote :

I created a test extension, but I cannot find the window objects. This wrapper stuff makes working in extensions way harder.

Revision history for this message
In , Johnjbarton (johnjbarton) wrote :

Even though this report is still lame, I am requesting blocking for FF3. Firebug needs either the type information to be fixed or a workaround. This is the only non-crash FF3 problem I can't workaround.

Revision history for this message
In , Johnjbarton (johnjbarton) wrote :
Revision history for this message
In , Johnjbarton (johnjbarton) wrote :

(In reply to comment #6)
> Created an attachment (id=312668)
Ran on
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008033005 Minefield/3.0pre

Demonstrates that
typeof(unwrapped.aFunction)
returns "object" for
var unwrapped = win.window.wrappedJSObject;

Revision history for this message
In , Dsicore (dsicore) wrote :

+'ing this so we can determine what needs to be done. bkap, thoughts?

Revision history for this message
In , Shaver (shaver) wrote :

In the absence of a typeof override as requested in Bug 427623, this probably involves forking the SJOW's class so that call+construct are present on one set (used to wrap callables), and not on the other (used to wrap non-callables). Joy. :/

Revision history for this message
In , Jonas-sicking (jonas-sicking) wrote :

Shaver says he'll apply his l33t skillz to this bug

Revision history for this message
In , Dsicore (dsicore) wrote :

Fixing the priority. P2.

Revision history for this message
In , Shaver (shaver) wrote :

Created attachment 314930
unwrap for typeof

With this patch I...might pass the test? The content area says:

  From test.xul we have typeof(aFunction):object

but the console output says

  From test.xul we have typeof(aFunction):function

John: what's the difference supposed to be between those? I'll pop into the debugger and see if I can figure out what's going on, too.

I would love if someone could turn the test extension into a mochitest, since I'll want that when I land, whether this patch is it or not.

Revision history for this message
In , Shaver (shaver) wrote :

https://build.mozilla.org/tryserver-builds/2008-04-10_11:<email address hidden>/ has try-server builds coming in, if people want to test along from home. :)

Revision history for this message
In , Johnjbarton (johnjbarton) wrote :

(In reply to comment #12)
> Created an attachment (id=314930) [details]
> unwrap for typeof
>
> With this patch I...might pass the test? The content area says:
>
> From test.xul we have typeof(aFunction):object
>
> but the console output says
>
> From test.xul we have typeof(aFunction):function
>
> John: what's the difference supposed to be between those?

The content area shows the BAD result from current FF3. The console shows your result. I'm hoping they are different ;-)

Revision history for this message
In , Shaver (shaver) wrote :

A test that always shows a fixed failure message makes me hurt inside. But I'm glad that the patch seems to work, at least! :)

Revision history for this message
In , Shaver (shaver) wrote :

Comment on attachment 314930
unwrap for typeof

Blocker with simple fix to make working with wrappers a little bit less painful; requesting approval.

Revision history for this message
In , Mrbkap (mrbkap) wrote :

Created attachment 315013
Mochitest

Here's a mochitest for this bug.

Revision history for this message
In , Shaver (shaver) wrote :

Comment on attachment 315013
Mochitest

r=shaver, want to add one for XML too?

Revision history for this message
In , Beltzner (beltzner) wrote :

Comment on attachment 314930
unwrap for typeof

a=beltzner, and for the mochitest that goes with it!

Revision history for this message
In , Shaver (shaver) wrote :

Thanks, flagging for commit. (I won't be able to watch the tree to cover it tomorrow until rather late.)

Revision history for this message
In , Johnjbarton (johnjbarton) wrote :

(In reply to comment #13)
> https://build.mozilla.org/tryserver-builds/2008-04-10_11:<email address hidden>/
> has try-server builds coming in, if people want to test along from home. :)
>

That build makes the Firebug DOM panel look normal, thanks!

Revision history for this message
In , Gavin Sharp (gavin-sharp) wrote :

mozilla/js/src/jsapi.c 3.442
mozilla/js/src/xpconnect/tests/mochitest/test_wrappers.html 1.5

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Binary package hint: firefox

Release: Ubuntu Hardy i386 updated 17 Apr 2008
Package: firefox 3.0~b5+nobinonly-0ubuntu2

Expected:
Click on firebug button, a dialog pulls up from the bottom of the firefox window which can then be used for debugging.

What happens:
Click on firebug button, nothing happens. Go to tools->firebug->inspect element and a broken firebug loads.

Details:
Since firefox 3.0~b5+nobinonly-0ubuntu2 firebug won't run when the icon in the bottom right is clicked on. If you go through the tools menu and choose "Inspect Element" under the Firebug menu it will run but the main panel is just full of raw html and what appears to be broken images, no matter which tab you choose.

I have tried removing my profile, and even re-installing Ubuntu, both with the same effect. I have also tried the firebug package in Ubuntu, the 1.1b12 download from the Firebug site and 1.2 alpha from the site. All have the same problem.

Revision history for this message
Thomas Butter (tbutter) wrote :

in the release notes of firebug a mozilla bug is mentioned which is fixed only in recent builds of firefox (post-20080413) which prevents firebug from working: https://bugzilla.mozilla.org/show_bug.cgi?id=425139

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Cool, any chance of the fix being backported?

Revision history for this message
John Vivirito (gnomefreak) wrote :

Can you please give us a link to the release notes that you have commented on and also please report or find the upstream bug report on firebug as that is the problem app not firefox.

Changed in firefox:
assignee: nobody → mozilla-bugs
status: New → Incomplete
Revision history for this message
John Vivirito (gnomefreak) wrote :

Thank you for the release notes link i missed it the first time

Revision history for this message
John Vivirito (gnomefreak) wrote :

I have everythin on this report we need for the time being lets seee what upstream does with this.

Revision history for this message
John Vivirito (gnomefreak) wrote :

This patch will be applied in upstream build and than we will pass it along to Ubuntu community.

Changed in firefox:
status: Unknown → Fix Released
Franck (alci)
Changed in firefox:
status: Incomplete → Confirmed
Revision history for this message
Franck (alci) wrote :

This bug also makes Firefox core dump quite often on somehow complex pages.
I can provide a core-dump file in case it could help.
Disableing firebug prevent crashes.

Revision history for this message
Johannes H. Jensen (joh) wrote :

When will a new package of firefox be released which includes the fix?

Revision history for this message
talv (talvbansal) wrote :

any update on this yet?

Revision history for this message
Phil-Taylor.com (phil-phil-taylor) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I feel your pain too - it has already been fixed in Firefox upstream
and we
are just waiting for this to filter down to ubuntu release

Pleas refer to the following thread:
https://bugzilla.mozilla.org/show_bug.cgi?id=425139#c13

This build works for me (Allows Firefox and Firebug to work as
expected):
https://bugzilla.mozilla.org/show_bug.cgi?id=425139#c13

I am running that build from another folder, and installed firebug with
no problems

There are also some more blocking issues discussed here:
https://bugzilla.mozilla.org/show_bug.cgi?id=411814

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQCVAwUBSAryZ/dZPrs1WM8uAQIn1AQAkka8u1Px33PYk4HueQOIEUyqiYh7R4ep
YyTmkQgHSF1VP1ZnvIt6d1IA0V7SfVoK9lacyhqcdAr7QuQpQksD07/thbrimLzJ
c0hufNLAuOCv8iPe7DTsUsdMhrLJo6Eeb1e9NSTQ/5SVkMxp0Hj93bAK78+L7Zck
7CrkllmXhmI=
=LqIX
-----END PGP SIGNATURE-----

Revision history for this message
Franck (alci) wrote :

Hi,

given that Hardy is planned for real soon now, and it is unlikely that there will be a new Firefox release until then (either beta6 or RC), is there a chance Hardy will include a fix for this bug ?

This would mean either shipping a nightly build, or backporting the patch to beta5 (I don't even know if this is doable...).

Is this likely to happen, or is it against what that package maintainer would usually do ?

Revision history for this message
kiev1 (sys-sys-admin) wrote :

Please Heeeellllpppp!!!!!!!

Revision history for this message
vinces1979 (vinces1979) wrote :

Temporary solution: I downloaded the new beta from http://download.mozilla.org/?product=firefox-3.0b5&os=linux&lang=en-US and extracted into a temp folder and run that version.

Firebug runs fine with this version

Revision history for this message
kiev1 (sys-sys-admin) wrote :

thank you, however in ubuntu hardy in this firefox is not install any extensions:

------------------------------------------------------------------------------------------------------------
Firefox could not install the file at

http://getfirebug.com/releases/firebug/1.2/firebug-1.2.0a20X.xpi

because: Unexpected installation error
Review the Error Console log for more details.
-203

Revision history for this message
John Vivirito (gnomefreak) wrote :

Right now we are in a main freeze due to RC release and we will build and upload as soon as we can but from RC to final release main is not freely able to be uploaded to, Please be patient

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

I was having the same problem as kiev1 with the custom build.
Because this is such a show stopper bug for me I have resorted to using another distro for now (Gutsy has compatibility problems with this machine so can't downgrade).

If you are in final freeze what is stopping someone creating a fix temporarily in a PPA and linking to it here to keep the masses calm?

Revision history for this message
Fran Casas (franciscoj) wrote :

Revision 562 from firebug subversion seems to work fine for me. Just get it:

svn -r 562 checkout http://fbug.googlecode.com/svn/branches/firebug1.2/

and use ant to build.

Revision history for this message
Phil-Taylor.com (phil-phil-taylor) wrote : Re: [Bug 218519] Re: [Hardy] Firebug broken with latest firefox
  • smime.p7s Edit (5.2 KiB, application/x-pkcs7-signature; name="smime.p7s")

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

You are my hero today!

This works for me.

I had to install ant first (apt-get install ant) and then build (cd
firebug1.2 && ant) and then I installed the xpi file from the dist folder

Cool!

Kindest regards
Phil.

Francisco Jose wrote:
> Revision 562 from firebug subversion seems to work fine for me. Just get
> it:
>
> svn -r 562 checkout http://fbug.googlecode.com/svn/branches/firebug1.2/
>
> and use ant to build.
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQCVAwUBSAxs0vdZPrs1WM8uAQLRdAP/WiSVqiQlpSxO2w1T9pZW7cLVxyT5db0z
AlWm7QfqU8i9AsNu8ee6YScYL7UedTXS6r7XIQ8Iq2Pq3q1NJLZbrPJUONvvJZqA
nfGbIGZTYWusmTHnfTE1Svzjq5QALJfAucaCtnedJNN/TlxQVvBYkJ3gRJiX6RGl
qcgHq2OR4IY=
=+qtb
-----END PGP SIGNATURE-----

Revision history for this message
Marc Olzheim (zlo-zlo) wrote :

On Mon, Apr 21, 2008 at 10:12:44AM -0000, Francisco Jose wrote:
> Revision 562 from firebug subversion seems to work fine for me. Just get
> it:
>
> svn -r 562 checkout http://fbug.googlecode.com/svn/branches/firebug1.2/
>
> and use ant to build.

Yes, that seems to work for me as well, thanks :-)

Marc

Revision history for this message
talv (talvbansal) wrote :

thank you so much to Francisco Jose for finding this out and to Phil-Taylor.com for explaining how to do it (i had no idea what ant was!!) now i can work without using the dreaded vista machine sitting next to me!

:)

Revision history for this message
kiev1 (sys-sys-admin) wrote :

did I get this directory, but how to install her?

Revision history for this message
kiev1 (sys-sys-admin) wrote :

I simply copied this directory over existent firebug and now he works correctly, however in a cvs version much more files what it was already installed
Thank You!

Revision history for this message
Joshua Paine (joshua-launchpad) wrote : thanks for workaround

Thanks, Francisco Jose and kiev1--seems to work again. Firebug is a major can't-live-without.

Revision history for this message
Timo Stolz (timo-stolz) wrote :

Thanks, Francisco Jose! I need firebug, too.

Revision history for this message
John Vivirito (gnomefreak) wrote :

Please test with the latest Ubuntu packages as they show up in repos. This was updated a day or 2 ago but may take a day or 2 longer before it hits the repos near you.

Revision history for this message
Joshua Paine (joshua-launchpad) wrote :

since the firefox update today, the stock firebug 1.2.0a21X is working. thanks!

Revision history for this message
Marc Olzheim (zlo-zlo) wrote : Re: [Bug 218519] Re: [Hardy] Firebug broken with latest firefox

On Wed, Apr 23, 2008 at 01:02:30AM -0000, John Vivirito wrote:
> Please test with the latest Ubuntu packages as they show up in repos.
> This was updated a day or 2 ago but may take a day or 2 longer before it
> hits the repos near you.

The new firebug 1.2~b21+svn573-0ubuntu1 package fixes it for me. Thanks!

Marc

Revision history for this message
Franck (alci) wrote :

Yes, I can confirm Firefox + Firebug from universe repository now work fine.

Great, many thanks to all that worked on it !

Revision history for this message
darko (darko) wrote :

Franck wrote:
> Yes, I can confirm Firefox + Firebug from universe repository now work
> fine.
>
> Great, many thanks to all that worked on it !
> THANKS YOU! DC
>

Revision history for this message
John Vivirito (gnomefreak) wrote :

Thank you for testing it

Changed in firefox:
status: Confirmed → Fix Released
Revision history for this message
rssaddict (simoneau-louis) wrote :

If you have a non-functional version of Firebug installed from within Firefox, uninstall it before or after installing the new one from the Ubuntu repos, and you're done.

Revision history for this message
Laurent Dinclaux (dreadlox) wrote :

The one from the repositories does not have the feature to disable enable firebug per site witch slows down browsing.

But it works.

Revision history for this message
Joshua Paine (joshua-launchpad) wrote :

@Laurent, It seems that network monitoring and script debugging are now both disabled by default for all sites and must be enabled on a case-by-case or site-by-site basis. Those would be the only parts of Firebug, I would think, that would slow a site down, so I expect that the latest builds no longer include the option because it's no longer necessary.

Network monitoring used to be enabled by default, and on sites like gmail with many XHR requests, that would cause problems.

Revision history for this message
hackel (hackel) wrote :

FYI--this bug still exists in FF 3.0~b5+nobinonly-0ubuntu3 with Firebug 1.1.0b12 (the default beta from getfirebug.com), but the Ubuntu 1.2 package works fine.

Revision history for this message
John Vivirito (gnomefreak) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hackel wrote:
| FYI--this bug still exists in FF 3.0~b5+nobinonly-0ubuntu3 with Firebug
| 1.1.0b12 (the default beta from getfirebug.com), but the Ubuntu 1.2
| package works fine.
|
That is because we made it compatible with 3.0 upstream most likely hasn't

- --
Sincerely Yours,
~ John Vivirito

https://launchpad.net/~gnomefreak
https://wiki.ubuntu.com/JohnVivirito
Linux User# 414246
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIMzUNqig4QTwcPCoRAoYRAJ9asOGa6fsDUdKRjyP/HZ8WXEoWcQCffUYt
GXvkuanzKHCtPev9FxikqQE=
=Haym
-----END PGP SIGNATURE-----

Changed in firefox:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.