the /files page explodes in an empty branch

Bug #258710 reported by Michael Hudson-Doyle
4
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
Undecided
Marius Kruger

Bug Description

I guess this is somewhat a duplicate of bug 243422, but viewing the file listing in an empty branch blows up like this:

ERROR:loggerhead.empty:Exception fetching changes
Traceback (most recent call last):
  File "/home/mwh/canonical/repos/loggerhead/trunk/loggerhead/controllers/inventory_ui.py", line 49, in get_values
    inv = h.get_inventory(revid)
  File "/home/mwh/canonical/repos/loggerhead/trunk/loggerhead/history.py", line 420, in get_inventory
    return self._branch.repository.get_revision_inventory(revid)
  File "<string>", line 4, in get_revision_inventory_read_locked
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 1627, in get_revision_inventory
    return self.get_inventory(revision_id)
  File "<string>", line 4, in get_inventory_read_locked
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 1520, in get_inventory
    return self.iter_inventories([revision_id]).next()
  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 1533, in iter_inventories
    raise ValueError('cannot get null revision inventory')
ValueError: cannot get null revision inventory

Martin Albisetti (beuno)
Changed in loggerhead:
status: New → Confirmed
Revision history for this message
Marius Kruger (amanica) wrote :

I'm not sure where to post this patch, but it at least improves the error message
to something which doesn't let you think the server is broken.

Revision history for this message
Marius Kruger (amanica) wrote :

I'm busy committing a proper fix for this, will upload a branch shortly

Changed in loggerhead:
assignee: nobody → amanica
status: Confirmed → In Progress
Revision history for this message
Marius Kruger (amanica) wrote :

merged to truonk

Changed in loggerhead:
status: In Progress → Fix Committed
Martin Albisetti (beuno)
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.