Javascript for approving / declining nominations is confusing
Bug #271697 reported by
Graham Binns
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Ian Booth | ||
Bug Description
When a bug with multiple tasks has been nominated for release, each nomination (when looked at by someone with sufficient privileges) has an approve/decline link. Clicking that link is supposed to expand the approve/decline buttons for that nomination (or at least that's how it looks based on the current format of the UI).
The trouble is that clicking on any of those links will only expand the Approve / Decline form for the first BugNomination. This is because the divs that the forms are in are named after the BugNomination, of which there is only one: they all have the same id attribute.
Related branches
lp:~wallyworld/launchpad/nominations-javascript2-271697
- Curtis Hovey (community): Approve (code)
-
Diff: 122 lines (+18/-54)2 files modifiedlib/lp/bugs/stories/bugs/xx-bug-nomination-table-row.txt (+4/-23)
lib/lp/bugs/templates/bugnomination-tasks-and-nominations-table-row.pt (+14/-31)
| Changed in malone: | |
| status: | New → Triaged |
Revision history for this message
| John Dong (jdong) wrote | #1 |
Revision history for this message
| Emmet Hikory (persia) wrote | #2 |
| Changed in launchpad: | |
| importance: | Undecided → High |
| description: | updated |
| tags: | added: bug-nomination |
| tags: | added: javascript |
| Changed in launchpad: | |
| assignee: | nobody → Ian Booth (wallyworld) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm seeing the same behavior when I look at bug https:/
Both pymsn and papayon have approve/decline links, but only the top one (papayon) expands no matter which link I click.