Source 'clean' target doesn't completely clean up

Bug #311552 reported by TJ
2
Affects Status Importance Assigned to Milestone
mythtv (Ubuntu)
Fix Released
Undecided
TJ

Bug Description

Binary package hint: mythtv

A further step in ensuring the source package rules return the source tree to the same state after a build/clean cycle.

In this case several files and directories need removing. The debian/rules clean target needs some additional statements:

diff --git a/debian/rules b/debian/rules
index abfac52..865515c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -124,6 +124,9 @@ clean:

        dh_clean Makefile config.log setup/Makefile programs/mythbackend/version.cpp \
        programs/mythfrontend/version.cpp
+ # complete the clean-up
+ dh_clean libs/libmythupnp/version.cpp bindings/perl/Makefile.perl.old
+ rm -rf bindings/python/build

 install: build
        dh_testdir

Related branches

Changed in mythtv:
assignee: nobody → intuitivenipple
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mythtv - 0.21.0+fixes19136-0ubuntu3

---------------
mythtv (0.21.0+fixes19136-0ubuntu3) jaunty; urgency=low

  [ Michael Haas ]
  * Drop debian/patches/28_fix_v4l.dpatch because upstream
    fixed this properly in r19250.

  [ Mario Limonciello ]
  * debian/mythtv-database.postinst:
    - Don't reset the backend IPs unless you
      are loading a database
    - Pre-set mythbuntu theme. If mythbuntu theme isn't
      around, G.A.N.T. gets loaded instead, so no expected
      regresssions.
  * debian/mythtv-database.config:
    - Try to get answer from mysql-server config if possible
      this avoids asking admin pass question twice.
    - Check if mysql binary is around before repeatedly
      asking questions.
   - Check if localhost that mysqld is running. If it's
      not, then don't keep asking questions.
    - Pass on failed answer to postinst (don't reset)
  * debian/mythtv-common.config:
    - Display the password that is set, not just "value set"
  * debian/mythtv-common.postinst:
    - Only create a user if it doesn't already exist. (LP: #280974)
  * debian/rules:
    - Unset executable permissions on .sh and .d files in clean
      section. (LP: #311573)
    - Don't restart mythtv-backend on upgrade of packages.
      Unexpected behavior might happen depending on what other packages
      are installed at that time and what will still be installed.
      The common use case for a problem here is dist-upgrades.
      (LP: #298914)
  * Store .sh and .d files as non executable in bzr to better reflect
    flat packaging as seen in the archive.
  * debian/patches/24_fix_h264_frame_counting.dpatch:
    - Remove .orig file from the patch as it's unnecessary (LP: #311549)
  * debian/mythtv-backend.postinst:
    - If we are mounted on NFS, changing permissions will fail. Don't
      fail the postinst in this case. (LP: #299352)

  [ TJ ]
  * debian/rules:
    - Cleanup files that upstream is forgetting to clean between builds.
      (LP: #311552)

 -- Mario Limonciello <email address hidden> Fri, 02 Jan 2009 14:28:58 -0600

Changed in mythtv:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.