bug: 314016
title: Kate is useless for editing code which contains hebrew or arabic
date-reported: Mon, 05 Jan 2009 10:38:22 -0000
date-updated: Mon, 21 Feb 2011 23:35:08 -0000
reporter: Diego Iastrubni (elcuco)
duplicate-of: 
duplicates: 
attachments: 
 https://bugs.launchpad.net/bugs/314016/+attachment/467809/+files/kdesdk_4.1.4-0ubuntu1~intrepid1.1.dsc text/plain
 https://bugs.launchpad.net/bugs/314016/+attachment/467810/+files/kdesdk_4.1.4-0ubuntu1~intrepid1.1.diff.gz text/x-diff
 https://bugs.launchpad.net/bugs/314016/+attachment/468757/+files/kde4libs_4.1.4-0ubuntu1~intrepid1.1.dsc text/plain
 https://bugs.launchpad.net/bugs/314016/+attachment/468758/+files/kde4libs_4.1.4-0ubuntu1~intrepid1.1.diff.gz text/x-diff
 https://bugs.launchpad.net/bugs/314016/+attachment/485943/+files/kde4libs_4.1.4-0ubuntu1~intrepid1.2.diff.gz text/x-diff
 https://bugs.launchpad.net/bugs/314016/+attachment/485944/+files/kde4libs_4.1.4-0ubuntu1~intrepid1.2.dsc text/plain
patches: 
tags: 
subscribers: 
 Diego Iastrubni (elcuco)
 Ubuntu Stable Release Updates Team (ubuntu-sru)
 SRU Verification (sru-verification)

task: kde4libs (Ubuntu)
status: Fix Released
date-created: Mon, 05 Jan 2009 10:38:22 -0000
date-left-new: Mon, 05 Jan 2009 13:34:13 -0000
date-confirmed: Mon, 05 Jan 2009 18:18:35 -0000
date-triaged: Thu, 19 Feb 2009 13:18:34 -0000
date-assigned: Thu, 19 Feb 2009 13:18:34 -0000
date-inprogress: Thu, 19 Feb 2009 13:18:34 -0000
date-closed: Thu, 19 Feb 2009 14:00:24 -0000
date-fix-committed: Thu, 19 Feb 2009 14:00:24 -0000
date-fix-released: Thu, 19 Feb 2009 14:00:24 -0000
reporter: Diego Iastrubni (elcuco)
importance: Medium
component: universe
assignee: Jonathan Thomas (echidnaman)
milestone: 

task: kde4libs (Ubuntu Intrepid)
status: Won't Fix
date-created: Thu, 19 Feb 2009 14:16:37 -0000
date-left-new: Thu, 19 Feb 2009 14:30:34 -0000
date-assigned: Thu, 19 Feb 2009 14:30:34 -0000
date-closed: Mon, 28 Sep 2009 13:16:56 -0000
reporter: Jonathan Riddell (jr)
importance: Medium
assignee: Jonathan Thomas (echidnaman)
milestone: intrepid-updates

Content-Type: multipart/mixed; boundary="===============0130079054677627777=="
MIME-Version: 1.0

--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

*Below added by Jonathan Thomas*
   Stable Release Update (SRU) infos:
   -Impact: Text editing for RTL languages becomes difficult, see bug descr=
iption below
   -Addressed by: This bug has been addressed by adding an upstream patch i=
ncluded in KDE 4.2 that fixes this.
   -Testcase: Install kate. Start kate. Copy the php code from the bug desc=
ription and paste it in to kate
   -Patch/regression potential: Small. The changes were part of the recent =
KDE 4.2 release and we have had no complaints yet.
 #######################################################################

This is a request for a backport from trunk to 4.1.3 in ubuntu. The
original bug is https://bugs.kde.org/show_bug.cgi?id=3D178594

"Back in March someone (who shall remain un-named) added to kate a new
function which would calculate the "best direction" of a paragraph by
counting the LTR and RTL chars in that line. That is r788729:
http://websvn.kde.org/trunk/KDE/kdelibs/kate/render/katerenderer.cpp?r1=3D7=
72931&r2=3D788729
The last month I found a really ugly "bug" in it.

Imagine this php code:

function foo() {=20
  $a =3D "=D7=A9=D7=9C=D7=95=D7=9D =D7=A2=D7=95=D7=9C=D7=9D";=20
  return $a;=20
}=20

Now paste it into kate and see what happens. This get funkier when the
hebrew is inside lists or hashes. IMHO, this renders this "feature"
useless - much more people will be using kate to code then to write
"plain text". My proposal is detecting the paragraph direction using
QString::isRightToLeft() and in 4.3 also provide a manual method for
setting the direction of the paragraph. IMHO, this renders kate unusable
for editing code."

A visual display of how code looks can be seen here:
http://elcuco.blogli.co.il/files/2009/01/kate-hebrew-code-broken.png

I am requesting a backport of changeset 905112 to the currently
available packages in 8.10. See the patch here:
http://websvn.kde.org/?view=3Drev&revision=3D905112 (it will apply to the
branch as well).
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Harald Sitter (apachelogger)
Date: Mon, 05 Jan 2009 13:34:12 -0000
Message-Id: <20090105133413.7390.51808.malone@potassium.ubuntu.com>

Why does the fix not get backported by KDE to the 4.1 branch and thus
4.1.4?
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Diego Iastrubni (elcuco)
Date: Mon, 05 Jan 2009 17:57:20 -0000
Message-Id: <20090105175721.27596.24749.malone@palladium.canonical.com>

first, because kde 4.1.4 is tagged in a few hours ;-)
second, because this is a behavior change inside a branch - not accepted.

From KDE's point of view, 4.2.0 is released in a week, or two or three
and 4.1.4 is obsolete (more or less...). From the ubuntu point of view:
4.1.4 should be supported for a year (this is the policy no?). I would
not like to continue coding broken php code under this kate...
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Harald Sitter (apachelogger)
Date: Mon, 05 Jan 2009 18:18:34 -0000
Message-Id: <20090105181835.13992.17436.malone@gandwana.canonical.com>

sounds sensible
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Thu, 19 Feb 2009 13:18:33 -0000
Message-Id: <20090219131834.9580.7689.malone@palladium.canonical.com>

The code being patched is actually in kde4libs. Working on this one now.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Thu, 19 Feb 2009 14:00:24 -0000
Message-Id: <20090219140024.9580.83859.malone@palladium.canonical.com>

I'm marking this fixed since it is fixed in the current development
version of Jaunty, but I'm also nominating it for Intrepid
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Diego Iastrubni (elcuco)
Date: Thu, 19 Feb 2009 15:59:39 -0000
Message-Id: <20090219155940.21070.68284.malone@palladium.canonical.com>

I was actually hooping this would get backported to KDE 4.1 in Ubuntu
8.10, not everyone uses the unsupported KDE 4.2 in Ubuntu 8.10.

Marking this as "we fixed this problem" is not exactly correct, and not
what I requested.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Thu, 19 Feb 2009 16:14:53 -0000
Message-Id: <20090219161454.10400.92787.malone@potassium.ubuntu.com>

That's what I'm doing. That's what I said I was doing too.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Thu, 19 Feb 2009 20:02:05 -0000
Message-Id: <20090219200205.8932.37121.malone@gangotri.canonical.com>

Source package for intrepid-proposed, as promised.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Thu, 19 Feb 2009 20:02:40 -0000
Message-Id: <20090219200240.470.85051.malone@potassium.ubuntu.com>


--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Diego Iastrubni (elcuco)
Date: Thu, 19 Feb 2009 21:19:34 -0000
Message-Id: <20090219211934.10497.24523.malone@potassium.ubuntu.com>

Jonathan, HUGE THANKS!

But please... pretty please... (and that is for all other ubuntu
developers) please be more specific when writing in these bug reports.
Not everyone is a native english speaker, and many time I fail to
understand what did you really meant.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Martin Pitt (pitti)
Date: Fri, 20 Feb 2009 11:16:48 -0000
Message-Id: <20090220111648.13920.83054.malone@gandwana.canonical.com>

SRU ack, please upload.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Fri, 20 Feb 2009 15:38:38 -0000
Message-Id: <20090220153839.21025.99596.malone@palladium.canonical.com>

Oops, that was the source package for the other SRU I was doing for kdesdk.=
..
Here's the real one. (Also fixes bug 330446)
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Fri, 20 Feb 2009 15:39:07 -0000
Message-Id: <20090220153907.21025.54493.malone@palladium.canonical.com>


--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Riddell (jr)
Date: Fri, 20 Feb 2009 15:55:50 -0000
Message-Id: <20090220155550.13920.66624.malone@gandwana.canonical.com>

Uploaded to intrepid-proposed, awaiting approval.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Martin Pitt (pitti)
Date: Mon, 09 Mar 2009 09:53:30 -0000
Message-Id: <20090309095330.2746.10461.malone@potassium.ubuntu.com>

Accepted into intrepid-proposed; please test and give feedback here.
Please see https://wiki.ubuntu.com/Testing/EnableProposed for
documentation how to enable and use -proposed. Thank you in advance!
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Martin Pitt (pitti)
Date: Mon, 09 Mar 2009 09:54:54 -0000
Message-Id: <20090309095454.10190.58109.malone@gangotri.canonical.com>

Sorry, belay that:

FAILED: kde4libs (kde4libs_4.1.4-0ubuntu1~intrepid1.1.diff.gz is already
published in archive for intrepid)

1.1 was a no-change rebuild in -security to fix dependencies. Please
reupload as intrepid1.2.
--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Mon, 09 Mar 2009 13:07:36 -0000
Message-Id: <20090309130736.8614.14508.malone@gangotri.canonical.com>


--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Mon, 09 Mar 2009 13:08:09 -0000
Message-Id: <20090309130809.6970.8661.malone@gandwana.canonical.com>


--===============0130079054677627777==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Jonathan Thomas (echidnaman)
Date: Mon, 28 Sep 2009 13:16:54 -0000
Message-Id: <20090928131655.3899.83691.malone@gangotri.canonical.com>

Ugh, sorry. The original upload with the fix failed and I never got
around to uploading a new one. Totally forgot about it. Though at this
point it'd probably be better to upgrade to Jaunty, or at least KDE 4.2.
--===============0130079054677627777==--