support for multiple test runners appears to have bitrotted.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Storm |
Fix Released
|
Low
|
James Henstridge |
Bug Description
The Storm test suite contains code to run the tests under the unittest, trial and py.test test runners. We usually only test the unittest runner though, and it seems that the others have bitrot.
Trying the py.test runner results in:
$ STORM_TEST_
Traceback (most recent call last):
File "./test", line 184, in <module>
File "./test", line 104, in test_with_py_test
File "/usr/lib/
File "/usr/lib/
File "/usr/lib/
File "/usr/lib/
clist = self.getconftes
File "/usr/lib/
File "/usr/lib/
mod = configpath.
File "/usr/lib/
mod = __import__(modname, None, None, ['__doc__'])
File "/home/
import py.test.compat
ImportError: No module named compat
Running with the trial test runner also has problems with the django tests (appears to be in the test discovery code):
$ STORM_TEST_
Traceback (most recent call last):
File "/usr/lib/
File "/usr/lib/
File "/usr/lib/
for p in plugin.
File "/usr/lib/
allDropins = getCache(package)
--- <exception caught here> ---
File "/usr/lib/
File "/usr/lib/
File "/usr/lib/
return open(self.path, mode+'b')
exceptions.
Traceback (most recent call last):
File "./test", line 184, in <module>
File "./test", line 93, in test_with_trial
trial.run()
File "/usr/lib/
suite = _getSuite(config)
File "/usr/lib/
return loader.
File "/usr/lib/
for thing in set(things)]
File "/usr/lib/
return self.loadModule
File "/usr/lib/
for testClass in self.findTestCl
File "/usr/lib/
if isTestCase(val):
File "/usr/lib/
return issubclass(obj, pyunit.TestCase)
File "/var/lib/
File "/var/lib/
raise ImportError(
ImportError: Settings cannot be imported, because environment variable DJANGO_
I'm not sure whether it is worth keeping the py.test support, but the trial code might be necessary to properly test twisted-
If we get rid of py.test support, we've only got unittest-compatible frameworks left. We could then use the same test discovery code for running under unittest and trial, which would reduce the amount of infrequently used infrastructure.
Related branches
- Thomas Herve (community): Approve
- Jamu Kakar (community): Approve
-
Diff: 337 lines (+43/-226)3 files modifiedtest (+40/-93)
tests/conftest.py (+0/-133)
tests/helper.py (+3/-0)
Changed in storm: | |
importance: | Undecided → Low |
Changed in storm: | |
milestone: | none → 0.16 |
Changed in storm: | |
status: | Fix Committed → Fix Released |
Fix merged as r339.