bug: 332314
title: NoSuchRevision when pushing to RemoteBranch
date-reported: Fri, 20 Feb 2009 23:25:11 -0000
date-updated: Sat, 21 Feb 2009 02:49:09 -0000
reporter: Andrew Bennetts (spiv)
duplicate-of: 
duplicates: 
attachments: 
patches: 
tags: hpss
subscribers: 
 Andrew Bennetts (spiv)

task: bzr
status: Fix Released
date-created: Fri, 20 Feb 2009 23:25:11 -0000
date-left-new: Fri, 20 Feb 2009 23:25:34 -0000
date-confirmed: Fri, 20 Feb 2009 23:25:34 -0000
date-triaged: Sat, 21 Feb 2009 01:14:36 -0000
date-assigned: Fri, 20 Feb 2009 23:59:22 -0000
date-inprogress: Sat, 21 Feb 2009 01:14:36 -0000
date-closed: Sat, 21 Feb 2009 01:14:36 -0000
date-fix-committed: Sat, 21 Feb 2009 01:14:36 -0000
date-fix-released: Sat, 21 Feb 2009 01:14:36 -0000
reporter: Andrew Bennetts (spiv)
importance: Critical
assignee: Robert Collins (lifeless)
milestone: 

Content-Type: multipart/mixed; boundary="===============5406524410887064182=="
MIME-Version: 1.0

--===============5406524410887064182==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

I just got this:

Traceback (most recent call last):
  File "/home/andrew/code/bzr/bzrlib/commands.py", line 921, in run_bzr_cat=
ch_errors
    return run_bzr(argv)
  File "/home/andrew/code/bzr/bzrlib/commands.py", line 866, in run_bzr
    ret =3D run(*run_argv)
  File "/home/andrew/code/bzr/bzrlib/commands.py", line 547, in run_argv_al=
iases
    return self.run(**all_cmd_args)
  File "/home/andrew/code/bzr/bzrlib/builtins.py", line 981, in run
    use_existing_dir=3Duse_existing_dir)
  File "/home/andrew/code/bzr/bzrlib/push.py", line 160, in _show_push_bran=
ch
    stop_revision=3Drevision_id)
  File "/home/andrew/code/bzr/bzrlib/decorators.py", line 138, in read_lock=
ed
    result =3D unbound(self, *args, **kwargs)
  File "/home/andrew/code/bzr/bzrlib/branch.py", line 1970, in push
    _override_hook_source_branch=3D_override_hook_source_branch)
  File "/home/andrew/code/bzr/bzrlib/branch.py", line 2681, in _run_with_wr=
ite_locked_target
    result =3D callable(*args, **kwargs)
  File "/home/andrew/code/bzr/bzrlib/branch.py", line 2009, in _push_with_b=
ound_branches
    result =3D self._basic_push(target, overwrite, stop_revision)
  File "/home/andrew/code/bzr/bzrlib/branch.py", line 2032, in _basic_push
    graph=3Dgraph)
  File "/home/andrew/code/bzr/bzrlib/decorators.py", line 192, in write_loc=
ked
    result =3D unbound(self, *args, **kwargs)
  File "/home/andrew/code/bzr/bzrlib/remote.py", line 1974, in update_revis=
ions
    self._set_last_revision_descendant(stop_revision, other)
  File "/home/andrew/code/bzr/bzrlib/remote.py", line 1777, in _set_last_re=
vision_descendant
    history =3D self._lefthand_history(revision_id)
  File "/home/andrew/code/bzr/bzrlib/branch.py", line 190, in _lefthand_his=
tory
    raise errors.NoSuchRevision(self, revision_id)
NoSuchRevision: RemoteBranch(bzr+ssh://people.ubuntu.com/home/andrew/public=
_html/bzr/suspend-write-group/) has no revision andrew.bennetts@canonical.c=
om-20090220232006-07u7152q6fi5ul9d

bzr 1.13dev on python 2.5.2 (linux2)
arguments: ['/home/andrew/code/bzr/bzr', '-Dhpss', 'push']

The problem seems to be that the client isn't falling back to pre-1.13
logic when the Repository.insert_stream RPC is unavailable:

...
24.011  hpss call w/body stream: ('Repository.insert_stream', 'home/andrew/=
public_html/bzr/')
26.550     result:   ('UnknownMethod', 'Repository.insert_stream')
26.551  hpss call:   'delete', '/home/andrew/public_html/bzr/.bzr/repositor=
y/upload/e7kiy5xz8xwglrmhbndo.pack'
26.551               (to bzr+ssh://people.ubuntu.com/home/andrew/public_htm=
l/bzr/suspend-write-group/)
26.904     result:   ('ok',)
26.905  hpss call:   'PackRepository.autopack', 'home/andrew/public_html/bz=
r/'
26.905               (to bzr+ssh://people.ubuntu.com/home/andrew/public_htm=
l/bzr/suspend-write-group/)
27.274     result:   ('ok',)

(Then just a delete, get, get_parent_map, and unlock.  Then the
traceback happens.)
--===============5406524410887064182==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Robert Collins (lifeless)
Date: Fri, 20 Feb 2009 23:29:06 -0000
Message-Id: <20090220232906.21025.77111.malone@palladium.canonical.com>

Is this a stacked branch or non stacked?
--===============5406524410887064182==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Robert Collins (lifeless)
Date: Fri, 20 Feb 2009 23:59:22 -0000
Message-Id: <20090220235922.12765.23330.malone@potassium.ubuntu.com>

Workaround getting tested at the moment.
--===============5406524410887064182==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Author: Andrew Bennetts (spiv)
Date: Sat, 21 Feb 2009 01:14:35 -0000
Message-Id: <20090221011436.20340.71722.malone@gangotri.canonical.com>

Robert has landed a fix, and it works for me.
--===============5406524410887064182==--