.desktop file cleanup for gnome-system-log

Validation changes only.

Thanks for your bug. Maybe next time you could mail a list or ask on IRC before flooding the bug tracker like that?
- those changes would better go upstream (we can forward them so that's fine)
- better to send a patch that a new .desktop
- having a description of what issues are fixed and what is changed is useful

This updated patch update adds a semicolon the the Categories list for gnome-system-log. This is required to satisfy desktop-file-validate.

Differences from the original patch below:

--- 04_menu_changes.dpatch 2006-03-04 16:36:32.000000000 +0900
+++ 04_menu_changes.dpatch.orig 2006-03-04 16:35:51.000000000 +0900
@@ -24,7 +24,7 @@
  Type=Application
  StartupNotify=true
 -Categories=GTK;GNOME;Application;System;Monitor;X-Red-Hat-Base;
-+Categories=GNOME;Application;System;Settings;
++Categories=GNOME;Application;System;Settings
  X-GNOME-DocPath=gnome-system-log/gnome-system-log.xml
  X-GNOME-Bugzilla-Bugzilla=GNOME
  X-GNOME-Bugzilla-Product=gnome-utils

Confirming this. I get the following output when I try to validate:

carthik@umberto:~$ desktop-file-validate /usr/share/applications/gnome-system-log.desktop
/usr/share/applications/gnome-system-log.desktop: error: value of key "Categories" is a list of strings and must end with a semicolon

This is at least fixed in Gutsy.

Well, actually, it's not fixed in gutsy (at least for me, today, with gnome-utils 2.18.1-1ubuntu1). To replicate the error, execute `desktop-file-validate /usr/share/applications/gnome-system-log.desktop` on a machine wth gnome-utils installed.

At this point, there have been some changes in the best practices for .desktop files, and the supplied patch is not necessarily correct (or aat least will not cause the above command to have no output). On the other hand, this is such an incrediby minor bug, and requires someone to upload to main (which hasn't happened for over a year now), so I don't see any value in a new patch until there is an intent to upload (at which point it's 2 minutes for the uploader to fix by hand, to then current standards).

The bug has been fixed upstream now

gnome-utils (2.19.91-0ubuntu1) gutsy; urgency=low

  * New upstream version
    - Second unstable release of the 2.19 cycle
    - Requires GLib >= 2.13.3 and GTK+ >= 2.10.0
    - Remove invalid "Application" category from every desktop entry file
      (LP: #33576)
    Baobab
    - Nothing
    Dictionary
    - Fix bug #414013 - Fix out of tree builds
    - Fix bug #419894 - Handle decomposed strings
    Floppy
    - Nothing
    Screenshot
    - Fix bug #455204 - Use XDG User Directories API to find the
      Desktop directory (LP: #134979)
    Search Tool
    - Nothing
    System Log Viewer
    - Fix bug #413498 - Fix a memory leak
    - Fix bug #442846 - Do not crash when saving the session
  * debian/control.in:
    - updated the libglib requirement
  * debian/patches/02_autoconf.patch:
    - updated
  * debian/patches/04_menu_changes.patch:
    - updated
  * debian/patches/06_fix_logview_crasher.patch:
    - dropped, fixed with the new version

 -- Sebastien Bacher <email address hidden> Mon, 27 Aug 2007 10:52:12 +0200