No clean way to get the underlying Storm ResultSet from an SQLObjectResultSet

Bug #338184 reported by Gavin Panella
2
Affects Status Importance Assigned to Milestone
Storm
Fix Released
Undecided
Gavin Panella

Bug Description

In Launchpad, because we use both the native Storm API and have lots of older code using the SQLObject shim, we sometimes need to get at the underlying Storm ResultSet from an SQLObjectResultSet. That's possible via so_result_set._result_set, but it's not a public interface. It also doesn't play well in our Zope environment where result sets are always wrapped in security proxies.

For a Zope environment, one proposed solution (from Francis Lacoste) is to create a trusted adapter from ISQLObjectResultSet to IResultSet.

Tags: tech-debt

Related branches

Revision history for this message
James Henstridge (jamesh) wrote :

So I guess this is intended as a way to gradually migrate callers of a heavily used API so that it can then be switched to Storm native?

If it makes it easier for you to get off the compatibility layer, I'm all for it. I've created a merge proposal for your branch so we can review it.

Gavin Panella (allenap)
Changed in storm:
assignee: nobody → allenap
status: New → In Progress
Revision history for this message
James Henstridge (jamesh) wrote :

Fix merged to trunk as r303.

Changed in storm:
status: In Progress → Fix Committed
Changed in storm:
milestone: none → 0.15
Jamu Kakar (jkakar)
Changed in storm:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: tech-debt
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.