crash on "bzr add" -- changed symlink to actual directory

Bug #341555 reported by Kyle Dickerson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
High
Unassigned

Bug Description

I removed a symlink and instead created an actual directory with the same name. "bzr add" crashed with the following output. After using "bzr --keep remove DIR_NAME" and then "bzr add DIR_NAME" everything worked just fine.

$ bzr add
bzr: ERROR: exceptions.AttributeError: children

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 857, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 387, in run
    no_recurse, action=action, save=not dry_run)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 52, in tree_write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 432, in smart_add
    elif subf in this_ie.children:
AttributeError: children

bzr 1.6.1 on python 2.5.2 (linux2)
arguments: ['/usr/bin/bzr', 'add']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.6.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

Tags: oem-services
description: updated
Revision history for this message
Martin Pool (mbp) wrote :

in bzr 2.1 this works correctly.

Changed in bzr:
status: New → Fix Released
Revision history for this message
Cody A.W. Somerville (cody-somerville) wrote :

Well, its broken again in bzr 2.1.1 :)

Changed in bzr:
status: Fix Released → Confirmed
Revision history for this message
Cody A.W. Somerville (cody-somerville) wrote :
tags: added: oem-services
Revision history for this message
Cody A.W. Somerville (cody-somerville) wrote :

FYI, bzr works fine if you replace the symlink with a file. It only throws the exception when you replace the symlink with a directory.

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 341555] Re: crash on "bzr add" -- changed symlink to actual directory

thanks for reconfirming this.

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.