more debug for DHCP client

Bug #35265 reported by Peter Miller
6
Affects Status Importance Assigned to Milestone
dhcp3 (Ubuntu)
Fix Released
Medium
Martin Pitt

Bug Description

When trying to debug DHCP problems, it can be very useful to have the offered client IP address printed in the debug messages, in addition to the offering server's IP address.

Revision history for this message
Peter Miller (pmiller-opensource) wrote : additional hdcp client debugging

This patch adds the offered client address to debug messages

Revision history for this message
Matt Zimmerman (mdz) wrote :

Patch available for review

Changed in dhcp3:
assignee: nobody → keybuk
Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

Giving to Martin who's been looking after dhclient more than I have, so will understand the implications

Changed in dhcp3:
assignee: keybuk → pitti
Changed in dhcp3:
status: Unconfirmed → Confirmed
Martin Pitt (pitti)
Changed in dhcp3:
status: Confirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

dhcp3 (3.0.6.dfsg-1ubuntu9) hardy; urgency=low

  * Add debian/patches/dhclient-more-debug.dpatch: Show the requested/offered
    client IP in log output, for better debugging. Thanks to Peter Miller for
    the patch! (Closes: #35265)

 -- Martin Pitt < <email address hidden>> Wed, 02 Apr 2008 15:30:15 +0200

Changed in dhcp3:
status: In Progress → Fix Released
Revision history for this message
Alan Jenkins (aj504) wrote :

This patch is buggy! It causes disturbing messages with "<null address>" every time dhclient attempts to renew the lease. Unfortunately on my system the lease time is 1 hour and renewal takes many (~30) retries to succeed. I obviously suspected this <null address> of causing problems, but it turned out the message was just buggy and the problem is elsewhere. Please fix this, it affects everyone and it makes debugging slightly more complex DHCP problems more confusing.

Please re-open this issue and read <http://marc.info/?l=dhcp-users&m=121017450721761&w=2>. I emailed Martin, but with no response so far I thought it was best to get this issue tracked.

Revision history for this message
Martin Pitt (pitti) wrote :

Reopening, thanks for pointing out!

Changed in dhcp3:
status: Fix Released → In Progress
importance: Wishlist → Medium
Revision history for this message
Martin Pitt (pitti) wrote :

Upstream's hint was not very precise, since ciaddr is the server address, not the current client address. I fixed the patch now, thanks!

Martin Pitt (pitti)
Changed in dhcp3:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (7.8 KiB)

This bug was fixed in the package dhcp3 - 3.1.1-1ubuntu1

---------------
dhcp3 (3.1.1-1ubuntu1) intrepid; urgency=low

  * Merge from debian unstable. Remaining Ubuntu changes:
    - debian/control, debian/dhcp3-server.init.d: LSB init script.
      (Debian #486508)
    - Deroot server (Debian #308832)
      + debian/patches/droppriv.dpatch, deroot-server.dpatch: Code changes.
      + debian/control: Build-depend on libcap-dev.
      + debian/dhcp3-server.post{inst,rm}: Create/remove dhcpd system user.
      + debian/dhcp3-server.init.d: Create paths with appropriate permissions
        for dhcpd system user access.
    - Send hostname to DHCP server by default (LP #10239, Debian #151820):
      + debian/patches/dynamic-hostname.dpatch: Add support for a new string
        type 'h' which behaves like 't' except that '<hostname>' is changed to
        the current hostname. Change 'host-name' DHCP option type from 't' to 'h'.
      + debian/dhclient.conf: Enable send-hostname by default.
    - debian/rules: Remove client/scripts/debian on clean again.
      (Debian #486514)
    - dhclient-onetry-call-clientscript.dpatch: Call 'dhclient-script FAIL'
      when failing to get an address also when operating in oneshot mode (-1).
      This fixes avahi-autoipd invocation through dhcdbd. (Debian #486520)
    - debian/dhcp3-server.init.d, debian/dhcp3-server.postinst: Do not install
      unnecessary rc.d symlinks for levels 0 and 6, for faster shutdown.
      (Debian #486518)
    - debian/dhclient-script.linux: Do not clobber old search/domain values if
      we didn't get any from the DHCP response. (Debian #486535)
    - debian/patches/dhcpd.conf-subnet-examples.dpatch: Give an example for
      subnet-mask in dhcpd.conf. (LP #26661)
    - dhclient-more-debug.dpatch: Show the requested/offered client IP in log
      output, for better debugging. (LP #35265, Debian #486611)
    - debian/dhclient-script.linux: Wait for /etc/resolv.conf to become writable.
    - revert-next-server.dpatch: Revert the need of the next-server option in
      dhcpd.conf so it points to the own IP again for tftp if the option is not
      set. (Patch by Oliver Grawert; disputed upstream)
    - debian/dhcp3-server.init.d: Allow LTSP to override default configuration
      in /etc/ltsp/dhcpd.conf. Point that out in a header comment in
      debian/dhcpd.conf. (Ubuntu specific)
    - debian/dhcp3-server.config: Drop debconf question to medium. (Ubuntu
      specific)
  * Drop obsolete Ubuntu changes:
    - debian/dhclient.conf: Get the interface-mtu parameter again. Previous
      Ubuntu versions ignored it because of broken old DHCP servers which hand
      out the wrong value. (LP#61989) However, this breaks correct and
      deliberately sent non-default values, which is a bigger pain. If this is
      still an issue, a better fix is to discard unplausibly low values only.
    - Drop the client derooting patch. It is very intrusive, never offered true
      protection (susceptible to $PATH injection and other bypasses), and is a
      constant source of bugs. (LP: #39249)
    - Drop the pm-utils hook for stopping/starting dhcp3-server on
      suspend/resume. This was ne...

Read more...

Changed in dhcp3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.