Crashes when File->export->Gallery->Album->Add button clicked before an export Gallery is setup

Bug #35569 reported by Chris Kühl
8
Affects Status Importance Assigned to Milestone
f-spot (Ubuntu)
Fix Released
Medium
Andrew Mitchell

Bug Description

The Add button beside Album in the File->Export->Gallery dialog should not be sensative before an export Gallery is configured. Otherwise it crashes f-spot when clicked.

This is fixed upstream, btw.

Revision history for this message
Andrew Mitchell (ajmitch) wrote :

Are you using F-Spot in dapper or breezy?

Revision history for this message
Chris Kühl (blixtra) wrote :

This is on Dapper with all updates. Sorry.

Revision history for this message
Andrew Mitchell (ajmitch) wrote :

Another bug to be fixed with the pending 0.1.11 upload

Changed in f-spot:
assignee: nobody → ajmitch
status: Unconfirmed → In Progress
Revision history for this message
Andrew Mitchell (ajmitch) wrote :

0.1.11 uploaded & built

Changed in f-spot:
status: In Progress → Fix Released
Revision history for this message
Chris Kühl (blixtra) wrote :

Just updated to 0.1.11 and f-spot still shuts down when clicking album -> "Add" before a Gallery is set-up. However, it now catches the exception, displays it in a dialog and then shuts down.

I built F-spot from CVS when I originally filed this bug and the Add button was not clickable (sensitive) before setting up a Gallery. That's the way it should behave.

Revision history for this message
Chris Kühl (blixtra) wrote :

I've confirmed this is still happening on several machines

Changed in f-spot:
status: Fix Released → Confirmed
Revision history for this message
Chris Kühl (blixtra) wrote :

Ok i can't really submit a patch since it's fixed upstream but I can tell you exactly where it is in the source code in order to merge it.

In file GalleryExport.cs line 743 is where I think the fix is.

if (disconnected)
 album_button.Sensitive = false;

line 765 turns it back on.

hope that helps

Revision history for this message
Andrew Mitchell (ajmitch) wrote :

Fixed in 0.2.0-1, will upload once freeze exception is granted

Changed in f-spot:
status: Confirmed → Fix Committed
Revision history for this message
Andrew Mitchell (ajmitch) wrote :

Uploaded 0.2.0-1ubuntu1 to edgy

Changed in f-spot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.