Please merge audacious 2.0.1-1 (universe) from Debian unstable (main)

Bug #383271 reported by Jean-Louis Dupond
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
audacious (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: audacious

audacious (2.0.1-1) unstable; urgency=low

  [ William Pitcock ]
  * New upstream release.
  * debian/patches/audacious-play-files-from-commandline.patch: dropped
  * debian/patches/bugzilla-42.patch: dropped

  [ John Lindgren ]
  * Fix improper behaviour when the file info dialog is closed.
    (Closes: #495427)
  * Fix crash with 'audtool help playback-seek-relative'.
    (Closes: #512910)
  * Fix some problems seeking while paused.
    (Closes: #517692)
  * Fix behaviour of -t argument when Audacious is not already running.
    (Closes: #497602)

  [ Andrew O. Shadoura ]
  * Include track number in MPRIS exported metadata.
    (Closes: #514426)

  [ Benjamin Drung ]
  * debian/patches/003-change-default-skin.patch: Corrected path
    (skins -> Skins)

 -- William Pitcock <email address hidden> Fri, 29 May 2009 21:25:03 -0500

Changed in audacious (Ubuntu):
assignee: nobody → Jean-Louis Dupond (dupondje)
status: New → In Progress
Changed in audacious (Ubuntu):
status: In Progress → Confirmed
assignee: Jean-Louis Dupond (dupondje) → nobody
Revision history for this message
Jean-Louis Dupond (dupondje) wrote :
Revision history for this message
William Pitcock (nenolod) wrote : Re: [Bug 383271] Re: Please merge audacious 2.0.1-1 (universe) from Debian unstable (main)

Hi,

On Wed, 2009-06-03 at 20:30 +0000, Jean-Louis Dupond wrote:
> ** Attachment removed: "Debdiff of debian dsc & ubuntu1 dsc"
> http://launchpadlibrarian.net/27467532/deb.diff
>
> ** Attachment added: "Debdiff of debian dsc & ubuntu1 dsc"
> http://launchpadlibrarian.net/27469484/deb2.diff
>

This merge is done wrong. Specifically, it

 - doesn't list the remaining Ubuntu changes;
 - adds new changes without adding any rationale for doing so;
 - doesn't follow the standard changelog format for merges.

I would prefer to overlook the changes in the Ubuntu packaging. It
hasn't received much attention since my last restructuring of the Ubuntu
patchset in 1.4. I'm sure there's cruft in it that needs to go, and
other patches that need to be rebased instead of being dropped entirely.

So if you don't mind, I would prefer to look into this after
audacious-plugins/2.0.1-2 hits sid later today.

Benjamin Drung (bdrung)
Changed in audacious (Ubuntu):
importance: Undecided → Wishlist
description: updated
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Hi dupondje,

Please address the above comment. You also should take a look at the following wiki page, and familiarize yourself with the standard format for merges:

https://wiki.ubuntu.com/UbuntuDevelopment/Merging

grab-merge (which is included as part of the ubuntu-dev-tools package) can help you out with some of this.

Un-subscribing universe sponsors. Please re-subscribe when the merge is ready.

Thanks!

Benjamin Drung (bdrung)
Changed in audacious (Ubuntu):
assignee: nobody → Benjamin Drung (bdrung)
Revision history for this message
Jean-Louis Dupond (dupondje) wrote :

Benjamin,

A small hint, there is a small fixed version available on mentors.debian.org :)

Revision history for this message
Benjamin Drung (bdrung) wrote :

I cannot find it on mentors.debian.net.

Revision history for this message
Jean-Louis Dupond (dupondje) wrote :

Its indeed gone it seems :(

Revision history for this message
Benjamin Drung (bdrung) wrote :

audacious (2.0.1-1ubuntu1) karmic; urgency=low

  * Merge from Debian unstable (LP: 383271), remaining changes:
    + debian/patches/004-change-default-outputplugin.patch:
      Set pulseaudio as output plugin in the default config structure.
    + debian/control
      + audacious package recommends python-chardet.
      + conflict with audacious-crossfade from hardy to prevent segfaults.
  * Dropped Ubuntu changes:
    - debian/patches/005-playlist_play_clicked_file.patch: Not needed anymore.
    - debian/patches/Update-Spanish-translation.patch: Applied upstream.
  * Drop debian/patches/003-change-default-skin.patch, do not change the
    default theme. Keep close to upstream.

 -- Benjamin Drung <email address hidden> Sun, 07 Jun 2009 18:31:01 +0200

Changed in audacious (Ubuntu):
assignee: Benjamin Drung (bdrung) → nobody
Revision history for this message
Benjamin Drung (bdrung) wrote :

I forgot a sharp in the changelog. Here is the updated one.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package audacious - 2.0.1-1ubuntu1

---------------
audacious (2.0.1-1ubuntu1) karmic; urgency=low

  * Merge from Debian unstable (LP: #383271), remaining changes:
    + debian/patches/004-change-default-outputplugin.patch:
      Set pulseaudio as output plugin in the default config structure.
    + debian/control
      + audacious package recommends python-chardet.
      + conflict with audacious-crossfade from hardy to prevent segfaults.
  * Dropped Ubuntu changes:
    - debian/patches/005-playlist_play_clicked_file.patch: Not needed anymore.
    - debian/patches/Update-Spanish-translation.patch: Applied upstream.
  * Drop debian/patches/003-change-default-skin.patch, do not change the
    default theme. Keep close to upstream.

 -- Benjamin Drung <email address hidden> Sun, 07 Jun 2009 18:31:01 +0200

Changed in audacious (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
DYPA (dypa) wrote :

can you backport to the jaunty (9.04) ?

Revision history for this message
Benjamin Drung (bdrung) wrote :

You can find the package in my backports PPA: https://launchpad.net/~bdrung/+archive/backports

Revision history for this message
Zane (zanetu) wrote :

Hi Benjamin,
It seems audacious-plugins is not present in your backports PPA. Would you please add it? Thanks.

Revision history for this message
Benjamin Drung (bdrung) wrote :

Ok, I have uploaded audacious-plugins to my PPA: https://launchpad.net/~bdrung/+archive/ppa
When audacious-plugins hits karmic (9.10), then you will find it in my backports PPA as well.

Revision history for this message
William Pitcock (nenolod) wrote :

So, uh...

you guys do realize that audacious isn't installable because you guys didn't sync the plugins, right?

i mean, i hope you guys know this, right??

...bleah.

Revision history for this message
William Pitcock (nenolod) wrote :

...oh, it finally hit. nevermind.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.