Ok/Cancel buttons

I'd prefer to wait for tango upstream for icons covered by the theme. BTW those icons are good for me.

doby is blocking this... basicly, he seems to have a problem with those icons for slightly diffentent things. But really, isn't it better to put this into dapper and not having the old stock icons displayed instead of waiting for tango?

Probably the metaphor is going to change so I think is better to wait for the tango ones, which is your opinion Andreas?

jimmac suggested these metaphors for the different actions:
http://jimmac.musichall.cz/screenshots/screenshot-228701000.jpg

I think it is ok to put them in tangerine for now, and then removing them when they get into tango.

Ok Andreas, if you think so it's fine for me, go on and include them.

added the icons, but not the symlinks. Need to ask the maintainer of icon-naming-utils to fix those.

It'd be nice, if you could point out, what has to be changed exactly in icon-naming-utils. I suppose we could fix bug 43580 with this as well, right?

These ara my Liferea icons. The icon marked as red is a bit ugly. I thinks this is not using Human icons.

"Cancel" icon is very like "back" icon. And "Ok" icon is not using the appropiate icon for this theme.

I see this bug as fixed, but I have the same icons :/ Previous screenchoots are self-explicatives.

It is fixed in tangerine, but in progress in icon-naming-utils

So, Human icons will be fixed?

The problem affects the utility which make symlinks from the tango icons using the tango namespaces to a gtk icon using the old gtk namespaces which is used by the old applications.

It is in pogress, so I suppose it will be fixed.

This patch modifies legacy-icon-mapping.xml in icon-naming-utils.

I built icon-naming-utils with it and then rebuilt tango-icon-theme-common, that fixed the problem for me.

I have tested the fixed tango-icon-theme-common with many programs and everything seems to work very well – except for the close buttons in tabs.

That seems more like a Gtk problem than an icon theme problem. I attached a screenshot, and a mockup of a proposed solution (that would need absolutely no changes to icon themes).

Comments?

See above.

I added the following to my ~/.gtkrc-2.0. The close buttons in tabs, notifications etc. look fine now (just like in the mockup). Unfortunately this affects every other button as well.

style "my-button"
{
 GtkWidget::focus-padding = 0
 xthickness = 0
 ythickness = 0
}

class "GtkButton" style "my-button"

I hope someone discovers a solution that *only* affects the buttons that contain a single image and are supposed to be smaller than normal widgets.

For comparison, here are some screenshots with and without the patch and/or the gtkrc modification.

http://johan.kiviniemi.name/pictures/icons/

 icon-naming-utils (0.8.1-0ubuntu2) edgy; urgency=low
 .
   * debian/patches/03_gtk_apply_close_ok.patch:
     - apply patch from LP bug 40607.

Upstream bug: https://bugs.freedesktop.org/show_bug.cgi?id=8057

I uploaded a tango-icon-theme and tango-icon-theme-common package to be rebuilt with the changed icon-naming-utils.

Daniel,

This was recently reverted.... can you please explain why?

tango-icon-theme-common (0.5-0ubuntu1) edgy; urgency=low

  * New upstream release:
    - drop dialog-*.

 -- Daniel Holbach <email address hidden> Mon, 11 Sep 2006 19:14:43 +0200

Eric, please look here: https://launchpad.net/distros/ubuntu/+source/tango-icon-theme-common/+bug/60424