Ubuntu
xulrunner-1.9.1 package

[MASTER] Firefox 3.5 prompting to restart without installing new addons

Bug #441552 reported by Martin Josefsson
74
This bug affects 16 people
Affects Status Importance Assigned to Milestone
Mozilla Firefox
Fix Released
Medium
Mozilla Firefox 3.5.7
xulrunner-1.9.1 (Ubuntu)
Fix Released
High
Alexander Sack
Ubuntu ubuntu-9.10

Bug Description

DEBUG INSTRUCTIONS:
1. Back up profile <---IMPORTANT for testing
2. Go to about:config
3. setting extensions.logging.enabled to true
4. Paste what comes out on console on startup

Binary package hint: firefox-3.5

Problems in Firefox 3.5.3 (in Ubuntu 9:10 beta) to install new add-on's. There don't seems to be finally installed?!

ProblemType: Bug
Architecture: i386
Date: Sat Oct 3 19:27:47 2009
DistroRelease: Ubuntu 9.10
NonfreeKernelModules: nvidia
Package: firefox 3.5.3+build1+nobinonly-0ubuntu3
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-11.38-generic
SourcePackage: firefox-3.5
Uname: Linux 2.6.31-11-generic i686

See original description
Revision history for this message
Martin Josefsson (martinjosef) wrote :
Revision history for this message
Ignacio Larrain (ilarrain) wrote :

I'm experiencing the same problem on amd64, using Ubuntu Karmic Beta, updated with the latests packages.

More info here: http://ubuntuforums.org/showthread.php?p=8003722#post8003722

Ignacio Larrain (ilarrain)
Changed in firefox-3.5 (Ubuntu):
status: New → Confirmed
Micah Gersten (micahg)
summary: - Problems with new add-on's in Firefox 3.5.3.
+ Firefox 3.5 prompting to restart without installing new addons
Revision history for this message
Ignacio Larrain (ilarrain) wrote : Re: Firefox 3.5 prompting to restart without installing new addons

Deleting the extensions.cache file in the profile folder solved the issue for me.

Revision history for this message
Angel Guzman Maeso (shakaran) wrote :

The Ignacio's workaround works for me.
$ mv ~/.mozilla/firefox/your-profile.default/extensions.cache ~/.mozilla/firefox/your-profile.default/extensions.cache.backup

Revision history for this message
Miguel Martinez (el-quark) wrote :

I'd like to add that, after the latest xulrunner updates, no addons were available for me (langpacks, adbock plus, download manager) until I renamed the extensions.cache.

Revision history for this message
In , Alexander Sack (asac) wrote :

We moved our system langpacks from one location to another - previously not used one - for karmic; this seemed to have cause extension manager to go into a bad state (at least for me).

The symptoms are that during the upgrade, the uninstallItem function fails here:

http://hg.mozilla.org/mozilla-central/file/dbebe1771118/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#l4591

with an exception like:

[Exception... "Could not convert JavaScript argument arg 1 [nsIRDFDataSource.GetTarget]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: file:///usr/lib/xulrunner-1.9.1.5pre/components/nsExtensionManager.js :: EMDS__setProperty :: line 7250" data: no]

... which breaks the whole extension update somewhat.

I looked a bit around thinking that maybe the UPGRADE op is wrong, but i think thats not the problem. It seems that the _setProperty code her:

http://hg.mozilla.org/mozilla-central/file/dbebe1771118/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#l6939

is supposed to deal with this situation as it explicitly tests "if (oldValue)" ... however, GetTarget does not return null but throws and exception, so a potential fix would be to just catch it there.

Revision history for this message
In , Alexander Sack (asac) wrote :

Created an attachment (id=405845)
catch GetTarget exception

Revision history for this message
In , Mh+mozilla (mh+mozilla) wrote :

You don't assign oldValue, this ain't gonna work ;)

Revision history for this message
In , Alexander Sack (asac) wrote :

Created an attachment (id=405846)
oops

Revision history for this message
In , Dtownsend (dtownsend) wrote :

(From update of attachment 405846)
GetTarget only throws when it is passed invalid arguments. We should fix the caller to not do that instead.

Revision history for this message
In , Alexander Sack (asac) wrote :

(In reply to comment #4)
> (From update of attachment 405846 [details])
> GetTarget only throws when it is passed invalid arguments. We should fix the
> caller to not do that instead.

invalid in what way? I always thought that GetTarget also throws if "source" resource does not exist for example.

Revision history for this message
In , Dtownsend (dtownsend) wrote :

GetTarget only throws if source or property are null, however the error message you're getting isn't from GetTarget throwing, it is xpconnect throwing because source or property are not null or JS objects that it can pretend are nsIRDFResources.

Revision history for this message
In , Mozilla-bugs-micahscomputing (mozilla-bugs-micahscomputing) wrote :

Ubuntu bug:
https://bugs.launchpad.net/bugs/441552

Revision history for this message
Alexander Sack (asac) wrote : Re: Firefox 3.5 prompting to restart without installing new addons

please keep the broken profile backed-up so we can reproduce for verification later. thanks!

Revision history for this message
Micah Gersten (micahg) wrote :

Thank you for your bug report. This bug has been reported to the developers of the software. You can track it and make comments at:
https://bugzilla.mozilla.org/show_bug.cgi?id=521780

Changed in firefox-3.5 (Ubuntu):
assignee: nobody → Alexander Sack (asac)
importance: Undecided → High
status: Confirmed → Triaged
summary: - Firefox 3.5 prompting to restart without installing new addons
+ [MASTER] Firefox 3.5 prompting to restart without installing new addons
tags: added: metabug
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Unknown → Confirmed
Revision history for this message
LGB [Gábor Lénárt] (lgb) wrote :

I have this problem too (as I have reported it as bug 438575 ... but it seems to be a duplication of this one) on karmic running on x86 32 bit, I have three machines having this problem, so not only a single case. Firefox always report that I should restart it, but then it reports that again. Also sometimes (after firefox and/or xulrunner upgrade with apt-get maybe?) my already working extensions disappearing and the only solution to get them back is disable all extensions, cancel upgrades, restart then enable all of them, then restart firefox again ... Sure, I have no extension upgrade since a while now, since it does not work.

firefox-3.5:
  Installed: 3.5.3+build1+nobinonly-0ubuntu4
  Candidate: 3.5.3+build1+nobinonly-0ubuntu4
  Version table:
 *** 3.5.3+build1+nobinonly-0ubuntu4 0
        500 http://archive.ubuntu.com karmic/main Packages
        100 /var/lib/dpkg/status

Revision history for this message
LGB [Gábor Lénárt] (lgb) wrote :

Thanks, it seems removing file extensions.cache solved my long standing "cannot upgrade extension" problem! Though I think it's just a workaround and may not suitable for every users as a solution :)

Revision history for this message
Alexander Sack (asac) wrote : Re: [Bug 441552] Re: [MASTER] Firefox 3.5 prompting to restart without installing new addons

On Thu, Oct 15, 2009 at 09:24:47AM -0000, LGB [Gábor Lénárt] wrote:
> Thanks, it seems removing file extensions.cache solved my long standing
> "cannot upgrade extension" problem! Though I think it's just a
> workaround and may not suitable for every users as a solution :)
>

Dont post that here. now everyone complaining will do that. micah did
put some instructions in summary ... that would have been great to do
... but now you are gone because you cannot reproduce it anymore ...

 - Alexander

Micah Gersten (micahg)
description: updated
Revision history for this message
LGB [Gábor Lénárt] (lgb) wrote :

Sure Alexander, but consider that i also want to use my firefox normally not just waiting and suffering, and though it's a workaround maybe, if fixes the problem for me at least so I am happy. Anyway, I have two other machines with that problem so I can play with them too, if some tests are needed without this workaround at least ... Thanks.

Revision history for this message
Alexander Sack (asac) wrote :

Thanks. very good. i hope i have something to verify in the next days. Also you can backup your .mozilla directory if you see this so we can still play with it without blocking your daily use.

Revision history for this message
LGB [Gábor Lénárt] (lgb) wrote :

I don't know if it helps, but this was the output of the process written at the summary of the bug report. There were some restart action during this "log", when it was asked from me to do (by firefox) but it's an infinte process: I am asked to restart again and again ...

Revision history for this message
In , Alexander Sack (asac) wrote :

Created an attachment (id=407108)
fix type of newVersion property...

ok newVersion was just a string while setItemProperty/setProperty requires a nsIRDFResource ... this patch fixes it by using EM_R("newVersion")

That said I noticed that setItemProperty assumes a nsIRDFResource as "property", while getItemProperty seems to EM_R "property" all the time. Might be worth looking into making the behaviour more consistent.

Alexander Sack (asac)
Changed in firefox-3.5 (Ubuntu):
milestone: none → ubuntu-9.10
Alexander Sack (asac)
Changed in firefox-3.5 (Ubuntu):
status: Triaged → Fix Committed
Steve Langasek (vorlon)
affects: firefox-3.5 (Ubuntu) → xulrunner-1.9.1 (Ubuntu)
Changed in xulrunner-1.9.1 (Ubuntu):
status: Fix Committed → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xulrunner-1.9.1 - 1.9.1.3+build1+nobinonly-0ubuntu6

---------------
xulrunner-1.9.1 (1.9.1.3+build1+nobinonly-0ubuntu6) karmic; urgency=low

  [ Fabien Tassin <email address hidden> ]
  * fix LP: #454166 - target the 'default' branch instead of tip;
    this just affects daily builds from this branch
    - add debian/moz-rev.sh
    - update debian/mozclient/xulrunner-1.9.1.conf

  [ Alexander Sack <email address hidden> ]
  * fix LP: #441552 - [MASTER] Firefox 3.5 prompting to restart without
    installing new addons; basically on upgrade if firefox does not find
    an reference to a previously known extension location in the new created
    extension rdf, the extension manager will fail leading to a bad startup
    sequence, basically leaving users in a instable state as no extension
    upgrades etc. will finish/work properly. The fix takes latest upstream
    patch (attach 407108) from https://bugzilla.mozilla.org/show_bug.cgi?id=521780
    - add debian/patches/lp441552_bz521780_att407108.patch
    - update debian/patches/series

 -- Alexander Sack <email address hidden> Tue, 20 Oct 2009 12:08:40 +0200

Changed in xulrunner-1.9.1 (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
In , Reed Loden (reed) wrote :

http://hg.mozilla.org/mozilla-central/rev/a1749e78c2be

Revision history for this message
In , Reed Loden (reed) wrote :

(From update of attachment 407108)
Ubuntu is already using this patch on their 1.9.1 branch, so would like to get this backported.

Micah Gersten (micahg)
tags: added: fixed-3.7
tags: added: fixed-1.9.3
removed: fixed-3.7
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
status: Confirmed → Fix Released
Revision history for this message
In , Beltzner (beltzner) wrote :

(From update of attachment 407108)
a192=beltzner

Revision history for this message
In , Mak77 (mak77) wrote :

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/760b6fefebcc

Revision history for this message
In , Dveditz (dveditz) wrote :

Comment on attachment 407108
fix type of newVersion property...

Approved for 1.9.1.7 and 1.9.0.17, a=dveditz for release-drivers

Revision history for this message
In , Reed Loden (reed) wrote :

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7b12d53eed85

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in
new revision: 1.290; previous revision: 1.289
done

Micah Gersten (micahg)
Changed in firefox:
milestone: none → 3.5.7
Bug Watch Updater (bug-watch-updater)
Changed in firefox:
importance: Unknown → Medium
Revision history for this message
In , Hskupin (hskupin) wrote :

The nsExtensionManager.js.in module is gone on trunk. Just marking it as verified fixed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.