Odoo Addons (MOVED TO GITHUB)

Sale order line in state 'done' but order in state 'draft'

Bug #461801 reported by Quentin THEURET @Amaris
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Undecided
gpa(OpenERP)

Bug Description

Hi,

I create new sale order with one product. I confirm it. To cancel it, I remove the product on outgoing product view, the state of my sale order is 'Cancel'. I drafted it. But the problem when I add a product on this draft sale order and I save it : the sale order state become 'done'.

I recapitulate :

-Create a new sale order with one product :
    state in DB : draft - workflow state : draft

-Confirm sale order :
    state in DB : progress - worflow state : ship

-Cancel the sale order (remove product on outgoing product):
    state in DB : cancel - workflow state : ship

-Draft the sale order :
    state in DB : draft - workflow state : draft

-Add a second product and save it :
    state in DB : done - worflow state : draft

Related branches

lp:openobject-addons/5.0
lp:~numerigraphe/openobject-addons/5.0-unittest
OpenERP Core Team: Pending requested
Diff: 69 lines (+54/-0)
2 files modified
account/__terp__.py (+1/-0)
account/test/sequence_bug602188_test.xml (+53/-0)
Jay Vora (Serpent Consulting Services) (jayvora)
affects: openobject-server → openobject-addons
Changed in openobject-addons:
status: New → Confirmed
assignee: nobody → gpa(Open ERP) (gpa-openerp)
gpa(OpenERP) (gpa-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Quentin Theuret,

Thank you for such an important bug-report.

We appreciate your contribution.

Would you please apply this patch and let us know whether it works at your end ?

Thank you.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :
Revision history for this message
Jan Verlaan (jan-verlaan) wrote :

Hi Jay,

can you link this bugtracker to https://bugs.launchpad.net/openobject-addons/+bug/399817 as this solves part of that problem too. Perhaps you have seen while fixing this bug what the solution could be for "Still partiall delivery cancellation problem exist. We have to find some way out for that."
See comment 24 from hda.

Thanks

Revision history for this message
Quentin THEURET @Amaris (qtheuret) wrote : Re: [Bug 461801] Re: Sale order invoiced but state is 'draft'

Quentin THEURET

163, Route d'Oberhausbergen
67200 STRASBOURG - FRANCE

@ : <email address hidden>
Tel : +33 (0)6 33 23 20 84

Visit my website : http://www.quentin-theuret.net

Hello Jay,

Thank you for your patch.

I applied the patch and the problem seem to be solved.

Thank you.

--
Quentin THEURET

TeMPO CONSULTING
9, Rue du Parc
67200 OBERHAUSBERGEN
FRANCE
<email address hidden>

Jay (Open ERP) a écrit :
> Hello Quentin Theuret,
>
> Thank you for such an important bug-report.
>
> We appreciate your contribution.
>
> Would you please apply this patch and let us know whether it works at
> your end ?
>
> Thank you.
>
>

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote : Re: Sale order invoiced but state is 'draft'

Hello ,
 It has been fixed with revision 2455 <email address hidden>.

@Jan:

I will check that problem and will have a solution for the same.

Thank you for pointing that out.

Changed in openobject-addons:
status: In Progress → Fix Released
Numérigraphe (numerigraphe)
summary: - Sale order invoiced but state is 'draft'
+ Sale order line in state 'done' but order in state 'draft'
Revision history for this message
Numérigraphe (numerigraphe) wrote :

A unit test scenario for this bug is available at http://bazaar.launchpad.net/~numerigraphe/openobject-addons/unittest-5.0/revision/2427
Lionel

Revision history for this message
Numérigraphe (numerigraphe) wrote :

All subscribers, attention please, we've had a regression regarding this bug in 5.0 for some time - I don't really know when it occured.
It is has just been fixed again by Jay as he fixed bug #401801.
Lionel.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.