faad2 doesn't hand long filenames or pathnames

Bug #475050 reported by Bijan Soleymani
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
faad2 (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

If the filename or pathname is greater than about 187 characters/bytes then faad2 has a buffer overflow. This is caused by faad copying the filenames/pathnames into a static buffer, which is too small.

This is definitely a bug as ext2 supports filenames of 255 characters and the limit for pathnames is four kilobytes or even more...

If you want to reproduce this then do something like:
faad aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.mp4

and faad should die. If it doesn't then just put it a few directories deep and that should do it. This is a real problem. As a workaround I modified faad to read from standard input and did:
faad < long_pathname

instead.

Thanks in advance,
Bijan

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package faad2 - 2.7-5

---------------
faad2 (2.7-5) unstable; urgency=low

  * Update my e-mail address.
  * Apply SqueezeCenter patches from FreeBSD that enable streaming with
    BBCiPlayer and ezstream (LP: #470562).
  * Extend file name buffers for longer path names (LP: #475050).
 -- Ubuntu Archive Auto-Sync <email address hidden> Mon, 22 Nov 2010 10:15:21 +0000

Changed in faad2 (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.