Odoo Addons (MOVED TO GITHUB)

can't delete picking with web-client: regression suspected

Bug #499120 reported by Raphaël Valyi - http://www.akretion.com on 2009-12-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	High	Sananaz (Open ERP)	Odoo Addons (MOVED TO GITHUB) 5.0.7

Bug Description

Hello, using latest web-client 5.0 rev #2773, with fresh mrp profile + demo data database, I can't delete a confirmed picking (in out-going product, make sure to select a picking in 'confirmed' state in the list view; in the form view there is not button suppress in the web-client which might be an other bug) if I use the web-client while it works with the GTK client.

With the web-client, instead of deleting the record I'm getting this error:
"Records were modified in the meanwhile" which is a wrong concurrency detection by the server.

Activating the server log, I can see that the web-client passes (wrong?) last-update times to the request while the GTK client doesn't pass it.

Here is server the log with the web-client call:

[2009-12-21 14:56:48,422] DEBUG_RPC:service:'object'
[2009-12-21 14:56:48,422] DEBUG_RPC:method:'execute'
[2009-12-21 14:56:48,427] DEBUG_RPC:params:[01]: ('adaptoo_local',
[2009-12-21 14:56:48,427] DEBUG_RPC:params:[02]: 1,
[2009-12-21 14:56:48,427] DEBUG_RPC:params:[03]: 'admin',
[2009-12-21 14:56:48,427] DEBUG_RPC:params:[04]: 'stock.picking',
[2009-12-21 14:56:48,427] DEBUG_RPC:params:[05]: 'unlink',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[06]: [24],
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[07]: {'__last_update': {'stock.picking,1': '2009-12-03 15:07:55.772558',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[08]: 'stock.picking,16': '2009-12-03 15:45:26.56874',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[09]: 'stock.picking,17': '2009-12-03 15:55:39.296723',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[10]: 'stock.picking,18': '2009-12-03 15:56:58.863737',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[11]: 'stock.picking,19': '2009-12-21 12:51:05.400076',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[12]: 'stock.picking,20': '2009-12-21 12:52:24.195488',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[13]: 'stock.picking,21': '2009-12-21 12:52:26.910934',
[2009-12-21 14:56:48,428] DEBUG_RPC:params:[14]: 'stock.picking,22': '2009-12-21 12:52:29.583463',
[2009-12-21 14:56:48,429] DEBUG_RPC:params:[15]: 'stock.picking,23': '2009-12-21 12:52:33.200631',
[2009-12-21 14:56:48,429] DEBUG_RPC:params:[16]: 'stock.picking,24': '2009-12-21 12:52:36.954367',
[2009-12-21 14:56:48,429] DEBUG_RPC:params:[17]: 'stock.picking,25': '2009-12-21 12:52:39.494891',
[2009-12-21 14:56:48,429] DEBUG_RPC:params:[18]: 'stock.picking,26': '2009-12-21 14:51:10.608793',
[2009-12-21 14:56:48,429] DEBUG_RPC:params:[19]: 'stock.picking,3': '2009-12-03 15:07:56.207265',
[2009-12-21 14:56:48,429] DEBUG_RPC:params:[20]: 'stock.picking,5': '2009-12-03 15:07:56.526662'}})

While here is the successful unlink call using the GTK client (lest revision too):

[2009-12-21 14:58:43,380] DEBUG_RPC:service:'object'
[2009-12-21 14:58:43,380] DEBUG_RPC:method:'execute'
[2009-12-21 14:58:43,381] DEBUG_RPC:params:[01]: ('adaptoo_local',
[2009-12-21 14:58:43,381] DEBUG_RPC:params:[02]: 1,
[2009-12-21 14:58:43,381] DEBUG_RPC:params:[03]: 'admin',
[2009-12-21 14:58:43,381] DEBUG_RPC:params:[04]: 'stock.picking',
[2009-12-21 14:58:43,381] DEBUG_RPC:params:[05]: 'unlink',
[2009-12-21 14:58:43,382] DEBUG_RPC:params:[06]: [24],
[2009-12-21 14:58:43,382] DEBUG_RPC:params:[07]: {'active_id': 255,
[2009-12-21 14:58:43,382] DEBUG_RPC:params:[08]: 'active_ids': [255],
[2009-12-21 14:58:43,382] DEBUG_RPC:params:[09]: 'contact_display': 'partner',
[2009-12-21 14:58:43,382] DEBUG_RPC:params:[10]: 'lang': 'en_US',
[2009-12-21 14:58:43,382] DEBUG_RPC:params:[11]: 'tz': False})

it sounds like an important regression (so fix for 5.0.7 is expected I think).
Hope this helps

Related branches

lp:openobject-addons/5.0

Raphaël Valyi - http://www.akretion.com (rvalyi) on 2009-12-21

Changed in openobject-client-web:
importance:	Undecided → High
milestone:	none → 5.0.7

Amit Mendapara (cristatus) on 2009-12-22

Changed in openobject-client-web:
assignee:	nobody → sma (Tiny) (sma-tiny)

Revision history for this message

Sananaz (Open ERP) (sma-tiny) wrote on 2009-12-28:

Hello Raphael,

You get the error message '"Records were modified in the meanwhile' when delete a confirmed picking (in out-going product picking in 'confirmed' state in the list view) this is cause of overwrite unlink method which call write method.

Thanks.

Changed in openobject-client-web:
status:	New → Invalid

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-12-28:

Hello SMA, so you actually suggest it's an addons/stock/stock.py bug?
If yes, then why did you not re-qualify the bug to openobject-addons?

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2009-12-28:

One more question: the fact that the GTK client doesn't throw an exception should be declared as a bug of the GTK client then? So please are you sure about what you say?

Revision history for this message

Sananaz (Open ERP) (sma-tiny) wrote on 2009-12-29:

Hello Raphael,

1. Yes its problem from server side where overwrite unlink method of 'stock_picking' class, which call another class 'stock_move' action_cancel method, and then this also call a write method, so the query of orm method `_check_concurrency` goes wrong then it gives "Records were modified in the meanwhile".

2. Another thing for GTK client, it cant send the last_update date and time when call unlink method. So it cant goes for orm `_check_concurrency` method. So from gtk you get the desired result.

From your side, i will send this bug for openobject-addons.

Thank you.

Changed in openobject-client-web:
status:	Invalid → New
affects:	openobject-client-web → openobject-addons
Changed in openobject-addons:
milestone:	5.0.7 → none