euca_conf --[de]register-nodes is brittle

Bug #522204 reported by Thierry Carrez
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Eucalyptus
Fix Released
Undecided
Mitch Garnaat
eucalyptus (Ubuntu)
Fix Released
Medium
Dustin Kirkland 
Lucid
Fix Released
Medium
Dustin Kirkland 

Bug Description

Reviewing euca_conf code, the following bit (from euca_conf --register-nodes) seems to leave some room for failure:
if ! echo "${NODES}"|grep "${NEWNODE}"
Imagine if NODES="192.168.144.10 192.168.144.11" and you want to add 192.168.144.1...

Also the following bit called from euca_conf --deregister-nodes:
NODES="`echo $NODES|sed \"s/${NEWNODE}//\"|tr -s ' '`"
Imagine if NODES="192.168.144.10 192.168.144.1" and you want to remove 192.168.144.1...

Thierry Carrez (ttx)
description: updated
Thierry Carrez (ttx)
Changed in eucalyptus (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
Thierry Carrez (ttx)
Changed in eucalyptus (Ubuntu Lucid):
status: Confirmed → Triaged
Thierry Carrez (ttx)
Changed in eucalyptus (Ubuntu Lucid):
milestone: none → ubuntu-10.04-beta-2
Thierry Carrez (ttx)
Changed in eucalyptus (Ubuntu Lucid):
assignee: nobody → Dustin Kirkland (kirkland)
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Upstream-

Please consider cherry picking bzr r999 from lp:~ubuntu-core-dev/eucalyptus/ubuntu.

Changed in eucalyptus (Ubuntu Lucid):
status: Triaged → In Progress
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package eucalyptus - 1.6.2-0ubuntu22

---------------
eucalyptus (1.6.2-0ubuntu22) lucid; urgency=low

  * utils/wrappers.conf: add populate_arp.pl to the whitelist; this
    utility ensures that the arp tables are up to date, LP: #461829
  * tools/euca_conf.in: make node registration/deregistration more
    robust, LP: #522204
  * tools/euca_conf.in: exit non-zero if any of the node registrations
    fail, LP: #531195
 -- Dustin Kirkland <email address hidden> Tue, 23 Mar 2010 19:32:58 -0700

Changed in eucalyptus (Ubuntu Lucid):
status: Fix Committed → Fix Released
Changed in eucalyptus:
assignee: nobody → Mitch Garnaat (mitch-garnaat)
Changed in eucalyptus:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.