Odoo Addons (MOVED TO GITHUB)

User can cancel a partially paid invoice

Bug #524521 reported by Vincent Renaville@camptocamp on 2010-02-19

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	High	Vinay Rana (OpenERP)	Odoo Addons (MOVED TO GITHUB) 5.0.8

Bug Description

Hello,

It's dangerous to let the user cancel an invoice with partial paiment without doing manual un-reconcile.
The process need to be the same as for completely paid invoice, you need to cancel reconciliation
before you can cancel the invoice.

Thanks for you help

Related branches

lp:openobject-addons/5.0

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) on 2010-02-22

Changed in openobject-addons:
status:	New → Confirmed
milestone:	none → 5.0.8
importance:	Undecided → High

Revision history for this message

Vinay Rana (OpenERP) (vra-openerp) wrote on 2010-02-26:

bug-524521-partial-reconcile-problem Edit (3.7 KiB, text/plain)

Hello Joel,

Can you apply the attached patch and notify me?

Thanks.

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2010-02-26:

Hi vra,

According to my test case in OERPScenario everything is alright with your patch !

Thanks for the work,

Regards,

Joël

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2010-03-04:

Thank you for the feedback Joël.

We will enhance this facility and fix it soon.

Changed in openobject-addons:
assignee:	nobody → vra (openerp) (vra-openerp)

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2010-03-04:

As discussed by mail, the wizard "unreconcile entries" should be able to unreconcile partial and full reconciliation.

This way, you have the same functionality between partial and full rec. allowing people to work the same way.

Regards,

Joël

Revision history for this message

Jan Verlaan (jan-verlaan) wrote on 2010-03-04:

See https://lists.launchpad.net/openerp-expert-accounting

Hi Jay,

in my opinion one should not create new accounting entries just to balance the financial figures for the debtor or creditor account.
One should use the functionality of unlinking the (partial) reconciliation instead, like vra proposed in the provided patch.

That way the transactions keep clean and one does exactly what needs to be done, un-reconciling before changing the status of the corresponding invoice or payment.
Otherwise one will run into troubles later on as the transaction is still in status (partial)reconciled and ugly fixing functionality is needed to overcome the problems that will raise later on due to adding reverse entries.

I will vote for the patch, not for reverse entries.

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2010-03-04:

Hello Jan and Joël,

Your feedbacks have helped and encouranged us a lot!
It has been fixed by revision 2631 <email address hidden>.

Thank you.