ibus languagebar doesn't show MenuItem on menu.

Bug #533636 reported by Ikuya Awashiro
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ibus (Fedora)
Fix Released
Medium
ibus (Ubuntu)
Fix Released
High
Unassigned
Lucid
Fix Released
High
Unassigned

Bug Description

Binary package hint: ibus

Newest ibus-anthy doesn't show some icons.
This is as same as https://bugzilla.redhat.com/show_bug.cgi?id=552796.

Please apply the patch.

Related branches

Revision history for this message
In , fujiwara (fujiwara-redhat-bugs) wrote :

I'd like to add MenuItem on ibus languagebar with bug 550001.

Currently ibus supports CheckMenuItem() and RadioMenuItem() but it seems ImageMenuItem() doesn't work.

When I apply the patch on bug 550001, ibus puts an error:
ibus.Menu receives type == ibus.PROP_TYPE_NORMAL and call gtk.ImageMenuItem(prop)
but the argument is not correct.
I'm attaching the patch.

Revision history for this message
In , fujiwara (fujiwara-redhat-bugs) wrote :

Created attachment 381928
Patch for ibus menu.py

Attached the patch.
It seems to get an error when gtk.ImageMenuItem.__init__() is called so I removed it.

Revision history for this message
In , fujiwara (fujiwara-redhat-bugs) wrote :

Comment on attachment 381928
Patch for ibus menu.py

>diff --git a/ui/gtk/menu.py b/ui/gtk/menu.py

One typo. Both icon and label can be shown:

              self.set_image(icon.IconWidget(prop.icon, size[0]))
-+ elif self._prop.label:
++ if self._prop.label:
 + self.set_property("label", prop.label.get_text())

Revision history for this message
In , fujiwara (fujiwara-redhat-bugs) wrote :
Revision history for this message
In , fujiwara (fujiwara-redhat-bugs) wrote :

F11 pygtk2 had a problem:
http://git.gnome.org/browse/pygtk/commit/?id=fbb3e653ab1c4f467d7aae61e8444fab8c839af1
--- a/gtk/gtk.override
+++ b/gtk/gtk.override
@@ -2064,24 +2066,20 @@ _wrap_gtk_image_menu_item_new(PyGObject *self, PyObject *args,PyObject *kwargs)
-
- if (pyg_type_from_object((PyObject *) self) != GTK_TYPE_IMAGE_MENU_ITEM) {
- PyErr_SetString(PyExc_RuntimeError, "__gobject_init__ must be used "
- "when subclassing gtk.ImageMenuItem");
- return -1;
- }
-
- pygobject_register_wrapper((PyObject *)self);

The previous pygtk sent the error: "__gobject_init__ must be used when subclassing gtk.ImageMenuItem".

But I confirmed f12 _gtk.so is fixed so this part is not needed now.
I logged this issue for the reference.

Revision history for this message
In , Peng (peng-redhat-bugs) wrote :

Fixed in upstream. I will build it soon.

Revision history for this message
In , Peng (peng-redhat-bugs) wrote :

Fixed in ibus-1.2.0.20100111-1.fc13

description: updated
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Here is the debdiff.
Please take a look.

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

screenshot: default (correct)

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

default toolbar (correct)

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

incorrect toolbar

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

expect toolbar

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Anyone can help?

Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Hi Arne, Please take a look.

Changed in ibus (Ubuntu):
assignee: nobody → Arne Goetje (arnegoetje)
Revision history for this message
Arne Goetje (arnegoetje) wrote :

According to https://bugzilla.redhat.com/show_bug.cgi?id=552796#c5 , this has been fixed upstream.

Does the latest version of ibus in Ubuntu still have this issue?

Changed in ibus (Ubuntu):
assignee: Arne Goetje (arnegoetje) → nobody
status: New → Incomplete
importance: Undecided → Low
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Thank you for your reply.
Lucid's ibus is not the newest version (1.2.0.20091215).
http://packages.ubuntu.com/lucid/ibus
The newest upstream is 1.2.0.20100111.
http://code.google.com/p/ibus/downloads/list

Revision history for this message
Arne Goetje (arnegoetje) wrote :

Thanks for the info.

@LI Daobing:
Do you think you could package the new version and upload it into Debian?

@Ikuya Awashiro:
How important is this issue? Does it make ibus-anthy unusable or is it rather cosmetic?

Changed in ibus (Ubuntu):
status: Incomplete → Triaged
assignee: nobody → LI Daobing (lidaobing)
Revision history for this message
Ikuya Awashiro (ikuya-fruitsbasket) wrote :

Most ibus-anthy users use with kasumi which is dictionary management tool for Anthy.
So, this is serious problem.

Arne Goetje (arnegoetje)
Changed in ibus (Ubuntu):
importance: Low → High
Revision history for this message
Benjamin Drung (bdrung) wrote :

Thanks. Fixed a typo in the changelog. Uploading now. Please forward the patch to Debian.

Changed in ibus (Ubuntu Lucid):
assignee: LI Daobing (lidaobing) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ibus - 1.2.0.20091215-1ubuntu4

---------------
ibus (1.2.0.20091215-1ubuntu4) lucid; urgency=low

  * 06_show_menuitem.dpatch: show languagebar correctry (LP: #533636)
 -- Ikuya Awashiro <email address hidden> Sat, 27 Mar 2010 18:57:12 +0100

Changed in ibus (Ubuntu Lucid):
status: Triaged → Fix Released
Changed in ibus (Fedora):
importance: Unknown → Medium
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.