Sync folder does not remove messages from db
Bug #533933 reported by
Bernd Hirschler
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Tomdroid |
Fix Released
|
Low
|
Unassigned |
Bug Description
1. If you import messages they are correctly inserted into the internal db.
2. Remove messages from the /tomdroid folder.
3. Re-sync and the messages are still in the internal db.
-> A sync should lead to a re-construction of the internal db and reflect the currently in the tomroid folder available messages.
Additional if there is an error on import it should tell you which file lead to the problem.
Related branches
lp:~tomdroid-dev/tomdroid/sdsync-remove-notes
- Olivier Bilodeau: Approve
-
Diff: 39 lines (+11/-0)2 files modifiedNEWS (+1/-0)
src/org/tomdroid/sync/sd/SdCardSyncService.java (+10/-0)
Changed in tomdroid: | |
milestone: | none → 0.5.1 |
Changed in tomdroid: | |
assignee: | Olivier Bilodeau (plaxx) → Stefan Hammer (j-4) |
status: | Confirmed → In Progress |
Changed in tomdroid: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
This is a known issue already tracked in doc/dev/TODO:
"SD card sync:
- Syncing from SD card only adds notes from the SD card and overwrite on identical guid. At some point, we'll have to consider deletions."
> -> A sync should lead to a re-construction of the internal db and reflect the currently in the tomroid folder available messages.
I'm not sure I agree with you here. With editing and online sync, several scenarios are possible and what people expect may differ from user to user (ie should tomdroid/ be the autority, the db, or what's online?)... This will need further discussion and user experience testing. This will probably happen over the mailing list.
If we don't fix this before the next release, I'll rename "Sync" to "Import". That should be clearer about what will happen.
> Additional if there is an error on import it should tell you which file lead to the problem.
Please file another bug to track this issue separately.