HR_Holidays - Declare negative days

Fixed by revision 2669 <email address hidden>.
Kindly have an update and recheck.
Thank you for reporting.

Hi!

I'm just testing this module with 5.0.9 version.
I've got the same problem. Impossible to declare negative holiday.

File "/home/ludo/Programmes/openerp-client-5.0.9/bin/tiny_socket.py", line 81, in myreceive
    raise Myexception(str(res[0]), str(res[1]))
tiny_socket.Myexception: ('warning -- ValidateError\n\nError occurred while validating the field(s) number_of_days: Start date should not be larger than end date!\nNumber of Days should be greater than 1!', 'Traceback (most recent call last):\n File "/home/ludo/Programmes/openerp-server-5.0.9/bin/netsvc.py", line 245, in dispatch\n result = LocalService(service_name)(method, *params)\n File "/home/ludo/Programmes/openerp-server-5.0.9/bin/netsvc.py", line 74, in __call__\n return getattr(self, method)(*params)\n File "/home/ludo/Programmes/openerp-server-5.0.9/bin/service/web_services.py", line 576, in execute\n res = service.execute(db, uid, object, method, *args)\n File "/home/ludo/Programmes/openerp-server-5.0.9/bin/osv/osv.py", line 63, in wrapper\n self.abortResponse(1, inst.name, \'warning\', inst.value)\n File "/home/ludo/Programmes/openerp-server-5.0.9/bin/netsvc.py", line 59, in abortResponse\n raise Exception("%s -- %s\\n\\n%s"%(origin, description, details))\nException: warning -- ValidateError\n\nError occurred while validating the field(s) number_of_days: Start date should not be larger than end date!\nNumber of Days should be greater than 1!\n')

I test another time with the 5.0.12 version.
It is not fixed anymore.

Hello LudoRA,

When you try to save the record the constraint gets called, which wont allow you to have a leave request for negative days.
Example;
From: 2010/08/15 To: 2010/08/20 Days: 5

From: 2010/08/20 To: 2010/08/15 Days: -5

For the latter instance it wont allow you, will always fire the constraint.
Start date should always be greater than the End date.
There usually seems no point to have a negative holiday request.

Let us know if you have further queries regarding the issue.

I hope this helps.

Thank you.

According to the documentation, it's possible to declare negative days. It should be very useful for me.

If this module can't be used like its description, there are 2 possibilities:
1. Change the documentation
2. Develop the module to permit user to declare negatives days

this is a generic product and not for personal use.
you better customise for your use. my customers dont need negative holidays and i prefer to see what openerp currently behaves.

thanks anyways Ludora. this is really not a bug.

OK. I can understand this.
But, I repeat: if it's not a functionnality of this module, it's important to change its description. Because, declare negative day functionnality is precised inside: <quote>- An employee can make a negative holiday request (holiday request of -2 days for example), this is considered by the system as an ask for more off-days. It will increase his total of that holiday status available (if the request is accepted). </quote>

Hello Ludo Chevalier,

Thanks for bringing this into notice.

We have introduced a patch which would allow holiday requests all except following reasons:

1. Start date is greater than End date.
2. Number of Day(s) asked for leave(s) are zero.
3. You are requesting more holidays by putting negative days,but both the dates are not same.

Let me know if we need more clear approach.

Queries/Discussions invited.
Thanks.

Expert commented needed.
Thanks.

Sorry. But, where can I download the version to test of this new plugin???

Hello Ludora,

It's not a plug-in. Just apply the attached patch from response #8.
I hope this helps you.
Thank you.

Is it normal that your patch seems to be the result of the diff command?

Not easy to apply this patch, no?

Hello Ludora,

Yes, the patch is the outcome of the diff command.

If you are unable to apply the patch, you may replace hr.py with the file in the attachment.

I hope this helps you.

Let me know if you have nay further queries.

Thanks.

OK. I've just tested it. It works fine.

Just, it could be very useful if we could specify the right dates.

Thanks for this patch.

Will this patch be integrated to the future version of the plugin?

Hi Ludora,

The patch would be integrated in the latest stable version release.
However, the trunk version already contains better code.

Thank you.

Thanks for the response Ludora,

Fix has been pushed to the stable branch by revision 2873 <email address hidden>.

Thanks a lot for your work Jay.