Use news_merge plugin for launchpad merge preview

Bug #546899 reported by Martin von Gagern
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned
Launchpad itself
Triaged
Low
Unassigned

Bug Description

In https://code.launchpad.net/~gagern/bzr/bug513322-first/+merge/22045 I had requested a merge into bzr.dev involving a modification to the NEWS file. As the launchpad merge display showed a merge conflict, I assumed that the merge would be unsuitable for automatic merging by PQM. Later Robert Collins noted that a properly configured news_merge plugin would take care of such issues, and I assume he wanted to imply that PQM is using that plugin as well.

In that case, it would be great if launchpad could make use of it as well, i.e. if the plugin could be configured in the same way for both the qpm merge and the launchpad merge preview.

I assume that this might be difficult to configure right now, because the plugin is configured using the branch configuration file. Maybe things would be better if the configuration were moved to a versioned file inside .bzrmeta? That way, the same rules would apply to all clones of a branch. I'll therefore mark this as affecting bzr as well as launchpad bzr integration.

Tags: lp-code
Paul Hummer (rockstar)
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Martin von Gagern (gagern) wrote :

John A Meinel indicated that the PQM setup employed by bzr probably doesn't use the plugin either.
So this bug here is affecting bzr in a number of ways:
1. news_merge plugin source code: make it use a versioned configuration file
2. bzr source tree metadata: add a suitable configuration so the bzr NEWS file is handled by the plugin
3. bzr pqm administration: ensure that PQM uses the plugin and its (now hopefully versioned) configuration

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 546899] Re: Use news_merge plugin for launchpad merge preview

On Mon, 2010-03-29 at 05:07 +0000, Martin Pool wrote:
> ** Changed in: bzr
> Importance: Undecided => Low
>
> ** Changed in: bzr
> Status: New => Confirmed

Perhaps this should be on launchpad-code?

Revision history for this message
Aaron Bentley (abentley) wrote :

Robert, if the branch in question is properly configured to use the plugin, and it's not working, then certainly the Code team can look into that. Is this the case?

Revision history for this message
Robert Collins (lifeless) wrote :

On Mon, 2010-03-29 at 15:31 +0000, Aaron Bentley wrote:
> Robert, if the branch in question is properly configured to use the
> plugin, and it's not working, then certainly the Code team can look into
> that. Is this the case?

It's early days yet for the plugin; I'm not sure its configured in
branch.conf for any of the bzr official branches. This would be a good
first step to do - it will help identify issues in the news_merge plugin
configuration too.

-Rob

Revision history for this message
Martin von Gagern (gagern) wrote :

Point 1 of comment #1 seems to be bug #529213, so this one here might depend on that one.

Curtis Hovey (sinzui)
Changed in launchpad:
importance: Wishlist → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.