AttributeError on 'is_ignored' in treewidget filtering when adding in tree with conflicts

Bug #557603 reported by Richard Deglin
38
This bug affects 4 people
Affects Status Importance Assigned to Milestone
QBzr
Status tracked in Trunk
0.21
Fix Released
Medium
Martin Packman
Trunk
Fix Released
Medium
Martin Packman

Bug Description

bzr: ERROR: exceptions.AttributeError: 'NoneType' object has no attribute 'is_ignored'

Traceback (most recent call last):
  File "D:\bzr\bzr-windows-installers\build-win32\release\bzr.2.1.0\bzrlib\plugins\qbzr\lib\treewidget.py", line 1172, in filterAcceptsRow
  File "D:\bzr\bzr-windows-installers\build-win32\release\bzr.2.1.0\bzrlib\plugins\qbzr\lib\treewidget.py", line 1178, in filter_id_cached
  File "D:\bzr\bzr-windows-installers\build-win32\release\bzr.2.1.0\bzrlib\plugins\qbzr\lib\treewidget.py", line 1196, in filter_id
AttributeError: 'NoneType' object has no attribute 'is_ignored'

bzr 2.1.0 on python 2.5.4 (win32)
arguments: ['C:\\Program Files\\Bazaar\\bzr.exe', '--command=add', '--file=C:\\src\\ssd\\source\\Core\\Utilities\\ManagedPoolInline.h', '--file=C:\\src\\ssd\\source\\Core\\Utilities\\ManagedPool.h']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.1.0]
  explorer C:\Program Files\Bazaar\plugins\explorer [1.0.1]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.1.0]
  netrc_credential_store C:\Program Files\Bazaar\plugins\netrc_credential_store [2.1.0]
  news_merge C:\Program Files\Bazaar\plugins\news_merge [2.1.0]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.18.3]
  rebase C:\Program Files\Bazaar\plugins\rebase [0.5.5]
  svn C:\Program Files\Bazaar\plugins\svn [1.0.2]
  upload C:\Program Files\Bazaar\plugins\upload [1.0.0dev]
  xmloutput C:\Program Files\Bazaar\plugins\xmloutput [0.8.6]

Tags: treewidget

Related branches

Revision history for this message
Alexander Belchenko (bialix) wrote :

Can you check QBzr 0.18.5 and see is the bug still present there?

Changed in qbzr:
status: New → Incomplete
Revision history for this message
Richard Deglin (r-deglin) wrote : RE: [Bug 557603] Re: bzr add crashed

I'm not sure what you mean. I'm just a dumb user. :-)

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of
Alexander Belchenko
Sent: Wednesday, April 07, 2010 11:34 PM
To: Richard Deglin - SISA
Subject: [Bug 557603] Re: bzr add crashed

Can you check QBzr 0.18.5 and see is the bug still present there?

** Changed in: qbzr
       Status: New => Incomplete

--
bzr add crashed
https://bugs.launchpad.net/bugs/557603
You received this bug notification because you are a direct subscriber
of the bug.

Status in Qt frontend for Bazaar: Incomplete

Bug description:
bzr: ERROR: exceptions.AttributeError: 'NoneType' object has no
attribute 'is_ignored'

Traceback (most recent call last):
  File
"D:\bzr\bzr-windows-installers\build-win32\release\bzr.2.1.0\bzrlib\plug
ins\qbzr\lib\treewidget.py", line 1172, in filterAcceptsRow
  File
"D:\bzr\bzr-windows-installers\build-win32\release\bzr.2.1.0\bzrlib\plug
ins\qbzr\lib\treewidget.py", line 1178, in filter_id_cached
  File
"D:\bzr\bzr-windows-installers\build-win32\release\bzr.2.1.0\bzrlib\plug
ins\qbzr\lib\treewidget.py", line 1196, in filter_id
AttributeError: 'NoneType' object has no attribute 'is_ignored'

bzr 2.1.0 on python 2.5.4 (win32)
arguments: ['C:\\Program Files\\Bazaar\\bzr.exe', '--command=add',
'--file=C:\\src\\ssd\\source\\Core\\Utilities\\ManagedPoolInline.h',
'--file=C:\\src\\ssd\\source\\Core\\Utilities\\ManagedPool.h']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.1.0]
  explorer C:\Program Files\Bazaar\plugins\explorer [1.0.1]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.1.0]
  netrc_credential_store C:\Program
Files\Bazaar\plugins\netrc_credential_store [2.1.0]
  news_merge C:\Program Files\Bazaar\plugins\news_merge
[2.1.0]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.18.3]
  rebase C:\Program Files\Bazaar\plugins\rebase [0.5.5]
  svn C:\Program Files\Bazaar\plugins\svn [1.0.2]
  upload C:\Program Files\Bazaar\plugins\upload [1.0.0dev]
  xmloutput C:\Program Files\Bazaar\plugins\xmloutput [0.8.6]

To unsubscribe from this bug, go to:
https://bugs.launchpad.net/qbzr/+bug/557603/+subscribe

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: bzr add crashed

Can you reproduce this problem by running qadd again in your tree? If you can reproduce then please install QBzr 0.18.5 from the installer http://launchpad.net/qbzr/0.18/0.18.5/+download/qbzr-setup-0.18.5.exe and try to run qadd again. If you get the same error with 0.18.5 -- please say so. If you won't reproduce this problem with 0.18.5 tell us as well.

Is it clearer now?

Revision history for this message
Martin Packman (gz) wrote :

I can reproduce this issue on trunk, and the problem in TreeFilterProxyModel.filter_id seems reasonably simple.

I'm not sure how to test it though, I have a testcase in <lp:~gz/qbzr/treewidget_filter_attributeerror_557603> that triggers the problem, but as the error happens in a callback it just gets dumped on stderr. Is there some way of getting reraising or otherwise handling it differently Alexander?

tags: added: treewidget
summary: - bzr add crashed
+ AttributeError on 'is_ignored' in treewidget filtering when adding in
+ tree with conflicts
Changed in qbzr:
importance: Undecided → Medium
status: Incomplete → Confirmed
Martin Packman (gz)
Changed in qbzr:
assignee: nobody → Martin Packman (gz)
status: Confirmed → In Progress
Revision history for this message
Alexander Belchenko (bialix) wrote :

> Is there some way of getting reraising or otherwise handling it differently Alexander?

I'm not sure. Those tests have been written by Gary. I have forgotten some details. Sorry.

Martin Packman (gz)
no longer affects: qbzr/0.22
Revision history for this message
Alexander Belchenko (bialix) wrote :

Thanks

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.