Ubuntu
qemu-kvm package

Missing -f option for 'qemu-img snapshot'

Bug #594179 reported by Andreas Florath on 2010-06-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	qemu-kvm (Ubuntu)	Won't Fix	Low	Unassigned

Bug Description

Binary package hint: qemu-kvm

In the qemu-img 'snapshot' command the '-f' option is missing (which I need...); It's only available for all other commands:
  check [-f fmt] filename
  create [-f fmt] [-o options] filename [size]
  commit [-f fmt] filename
  convert [-c] [-f fmt] [-O output_fmt] [-o options] filename [filename2 [...]] output_filename
  info [-f fmt] filename
  snapshot [-l | -a snapshot | -c snapshot | -d snapshot] filename

The attached patch adds the -f option also to the snapshot command.

Environment:
Ubuntu 10.04 LTS
qemu-kvm_0.12.3+noroms-0ubuntu9_amd64.deb

See original description

Tags:

Revision history for this message

Andreas Florath (florath) wrote on 2010-06-14:

patch to add -f option Edit (3.4 KiB, text/plain)

Brian Murray (brian-murray) on 2010-06-14

tags:

added: patch

Andreas Florath (florath) on 2010-06-14

description:

updated

Revision history for this message

Mathias Gug (mathiaz) wrote on 2010-06-15:

What would you need to specify a format option when taking a snapshot? I'm not sure that you can have different format for the backend file and the snapshot file - is this what you're trying to achieve?

Changed in qemu-kvm (Ubuntu):
importance:	Undecided → Low
status:	New → Incomplete

Revision history for this message

Dustin Kirkland  (kirkland) wrote on 2010-06-15:

Thanks for the report. Snapshots only work with qcow2, which can always be detected.

Changed in qemu-kvm (Ubuntu):
status:	Incomplete → Invalid

Revision history for this message

Andreas Florath (florath) wrote on 2010-06-15:

Nope - this is not true: This version of qemu-img does *not* detect qcow2 images which life inside a LVM2 logical volume.
Without the patch, qemu-img detects a 'host_device' in this case, e.g. 'qemu-img snapshot -l ...' does not print anything.
With the patch applied 'qemu-img snapshot -f qcow2 -l ...' works fine.

Revision history for this message

Andreas Florath (florath) wrote on 2010-06-16:

Checked this with the latest git master from qemu.
The git-qemu-img version works fine: it detects the qcow2 image inside the LVM2 logical volume - without the need to specify the format. The checked qemu version is 0.12.50.

Revision history for this message

Andreas Florath (florath) wrote on 2010-06-21:

(Had a mail exchange with Dustin: result is that I should set the Status back to new.)

Changed in qemu-kvm (Ubuntu):
status:	Invalid → New

Revision history for this message

Serge Hallyn (serge-hallyn) wrote on 2010-06-24:

Hi Andreas,

just to be clear, you are saying that qemu-img in upstream git tree
would not need this patch, right?

Revision history for this message

Andreas Florath (florath) wrote on 2010-06-25:

Exactly - git version of qemu from last week does not have this problem.

Ara Pulido (ara) on 2010-08-12

tags:

added: patch-rejected
removed: patch

Revision history for this message

Ara Pulido (ara) wrote on 2010-08-12:

I have marked the patch as rejected. The reporter says that the upstream version is already fixed in their trunk. We will wait for the trunk version to arrive to Ubuntu.

Revision history for this message

Dustin Kirkland  (kirkland) wrote on 2010-08-13:

#10

Marking won't-fix, in that Ubuntu won't need to carry this patch. Instead, this problem will be fixed when we merge the qemu in git into Ubuntu (eventually).