Model tests not testing correctly

Bug #614123 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Critical
Gary van der Merwe
0.19
Fix Released
Critical
Gary van der Merwe

Bug Description

  affects qbzr

Several qbzr tests are failing for me on Maverick. Below is the subunit
output:

======================================================================
ERROR:
bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_empty_branch
----------------------------------------------------------------------
Text attachment: log
------------
5.845 creating repository in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_empty_branch/work/.bzr/.
5.847 creating branch <bzrlib.branch.BzrBranchFormat7 object at
0x5ef0990> in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_empty_branch/work/
5.856 trying to create missing lock
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_empty_branch/work/.bzr/checkout/dirstate'
5.856 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_empty_branch/work'
------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_logmodel.py", line 51, in test_empty_branch
    self._test(wt)
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_logmodel.py", line 47, in _test
    modeltest = ModelTest(log_model, None);
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/modeltest.py", line 41, in __init__
    self.connect( self.model,
QtCore.SIGNAL("columnsAboutToBeInserted(const QtCore.QModelIndex&, int,
int)"), self.runAllTests)
TypeError: type 'QtCore.QModelIndex' is not supported as a slot argument
type
------------
======================================================================
ERROR: bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_merges
----------------------------------------------------------------------
Text attachment: log
------------
5.870 creating repository in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_merges/work/.bzr/.
5.872 creating branch <bzrlib.branch.BzrBranchFormat7 object at
0x5eee150> in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_merges/work/
5.878 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_merges/work/
5.879 Selecting files for commit with filter None
    INFO Committed revision 1.
5.886 Committed revid rev-1 as revno 1.
5.887 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_merges/work/
5.888 Selecting files for commit with filter None
    INFO Committed revision 2.
5.897 Committed revid rev-2a as revno 2.
5.899 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_logmodel.TestModel.test_merges/work/
5.900 Selecting files for commit with filter None
    INFO Committed revision 2.
5.907 Committed revid rev-2b as revno 2.
------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_logmodel.py", line 82, in test_merges
    self._test(wt)
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_logmodel.py", line 47, in _test
    modeltest = ModelTest(log_model, None);
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/modeltest.py", line 41, in __init__
    self.connect( self.model,
QtCore.SIGNAL("columnsAboutToBeInserted(const QtCore.QModelIndex&, int,
int)"), self.runAllTests)
TypeError: type 'QtCore.QModelIndex' is not supported as a slot argument
type
------------
======================================================================
ERROR:
bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)
----------------------------------------------------------------------
Text attachment: log
------------
5.919 creating repository in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree%29/work/trunk/.bzr/.
5.921 creating branch <bzrlib.branch.BzrBranchFormat7 object at
0x5ec9fd0> in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree%29/work/trunk/
5.928 trying to create missing lock
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/trunk/.bzr/checkout/dirstate'
5.928 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/trunk'
5.936 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/trunk/
5.938 Selecting files for commit with filter None
    INFO added textconflict
    INFO Committed revision 1.
5.946 Committed revid rev-a as revno 1.
5.951 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/trunk'
5.958 creating repository in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree%29/work/branch/.bzr/.
5.962 Using fetch logic to copy between
CHKInventoryRepository('file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree%29/work/trunk/.bzr/repository/')(RepositoryFormat2a()) and CHKInventoryRepository('file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree%29/work/branch/.bzr/repository/')(RepositoryFormat2a())
5.962 fetch up to rev {None}
5.972 creating branch <bzrlib.branch.BzrBranchFormat7 object at
0x263cb50> in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree%29/work/branch/
5.978 created new branch
BzrBranch7(file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree%29/work/branch/)
5.983 trying to create missing lock
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/branch/.bzr/checkout/dirstate'
5.983 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/branch'
5.995 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/branch'
5.999 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/branch/
6.001 Selecting files for commit with filter None
    INFO modified textconflict
    INFO Committed revision 2.
6.011 Committed revid rev-b as revno 2.
6.032 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree)/work/trunk/
6.034 Selecting files for commit with filter None
    INFO added dir
    INFO added missing
    INFO added modified
    INFO added moved
    INFO added movedandrenamed
    INFO added removed
    INFO added renamed
    INFO modified textconflict
    INFO added unmodified
    INFO added dir/dirchild
    INFO Committed revision 2.
6.049 Committed revid rev-c as revno 2.
------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_treewidget.py", line 186, in test_show_widget
    self.run_model_tests()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_treewidget.py", line 180, in run_model_tests
    ModelTest(self.widget.tree_model, None)
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/modeltest.py", line 41, in __init__
    self.connect( self.model,
QtCore.SIGNAL("columnsAboutToBeInserted(const QtCore.QModelIndex&, int,
int)"), self.runAllTests)
TypeError: type 'QtCore.QModelIndex' is not supported as a slot argument
type
------------
======================================================================
ERROR:
bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)
----------------------------------------------------------------------
Text attachment: log
------------
6.158 creating repository in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree-Changes-Mode%29/work/trunk/.bzr/.
6.161 creating branch <bzrlib.branch.BzrBranchFormat7 object at
0x5fd5d50> in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree-Changes-Mode%29/work/trunk/
6.168 trying to create missing lock
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/trunk/.bzr/checkout/dirstate'
6.168 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/trunk'
6.176 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/trunk/
6.178 Selecting files for commit with filter None
    INFO added textconflict
    INFO Committed revision 1.
6.187 Committed revid rev-a as revno 1.
6.196 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/trunk'
6.204 creating repository in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree-Changes-Mode%29/work/branch/.bzr/.
6.209 Using fetch logic to copy between
CHKInventoryRepository('file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree-Changes-Mode%29/work/trunk/.bzr/repository/')(RepositoryFormat2a()) and CHKInventoryRepository('file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree-Changes-Mode%29/work/branch/.bzr/repository/')(RepositoryFormat2a())
6.209 fetch up to rev {None}
6.221 creating branch <bzrlib.branch.BzrBranchFormat7 object at
0x263cb50> in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree-Changes-Mode%29/work/branch/
6.228 created new branch
BzrBranch7(file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Working-Tree-Changes-Mode%29/work/branch/)
6.233 trying to create missing lock
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/branch/.bzr/checkout/dirstate'
6.233 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/branch'
6.246 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/branch'
6.249 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/branch/
6.251 Selecting files for commit with filter None
    INFO modified textconflict
    INFO Committed revision 2.
6.263 Committed revid rev-b as revno 2.
6.284 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Working-Tree-Changes-Mode)/work/trunk/
6.286 Selecting files for commit with filter None
    INFO added dir
    INFO added missing
    INFO added modified
    INFO added moved
    INFO added movedandrenamed
    INFO added removed
    INFO added renamed
    INFO modified textconflict
    INFO added unmodified
    INFO added dir/dirchild
    INFO Committed revision 2.
6.301 Committed revid rev-c as revno 2.
------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_treewidget.py", line 186, in test_show_widget
    self.run_model_tests()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_treewidget.py", line 180, in run_model_tests
    ModelTest(self.widget.tree_model, None)
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/modeltest.py", line 41, in __init__
    self.connect( self.model,
QtCore.SIGNAL("columnsAboutToBeInserted(const QtCore.QModelIndex&, int,
int)"), self.runAllTests)
TypeError: type 'QtCore.QModelIndex' is not supported as a slot argument
type
------------
======================================================================
ERROR:
bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Revision-Tree)
----------------------------------------------------------------------
Text attachment: log
------------
6.316 creating repository in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Revision-Tree%29/work/tree/.bzr/.
6.318 creating branch <bzrlib.branch.BzrBranchFormat7 object at
0x5bf3f50> in
file:///tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget%28Revision-Tree%29/work/tree/
6.325 trying to create missing lock
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Revision-Tree)/work/tree/.bzr/checkout/dirstate'
6.325 opening working tree
'/tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Revision-Tree)/work/tree'
6.336 preparing to commit
    INFO Committing
to: /tmp/testbzr-zwkLT9.tmp/bzrlib.plugins.qbzr.lib.tests.test_treewidget.TestTreeWidget.test_show_widget(Revision-Tree)/work/tree/
6.338 Selecting files for commit with filter None
    INFO added a
    INFO added b
    INFO added b/c
    INFO Committed revision 1.
6.347 Committed revid rev-1 as revno 1.
------------
Text attachment: traceback
------------
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line
128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line
368, in _run_test_method
    testMethod()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_treewidget.py", line 186, in test_show_widget
    self.run_model_tests()
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/test_treewidget.py", line 180, in run_model_tests
    ModelTest(self.widget.tree_model, None)
  File
"/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/tests/modeltest.py", line 41, in __init__
    self.connect( self.model,
QtCore.SIGNAL("columnsAboutToBeInserted(const QtCore.QModelIndex&, int,
int)"), self.runAllTests)
TypeError: type 'QtCore.QModelIndex' is not supported as a slot argument
type
------------

Changed in qbzr:
importance: Undecided → Critical
Revision history for this message
Alexander Belchenko (bialix) wrote :

What version of PyQt/Qt is used on Maverick?

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I have 0.18.6-1ubuntu1

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

I think Alexander was asking for the PyQt and Qt versions, not qbzr version.

Alexander: You can see the versions on launchpad.

PyQt: https://launchpad.net/ubuntu/+source/python-qt4
(Maverick = 4.7.4)

Qt: https://edge.launchpad.net/ubuntu/+source/qt4-x11
(Maverick = 4.7.0 Beta 2)

I'm busy downloading Maverick, so that I can try fix this.

The file that the error is coming from is a file from the pyqt sources, which provides a test for models:
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/maverick/python-qt4/maverick/annotate/head:/contrib/pymodeltest/modeltest.py

It unfortunately has not been updated.

Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
milestone: none → 0.20b1
status: New → Fix Released
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Reopening, because I have reason to suppect that the signals or now not actually connecting, and so the tests are not really testing what they should be.

Changed in qbzr:
status: Fix Released → Confirmed
summary: - Several test failures
+ Model tests not testing correctly
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

This seems to be working correctly. I'm not sure why I though it was not.

Changed in qbzr:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.