Untranslated error window
Bug #633411 reported by
Gabor Kelemen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Gwibber |
Fix Released
|
Undecided
|
Vadim Rutkovsky | ||
| Ubuntu Translations |
Fix Released
|
Medium
|
Unassigned | ||
| gwibber (Ubuntu) |
Fix Released
|
Undecided
|
Vadim Rutkovsky | ||
Bug Description
Binary package hint: gwibber
When I do not unlock my keyring at login, gwibber can not connect to my account and shows an error window, which is not translated.
Related branches
lp:~roignac/gwibber/Bug633411
- gwibber-committers: Pending requested
-
Diff: 30 lines (+5/-4)2 files modifiedgwibber/microblog/util/exceptions.py (+4/-4)
po/POTFILES.in (+1/-0)
Revision history for this message
| Gabor Kelemen (kelemeng) wrote | #1 |
| Changed in ubuntu-translations: | |
| status: | New → Invalid |
| Changed in gwibber (Ubuntu): | |
| assignee: | nobody → Vadim Rutkovsky (roignac) |
| status: | New → In Progress |
| Changed in gwibber: | |
| assignee: | nobody → Vadim Rutkovsky (roignac) |
| status: | New → In Progress |
Revision history for this message
| David Planella (dpm) wrote | #2 |
| Changed in ubuntu-translations: | |
| status: | Invalid → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Vadim Rutkovsky (roignac) wrote | #3 |
Revision history for this message
| David Planella (dpm) wrote | #4 |
Revision history for this message
| Colin Watson (cjwatson) wrote | #5 |
| Changed in gwibber (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in gwibber: | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-translations: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Vadim,
Thanks a lot for working on a fix for this. Looking at your branch I see something that needs fixing in nearly all strings marked for translation:
_("There was an %s failure from %s for account %s, error was %s" % (kind, service, username, message))
The _() should only enclose the strings within the quotes, so they should look like:
_("There was an %s failure from %s for account %s, error was %s") % (kind, service, username, message)
Also, I'm not sure it is necessary to set the translation domain if it has already been done in the initial code of the application. Just importing gettext might be enough.