Editor window opens too large.

Bug #643675 reported by i
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Shutter
Fix Released
Low
Mario Kemper (Romario)

Bug Description

Hi Mario, Vadim.
This is a minor bug that's present in Shutter at least since 0.86.2 (when I started using it).
When the Editor is opened it always opens itself in a non-maximized window that is too large for my old 17" CRT monitor (using 1024x768 resolution). To be honest I don't remeber its behaviour with a larger resolution but I think then it's ok.
This is a very minor bug since all it's needed is to maximize the window.
The Editor remembers the height of the window last time it was used but always opens non-maximized and with that same width (too large for smaller resolutions). This is regardless of the image size.
http://yfrog.com/n1readetrabalho1007p (when it opens) > http://yfrog.com/7freadetrabalho1008p (maximized)
http://yfrog.com/2mespaodetrabalho1033p (when it opens) > http://yfrog.com/n4espaodetrabalho2034p (maximized)

Regards.

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Sorry, I'm using 0.86.4 from the PPA in Debian Sid.

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

Maybe this is a regression - I can't reproduce this on Maverick on 0.86.3. The editor window saves size correctly and opens maximized if it has been closed maximized.

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Hi Vadim. I don't think it's a regression since it occurs for me since 0.86.2 (doesn't remember to open maximized and also only remembers the last height, not width).
It occured for me when I used IceWM and Xfce and now with LXDE and GNOME. But I don't use Ubuntu, only Debian Sid now and before antiX (Debian Sid based).

I think Ubuntu uses Compiz, right? Maybe that makes the difference? Anyway, this is a very minor issue but if you need me to try some things just tell. Also if you want to leave it alone, then it's ok since it works for Ubuntu.

Revision history for this message
Vadim Rutkovsky (roignac) wrote :

I use Unity, which uses Mutter as WM. Also, could not reproduce on Metacity. I guess, the issue has nothing to do with Shutter - IMHO its a window-manager issue.
Please, specify which WM did you try.

If I'm correct, the code tries to set the size minimum at 640-480 or 100 pixels less than original window - maybe, this is the problem.

I hope, Mario will make this clear - I'm not really good at Gtk+Perl

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Now I have both Openbox (LXDE) and Metacity (GNOME).
I'll do a little video to illustrate.

Revision history for this message
Mario Kemper (Romario) (mario-kemper) wrote : Re: [Bug 643675] Re: Editor window opens too large.

> If I'm correct, the code tries to set the size minimum at 640-480 or
> 100
> pixels less than original window - maybe, this is the problem.

If possible it is set to 640x480. If not it is set to desktop-width
-100, desktop-height - 100.

Maximized/Unmaximized state is not explicitly saved/restored. I'll have
a closer look at it tomorrow.

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :
Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Just saying that if you want me to install the development version, it's ok for me.

Revision history for this message
Mario Kemper (Romario) (mario-kemper) wrote :

  I'll let you know when I've looked at the code.

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Mario, the issue happens because of the localization. I explain.
Once I translated a little app that used gtkdialog (I tried to find it to see the details but couldn't). gtkdialog had some parameter that set the maximum character count for some entry and since the Portuguese term had more than that the text got out of place in the GUI. By raising that number the text fitted perfectly (and didn't affect the original English).
GNOME-MPlayer has an awful preferences window in pt_BR that stretches for something like two desktop widths. It's the same problem (the GTK parameters would have to be tweaked so as not to be less than the length of the Portuguese terms).
This is happening in Shutter's editor window.

As we can see at http://img80.imageshack.us/img80/3743/hometempimagenscapturas.png ,maybe the terms that are causing this are in the bottom line:
Cor de preenchimento > Fill color
Espessura da linha > Line width
Inserir imagem > Insert image
or in the top line:
Ferramen_tas > _Tools

Then you check the code for these lines and raise the maximum character count for them so the GUI doesn't deform with the pt_BR locale.

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

I'll try to abbreviate these entries since they have tooltips and see if it solves this.

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :
Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Note: the window on the screenshot above wan't resized like the one in the previous screenshot.

Revision history for this message
Mario Kemper (Romario) (mario-kemper) wrote :

I am a little bit confused now. Does shortening the localization solve the problem or is there still something that needs to be fixed? I've already committed a fix for saving/restoring maximized/unmaximized state.

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Yes it solves it. As I said it has then a minimal width of 887 px (less than
1024). With this the maximized/unmaximized restoration works properly too.

I thought you found something to be improved and was working on it
nonetheless.

Regards.

(BTW, the translation has been updated with the shortened strings)

On Mon, Oct 11, 2010 at 7:08 PM, Mario Kemper (Romario) <
<email address hidden>> wrote:

> I am a little bit confused now. Does shortening the localization solve
> the problem or is there still something that needs to be fixed? I've
> already committed a fix for saving/restoring maximized/unmaximized
> state.
>
> --
> Editor window opens too large.
> https://bugs.launchpad.net/bugs/643675
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Shutter - Screenshot Tool: New
>
> Bug description:
> Hi Mario, Vadim.
> This is a minor bug that's present in Shutter at least since 0.86.2 (when I
> started using it).
> When the Editor is opened it always opens itself in a non-maximized window
> that is too large for my old 17" CRT monitor (using 1024x768 resolution). To
> be honest I don't remeber its behaviour with a larger resolution but I think
> then it's ok.
> This is a very minor bug since all it's needed is to maximize the window.
> The Editor remembers the height of the window last time it was used but
> always opens non-maximized and with that same width (too large for smaller
> resolutions). This is regardless of the image size.
> http://yfrog.com/n1readetrabalho1007p (when it opens) >
> http://yfrog.com/7freadetrabalho1008p (maximized)
> http://yfrog.com/2mespaodetrabalho1033p (when it opens) >
> http://yfrog.com/n4espaodetrabalho2034p (maximized)
>
> Regards.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/shutter/+bug/643675/+subscribe
>

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

Of course in a screen narrower than 887 px probably the problem would
reappear.

On Tue, Oct 12, 2010 at 1:29 PM, iki sham <email address hidden> wrote:

> Yes it solves it. As I said it has then a minimal width of 887 px (less
> than 1024). With this the maximized/unmaximized restoration works properly
> too.
>
> I thought you found something to be improved and was working on it
> nonetheless.
>
> Regards.
>
> (BTW, the translation has been updated with the shortened strings)
>
>
> On Mon, Oct 11, 2010 at 7:08 PM, Mario Kemper (Romario) <
> <email address hidden>> wrote:
>
>> I am a little bit confused now. Does shortening the localization solve
>> the problem or is there still something that needs to be fixed? I've
>> already committed a fix for saving/restoring maximized/unmaximized
>> state.
>>
>> --
>> Editor window opens too large.
>> https://bugs.launchpad.net/bugs/643675
>> You received this bug notification because you are a direct subscriber
>> of the bug.
>>
>> Status in Shutter - Screenshot Tool: New
>>
>> Bug description:
>> Hi Mario, Vadim.
>> This is a minor bug that's present in Shutter at least since 0.86.2 (when
>> I started using it).
>> When the Editor is opened it always opens itself in a non-maximized window
>> that is too large for my old 17" CRT monitor (using 1024x768 resolution). To
>> be honest I don't remeber its behaviour with a larger resolution but I think
>> then it's ok.
>> This is a very minor bug since all it's needed is to maximize the window.
>> The Editor remembers the height of the window last time it was used but
>> always opens non-maximized and with that same width (too large for smaller
>> resolutions). This is regardless of the image size.
>> http://yfrog.com/n1readetrabalho1007p (when it opens) >
>> http://yfrog.com/7freadetrabalho1008p (maximized)
>> http://yfrog.com/2mespaodetrabalho1033p (when it opens) >
>> http://yfrog.com/n4espaodetrabalho2034p (maximized)
>>
>> Regards.
>>
>> To unsubscribe from this bug, go to:
>> https://bugs.launchpad.net/shutter/+bug/643675/+subscribe
>>
>
>

Revision history for this message
i (iiiiii-deactivatedaccount) wrote :

But then if your fix for the editor to remember the maximized state works
fine, it would be fine for small screens: just leave the editor window set
to maximized.

On Tue, Oct 12, 2010 at 1:31 PM, iki sham <email address hidden> wrote:

> Of course in a screen narrower than 887 px probably the problem would
> reappear.
>
>
> On Tue, Oct 12, 2010 at 1:29 PM, iki sham <email address hidden> wrote:
>
>> Yes it solves it. As I said it has then a minimal width of 887 px (less
>> than 1024). With this the maximized/unmaximized restoration works properly
>> too.
>>
>> I thought you found something to be improved and was working on it
>> nonetheless.
>>
>> Regards.
>>
>> (BTW, the translation has been updated with the shortened strings)
>>
>>
>> On Mon, Oct 11, 2010 at 7:08 PM, Mario Kemper (Romario) <
>> <email address hidden>> wrote:
>>
>>> I am a little bit confused now. Does shortening the localization solve
>>> the problem or is there still something that needs to be fixed? I've
>>> already committed a fix for saving/restoring maximized/unmaximized
>>> state.
>>>
>>> --
>>> Editor window opens too large.
>>> https://bugs.launchpad.net/bugs/643675
>>> You received this bug notification because you are a direct subscriber
>>> of the bug.
>>>
>>> Status in Shutter - Screenshot Tool: New
>>>
>>> Bug description:
>>> Hi Mario, Vadim.
>>> This is a minor bug that's present in Shutter at least since 0.86.2 (when
>>> I started using it).
>>> When the Editor is opened it always opens itself in a non-maximized
>>> window that is too large for my old 17" CRT monitor (using 1024x768
>>> resolution). To be honest I don't remeber its behaviour with a larger
>>> resolution but I think then it's ok.
>>> This is a very minor bug since all it's needed is to maximize the window.
>>> The Editor remembers the height of the window last time it was used but
>>> always opens non-maximized and with that same width (too large for smaller
>>> resolutions). This is regardless of the image size.
>>> http://yfrog.com/n1readetrabalho1007p (when it opens) >
>>> http://yfrog.com/7freadetrabalho1008p (maximized)
>>> http://yfrog.com/2mespaodetrabalho1033p (when it opens) >
>>> http://yfrog.com/n4espaodetrabalho2034p (maximized)
>>>
>>> Regards.
>>>
>>> To unsubscribe from this bug, go to:
>>> https://bugs.launchpad.net/shutter/+bug/643675/+subscribe
>>>
>>
>>
>

Changed in shutter:
status: New → Fix Committed
importance: Undecided → Low
assignee: nobody → Mario Kemper (Romario) (mario-kemper)
milestone: none → 0.87
Changed in shutter:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.