Mahara

Blog account settings still available when blog disabled

Bug #646691 reported by Andrew Nicols
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
Mahara 1.9.0

Bug Description

Reported in the forum: http://mahara.org/interaction/forum/topic.php?id=2303

I've already pushed a potential fix for this in merge request 10 - though on second thoughts testing all plugin types is a bad idea, and it's best kept at just artefacts (as the current status quo).

If you're happy with this as a solution, I'll re-prepare the merge and push to master without the changes to lib/web.php

Andrew

Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

Sounds good, Andrew. Also, if you're just doing artefacts you might find require_artefact_plugins() useful - I added it a while ago when I had to so something similar.

Richard Mansfield (richard-mansfield)
Changed in mahara:
status: New → Confirmed
Revision history for this message
Robert Lyon (robertl-9) wrote :

Have submitted a patch for this:
https://reviews.mahara.org/#/c/2703/1

It does a check on plugins that can be disabled with is_active() in the pages that should not be accessed when plugin is disabled.

Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 1.9.0
Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2703
Committed: http://gitorious.org/mahara/mahara/commit/835244524a7568b761bdd130a48319f7c227c454
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 835244524a7568b761bdd130a48319f7c227c454
Author: Robert Lyon <email address hidden>
Date: Wed Nov 13 11:26:39 2013 +1300

Artefacts still accessible when disabled/hidden (bug #646691)

Currently we only hide links to artefact when we 'hide' them on the
extensions page rather than have them not accessible.

This patch will check to see if artefact is active and if it isn't
will display a access denied message.

note for testing: when hiding an artefact plugin it turns off the blocktypes
associated with it - but when you re-enable the artefact it does not
re-enable the blocktypes

Change-Id: Ic2282ededa7e85696dcaaac0768d35c52ecf3d01
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.