Import fails with "trying to import version ... again"

This looks like a failure where we started working with Version objects, rather than version strings.

Looking at the import_dsc code it does:

def has_version(version):
  tag_name = self.tag_name(version)

Which is a cast via 'str(version)'

However, the outer code does this:

    if update_db.branch.tags.has_tag(importp.version):

in bzrlib, '.has_tag(x)' is just (return x in self.get_tag_dict())

And the Version object doesn't match the str() object in a dict.

The simple fix looks like just using
    tag_version = update_db.tag_name(importp.version)
    if update_db.branch.tags.has_tag(tag_version):
        update_db.branch.tags.delete_tag(tag_version)

On Fri, 21 Jan 2011 18:58:33 -0000, John A Meinel <email address hidden> wrote:
> The simple fix looks like just using
> tag_version = update_db.tag_name(importp.version)
> if update_db.branch.tags.has_tag(tag_version):
> update_db.branch.tags.delete_tag(tag_version)

Nice catch. This was code that I added around UDS, so it's not a
migration problem per-se, rather that it never likely worked.

Thanks,

James

This has been rolled out on production. The tag was supposed to be deleted, and now is done so properly.