gtk.STOCK_REMOVE has changed to something (I think is) confusing

Bug #658616 reported by Patrick Farrell
28
This bug affects 3 people
Affects Status Importance Assigned to Milestone
humanity-icon-theme (Ubuntu)
Fix Released
Low
Ken VanDine
Maverick
Fix Released
Low
Unassigned

Bug Description

Binary package hint: ubuntu-mono

I maintain a GTK app used in-house at my university. It's a graphical editor for the input to a scientific model. (You can see a screenshot at http://amcg.ese.ic.ac.uk/index.php?title=Spud .) In the model options, some things are optional, and can be activated by clicking a plus icon on the right hand side of the TreeView; such things can then be deactivated by clicking on a minus icon in the TreeView. (You can see both the pluses and minuses in the screenshot.)

These icons are represented by a gtk.STOCK_ADD and a gtk.STOCK_REMOVE. But sometime between lucid and maverick, the gtk.STOCK_REMOVE icon used in the Ambiance theme got changed from a minus sign to a red circle with a bar through it, which to me has a meaning much closer to "cancel" or "danger" than "remove". As a visual metaphor for removing elements of the input to the model, it no longer makes sense. My users who have just updated to maverick have been a bit confused ...

So, is the right thing to do:

a) to bundle my own plus and minus icons, breaking consistency with the rest of the desktop, or

b) should the gtk.STOCK_REMOVE icon to be changed back to the minus sign it was in lucid? Is there a formal description of what the STOCK_REMOVE should signify anywhere? I couldn't find it through google.

Was there any discussion of the change on a mailing list anywhere? I googled for it but couldn't find any.

Like I said, the icon was perfectly appropriate in lucid, but it changed in maverick.

Any advice gratefully received!

Thanks,

Patrick

description: updated
Revision history for this message
Patrick Farrell (pefarrell) wrote :
Revision history for this message
Patrick Farrell (pefarrell) wrote :
Revision history for this message
Patrick Farrell (pefarrell) wrote :

Does anyone have any advice? I guess if no one is interested, I'll just bundle the clearlooks icons with my application ..

Revision history for this message
TKL (tkl2) wrote :

in Maverick the gtk-remove stock item is the same as gtk-delete. This is very confusing. In our Gtk application this results in menu buttons with the same icon and different functions. Other applications are also affected, for instance Deluge (Bittorent client).

IMO it is not a good idea to define the same icon for two different stock items. Furthermore, I think it is inconsistent to define the plus sign for gtk-add and not the minus sign for gtk-remove.

Revision history for this message
TKL (tkl2) wrote :

I just opened a new bug for package "humanity-icon-theme": Bug 662850

Revision history for this message
Vish (vish) wrote :

Argh! I'm not sure how i missed this change while uploading it. :-/
It was rev 700 in our lp:elementaryicons branch.

It was totally not intended. I'll revert the icon and try to SRU this for maverick.

affects: ubuntu-mono (Ubuntu) → humanity-icon-theme (Ubuntu)
Changed in humanity-icon-theme (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Patrick Farrell (pefarrell) wrote :

Great, thanks for that. Is there any way I can track how the SRU is getting along? (I don't know much about how they work)

Revision history for this message
Vish (vish) wrote :

Patrick, I'm right now in the Ubuntu developer summit. <http://uds.ubuntu.com/>
As are the other developers, as this is a busy week, it would be tough to expect them to upload it during this week.
The fix has been uploaded to branch it just needs to be uploaded to archive and SRU procedure followed.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

I've added a maverick task to track the regression in Maverick (see comment #6)

Changed in humanity-icon-theme (Ubuntu Maverick):
status: New → Triaged
importance: Undecided → Low
tags: added: maverick regression-release
Revision history for this message
Martin Pitt (pitti) wrote :

SRU ack, please get this uploaded.

Revision history for this message
Vish (vish) wrote :

KenVandine will be uploading the fix for Maverick..

@Ken, you can upload the same to Natty as well.

Changed in humanity-icon-theme (Ubuntu Maverick):
assignee: nobody → Ken VanDine (ken-vandine)
Changed in humanity-icon-theme (Ubuntu):
assignee: nobody → Ken VanDine (ken-vandine)
Changed in humanity-icon-theme (Ubuntu Maverick):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package humanity-icon-theme - 0.5.3.4

---------------
humanity-icon-theme (0.5.3.4) natty; urgency=low

  * debian/rules: Greatly simplify.
  * debian/control: Bump Standards-Version to 3.9.1.
  * debian/rules: Build with scour; add python-scour build dependency.

humanity-icon-theme (0.5.3.3) maverick-proposed; urgency=low

  * Revert list-remove; LP: #658616
 -- Martin Pitt <email address hidden> Tue, 02 Nov 2010 14:56:16 -0400

Changed in humanity-icon-theme (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted humanity-icon-theme into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Yann Dìnendal (yannbreliere) wrote :

Thanks, the icon is now a minus sign again.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Changed in humanity-icon-theme (Ubuntu Maverick):
assignee: Ken VanDine (ken-vandine) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package humanity-icon-theme - 0.5.3.3

---------------
humanity-icon-theme (0.5.3.3) maverick-proposed; urgency=low

  * Revert list-remove; LP: #658616
 -- K Vishnoo Charan Reddy <email address hidden> Tue, 26 Oct 2010 11:30:12 -0500

Changed in humanity-icon-theme (Ubuntu Maverick):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.