[Upstream] Redo and Undo should follow gnome scheme

Bug #677054 reported by Ciarán Mooney
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
LibreOffice
Fix Released
Wishlist
One Hundred Papercuts
Fix Released
Low
Unassigned
libreoffice (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: openoffice.org

For most Ubuntu apps which are Gnome-based projects the "Undo" and "Redo" shortcuts are Ctrl+z and Ctrl+Shift+z respectively.

OpenOffice does not follow this schema. It uses Ctrl+y instead of Ctrl+Shift+z instead. It would be nice if, in Ubuntu at least, it was all consistent.

Revision history for this message
Robert Roth (evfool) wrote :

Set as affecting the One Hundred Papercuts project too, because in my opinion this is a small inconsistency issue which should be fixed in ubuntu, and it won't be fixed upstream. With the replacement of OpenOffice with LibreOffice, this will still remain an issue, only it will appear in the libreoffice(Ubuntu) package. If libreOffice becomes the default in Natty, it would be nice to have this small "personalization" in it :).

Revision history for this message
Ryan Macnish (nisshh) wrote :

Hmmm, i know many applications that do this, not just OO.o, is this really necessary?

Revision history for this message
Robert Roth (evfool) wrote :

I think itás worth a discussion. Most of the apps included in the default install are Gnome apps, having the Gnome keyboard (Ctrl+S for Save, Ctrl+Z for Undo, Ctrl+O for Open, Ctrl+N for new) shortcuts. There are only a few exceptions. OO.o is one of them. Why do not make them consistent?
One of the main reason for the introduction of the indicators was the lack of consistency in the old notification area as a usability issue. Doesn't this apply to the shortcut keys too?
Different shortcuts for the same actions in different applications mean behavioral inconsistencies. It happened to me too, that I pressed Ctrl+Y and nothing happened (I am used to the Ctrl+Z and Ctrl+Y too). It took me some time to realize that the Gnome shortcut for Redo is Ctrl+Shift+Z in that particular application.
I am not saying that the keyboard shortcuts should all follow the gnome scheme, but only that they should follow the same scheme for the most common actions (New, Open, Save, Undo, Redo, Cut, Copy, Paste, Help).
Does this make sense?

Revision history for this message
Ciarán Mooney (ciaran-mooney) wrote :

It is certainly worth discussing. It's annoying to be honest having to learn different shortcuts for different apps. Especially when we have control over what shortcuts the apps have!

I don't mind if its Gnome or some other scheme, but Gnome would seem the sensible choice as a fair chunk of Ubuntu is based on Gnome and it would be the easiest scheme to adopt. I don't think there is much point discussing relative merits of different schemes.

Robert Roth your suggestion does indeed make sense!

Revision history for this message
Chris Wilson (notgary-deactivatedaccount) wrote :

I don't personally believe this is a valid papercut as OpenOffice is pretty much a lame duck at this stage, and fixing the bug in OOo will not fix it in LibreOffice since the code has already been forked. I personally believe it would be better to forget about fixing OpenOffice bugs at this time since it diverts valuable development resources away from other projects and onto something that is not on the long term roadmap for pretty much anyone.

LibreOffice will appear in Lauchpad soon enough, and Mark Shuttlework has already said he would like to include it in Ubuntu. Besides, the Document Foundation are gearing up for some serious development, and we may even see this bug being fixed before in the 1.0 release.

I would like to mark this as invalid both in openoffice and papercuts. What do people think?

Revision history for this message
Robert Roth (evfool) wrote :

I agree with that. It'd be better to fix it in LibreOffice.

Note: LibreOffice does have a project on launchpad, called df-libreoffice.

TDF is indeed working on the project, but maybe if we really want this fixed, we should send them a note about this as a feature request, and see if it's possible, and if not, make an U-specific patch. This would be good because it's still not clear when they'll have a release, and they won't do anything for us in the freeze period, and the fix most probably won't make it into Natty if we ask them after the release (which could be included in Natty)

So the questions are:
1) Is the fact that LibreOffice will be the default in Natty, already 'official'?
2) Do people agree that for consistency, the default office productivity suite should have the same redo shortcut as other applications?

I agree with marking it as invalid in OO.o, but it depends on the feedback on the second question whether it should be marked invalid in the Papercuts Project or not. Depending on the first question this bug should be set as affecting the LibreOffice (ubuntu) package (which still doesn't exist in LP).

Revision history for this message
Ciarán Mooney (ciaran-mooney) wrote :

I don't care if the shortcut gets changed in OO.o or LibreOffice, as long as the default office suite that is in Ubuntu follows the schema that the rest of the desktop uses.

Revision history for this message
In , Notgary-d (notgary-d) wrote :

In most Gnome applications, Undo actions are performed with the CTRL+Z keyboard shortcut and Redo actions can be performed with CTRL+SHIFT+Z. In LibreOffice, Undo is CTRL+Z but Redo is CTRL+Y. This is an inconsistency in the user experience and can lead to some frustration among users who used Gnome based desktops and are used to the keyboard shortcuts used there.

Revision history for this message
In , Yfjiang (yfjiang) wrote :

Enhancement request.

It is also interesting to know if any emacs users feel uncomfortable with C-Y to redo? :)

Revision history for this message
In , Cedric-bosdonnat-ooo (cedric-bosdonnat-ooo) wrote :

Well, do we want different shortcuts for each and every desktop?

Revision history for this message
In , Yfjiang (yfjiang) wrote :

Hi Chris,

Does the customize short-cut key(Tool->customize->keyboard) help to resolve the problem? The C-S-z seems not natively occupied by other functions in LibO.

Revision history for this message
Chris Wilson (notgary-deactivatedaccount) wrote :

I've submitted a bug report upstream so the developers are now aware of the situation. I agree that this should be invalidated as an OOo bug but confirmed as a papercut as the issue is that the default productivity suite, regardless of what it is, should adhere to the standard Gnome keyboard scheme.

Changed in df-libreoffice:
importance: Undecided → Unknown
status: New → Unknown
Changed in hundredpapercuts:
status: New → Confirmed
Revision history for this message
In , Notgary-d (notgary-d) wrote :

Hi Yifan,

I hadn't realised LibreOffice and OpenOffice weren't native Gnome applications as I don't use word processors (LaTeX for me). I'm doing work downstream in Ubuntu and someone reported this bug to us and I reported it here so it could be fully triaged.

I'll suggest that we modify the shortcut key ourselves when we ship the package.

Revision history for this message
Chris Wilson (notgary-deactivatedaccount) wrote :

The upstream devs have reviewed this bug and don't think it would be a great idea for them to maintain different versions for different desktop environments, so Redo will remain mapped to CTRL+Y at their end.

I propose that, when LibreOffice is being packaged for Ubuntu, that the Redo command be manually remapped, and that any reference in the application or documentation to the keyboard shortcut should be amended to reflect the new mapping.

Revision history for this message
Vish (vish) wrote :

We did patch something similar for F11 and fullscreen, in OO.o.

Ideally, it would be good if upstream made the change in the Linux/Gnome version.
It's more important to be consistent within a desktop than across desktops.

Changed in openoffice.org (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Changed in hundredpapercuts:
importance: Undecided → Low
status: Confirmed → Triaged
Changed in df-libreoffice:
status: Unknown → Invalid
Changed in df-libreoffice:
importance: Unknown → Wishlist
Revision history for this message
In , Diggory-hardy-x (diggory-hardy-x) wrote :

Hi all,

Well, Ctrl+Shift+Z is also the standard KDE shortcut for redo, so I don't think it's quite necessary to have a different shortcut for every desktop. Since Ctrl+Shift+Z doesn't have any other assignment in LibreOffice, isn't it reasonable to add that as a shortcut for redo?

The other point about platform-specific modifications is another way to go about this kind of thing, but it does have one drawback: LibreOffice won't behave the same way across platforms. If I ever use applications like firefox or libreoffice on Windows, I expect them to behave in the way that I'm used to on linux, and I expect most people do too (within reason).

Changed in df-libreoffice:
status: Invalid → Confirmed
Changed in openoffice.org (Ubuntu):
status: Triaged → Won't Fix
Revision history for this message
John Lea (johnlea) wrote : Re: Redo and Undo should follow gnome scheme

The Ctrl+Y shortcut should also be retained because this is a standard shortcut for users crossing over from windows.

Both Ctrl+Y and Ctrl+Shift+z should perform the same action.

Revision history for this message
Björn Michaelsen (bjoern-michaelsen) wrote : migrating packaging from OpenOffice.org to Libreoffice

[This is an automated message.]
There are no new official OpenOffice.org releases in Ubuntu packaging anymore => Won't Fix

If the problem persists, please mark this bug as "also affects project Libreoffice" or "also affects distribution Libreoffice (Ubuntu)" if that has not happened already.

Please leave references to upstream OpenOffice.org bugs in place to allow cross pollination.

penalvch (penalvch)
summary: - Redo and Undo should follow gnome scheme
+ [Upstream] Redo and Undo should follow gnome scheme
Changed in hundredpapercuts:
assignee: nobody → Kristian Brimble (brimble2010)
Changed in hundredpapercuts:
assignee: Kristian Brimble (brimble2010) → nobody
Revision history for this message
In , Joren-libreoffice (joren-libreoffice) wrote :

*** Bug 64444 has been marked as a duplicate of this bug. ***

Revision history for this message
In , WhyNotHugo (whynothugo) wrote :

(In reply to comment #5)
> [...]
> The other point about platform-specific modifications is another way to go
> about this kind of thing, but it does have one drawback: LibreOffice won't
> behave the same way across platforms. If I ever use applications like
> firefox or libreoffice on Windows, I expect them to behave in the way that
> I'm used to on linux, and I expect most people do too (within reason).

I belive there's probably more *nix-only users, than users that constantly switch between platforms.
Since you mentioned firefox, it too uses Ctrl+Shift+Z for redo on *nix.

I don't expect LO to behave the same on OSX either, since the standard there is Cmd+Shift+Z (and there isn't even ctrl to do Ctrl+Y).

Since Ctrl+Shift+Z is not occupied by default, LO could just ship both hotkeys (Ctrl+Shift+Z AND Ctrl+Y). That would satisfy constantly-OS-switching users as well.

Revision history for this message
In , Joren-libreoffice (joren-libreoffice) wrote :

I don't know it's possible to link 2 shortcut keys to one action.

I asked on the UX-advice (user experience advice) mailinglist for advice/input (see http://lists.freedesktop.org/archives/libreoffice-ux-advise/2013-May/002033.html)

Kind regards,
Joren

Revision history for this message
In , Joren-libreoffice (joren-libreoffice) wrote :

UX-advice recommended to link both ctrl+y and ctrl+shift+z to the redo command. So I send a patch to gerrit for review: https://gerrit.libreoffice.org/#/c/3853/

Kind regards,
Joren

Changed in df-libreoffice:
status: Confirmed → In Progress
Revision history for this message
In , Libreoffice-commits (libreoffice-commits) wrote :

Joren De Cuyper committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=833cafe4eb9e0bd6b599e8bcbb6d77f4f2243034

fdo#32368 - Link both Ctrl+Y as Ctrl+Shift+Z as shortcut keys for Redo

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Revision history for this message
In , Joren-libreoffice (joren-libreoffice) wrote :

Part of my commit message:

As discussed on the UX-advice and bug report itself,
we agreed to link both shortcut keys to the redo command.

Due http://opengrok.libreoffice.org/xref/core/framework/source/inc/accelerators/acceleratorcache.hxx#75 :
/*map commands to keys in relation 1:n. First key is interpreted as preferred one!*/ the shortcut key that is mentioned in the menu entry is ctrl+y (or cmd+y for Mac users).

So for everyone: you will still see ctrl+y as shortcut key in the menu entries, but ctrl+shift+z is also a Redo-command now. (it isn't possible to show 2 shortcuts in the menu entry).

Kind regards,
Joren

Changed in libreoffice (Ubuntu):
status: New → Triaged
importance: Undecided → Low
no longer affects: openoffice.org (Ubuntu)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu:
status: New → Confirmed
affects: ayatana-design → ubuntu
no longer affects: ubuntu
Changed in libreoffice (Ubuntu):
status: Triaged → Fix Committed
Changed in df-libreoffice:
status: In Progress → Fix Released
Revision history for this message
Björn Michaelsen (bjoern-michaelsen) wrote :

Fix released with upstream 4.1.0, thus in saucy which has 4.1.2

Changed in libreoffice (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Paul White (paulw2u) wrote :

Closing as all other bug tasks showing "Fix Released"

Changed in hundredpapercuts:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.