Bazaar

some tests from the launchpad plugin requires lazr.uri

Bug #687315 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Invalid
Medium
Unassigned
Bazaar Mac Installers
Confirmed
High
Gordon Tyler
launchpadlib
Invalid
Wishlist
Unassigned

Bug Description

bzrlib.plugins.launchpad.test_lp_api.TestCacheDirectory.test_get_cache_directory
bzrlib.plugins.launchpad.test_lp_api.TestDependencyManagement.test_supported_launchpadlib_version
bzrlib.plugins.launchpad.test_lp_api.TestDependencyManagement.test_get_launchpadlib_version
bzrlib.plugins.launchpad.test_lp_api.TestDependencyManagement.test_unsupported_launchpadlib_version

fails on babune for OSX 10.6 (http://babune.ladeuil.net:24842/job/selftest-osx-10.6/lastFailedBuild/testReport/)

Long story short: the launchpadlib features needed by the launchpad plugin don't require lazr.uri, but launchpadlib imports it for some other features define in the same file.

Related branches

lp:~vila/bzr/687315-lazr-uri
Rejected for merging into lp:bzr
John A Meinel: Approve
Diff: 44 lines (+10/-2)
2 files modified
bzrlib/plugins/launchpad/test_lp_api.py (+7/-2)
doc/en/release-notes/bzr-2.3.txt (+3/-0)
Revision history for this message
Vincent Ladeuil (vila) wrote :

From the bzr point of view, it's enough to test for the presence of the lazr.uri module and skip the test (even if this sound weird, these are unexpected failures and add no value to the tests).

Since launchpadlib is used on platforms with no package manager, it would be nice if this was better handled by launchpadlib itself though.

Changed in launchpadlib:
importance: Undecided → Wishlist
Changed in bzr:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Vincent Ladeuil (vila)
Vincent Ladeuil (vila)
Changed in launchpadlib:
status: New → Invalid
Changed in bzr:
status: In Progress → Invalid
Revision history for this message
Vincent Ladeuil (vila) wrote :

It turns out I was wrong in my diagnosis.

This is really a packaging bug in the osx installers: launchpadlib is only installed if the bzr-pipeline plugin is installed (it's an optional dependency there).

But the dependencies of launchpadlib itself should therefore be also taken into account:
- python-lazr.uri
- python-lazr.restfulclient
- python-simplejson
- python-httplib2
- python-wadlib
- python-oauth

This is a significant burden and we may prefer to *remove* launchpadlib in the mean time if bzr-pipeline can survive from that.

We may also want to package launchpadlib in its own subpackage with its own dependencies and makes it a requirement for bzr-pipeline once we get there.

Changed in bzr-mac-installers:
importance: Undecided → High
status: New → Confirmed
Changed in bzr:
assignee: Vincent Ladeuil (vila) → nobody
Gordon Tyler (doxxx)
Changed in bzr-mac-installers:
assignee: nobody → Gordon Tyler (doxxx)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.