pep8 errors on trunk r592

Bug #705504 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
John Dewey

Bug Description

after running run_tests.sh:

bin/nova-spoolsentry:79:28: E202 whitespace before '}'
            'key': self.key
                           ^
    Avoid extraneous whitespace in the following situations:

    - Immediately inside parentheses, brackets or braces.

    - Immediately before a comma, semicolon, or colon.

    Okay: spam(ham[1], {eggs: 2})
    E201: spam( ham[1], {eggs: 2})
    E201: spam(ham[ 1], {eggs: 2})
    E201: spam(ham[1], { eggs: 2})
    E202: spam(ham[1], {eggs: 2} )
    E202: spam(ham[1 ], {eggs: 2})
    E202: spam(ham[1], {eggs: 2 })

    E203: if x == 4: print x, y; x, y = y , x
    E203: if x == 4: print x, y ; x, y = y, x
    E203: if x == 4 : print x, y; x, y = y, x
nova/tests/test_virt.py:259:48: E202 whitespace before ']'
      '# Completed on Tue Jan 18 23:47:56 2011'
                                               ^
    Avoid extraneous whitespace in the following situations:

    - Immediately inside parentheses, brackets or braces.

    - Immediately before a comma, semicolon, or colon.

    Okay: spam(ham[1], {eggs: 2})
    E201: spam( ham[1], {eggs: 2})
    E201: spam(ham[ 1], {eggs: 2})
    E201: spam(ham[1], { eggs: 2})
    E202: spam(ham[1], {eggs: 2} )
    E202: spam(ham[1 ], {eggs: 2})
    E202: spam(ham[1], {eggs: 2 })

    E203: if x == 4: print x, y; x, y = y , x
    E203: if x == 4: print x, y ; x, y = y, x
    E203: if x == 4 : print x, y; x, y = y, x

Related branches

Thierry Carrez (ttx)
tags: added: low-hanging-fruit
Changed in nova:
status: New → Confirmed
Revision history for this message
John Dewey (retr0h) wrote :

I do not see this to be an issue in "revno: 606"

$:nova% pep8 --repeat --show-pep8 --show-source --exclude=vcsversion.py bin/* nova setup.py
$:nova%

Revision history for this message
John Dewey (retr0h) wrote :

Jay can you please confirm the issue still exists or not?

Revision history for this message
John Dewey (retr0h) wrote :

Wow okay odd - I can reproduce this now that I have ran source .nova-venv/bin/activate

will investigate tomorrow.

Changed in nova:
assignee: nobody → John Dewey (retr0h)
John Dewey (retr0h)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Jay Pipes (jaypipes) wrote : Re: [Bug 705504] Re: pep8 errors on trunk r592

Hey John! Sorry, was travelling all day yesterday. This is now resolved, no?

-jay

On Mon, Jan 24, 2011 at 6:34 PM, John Dewey <email address hidden> wrote:
> Jay can you please confirm the issue still exists or not?
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/705504
>
> Title:
>  pep8 errors on trunk r592
>

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → 2011.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.