pep8 errors on trunk r592
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Low
|
John Dewey |
Bug Description
after running run_tests.sh:
bin/nova-
'key': self.key
Avoid extraneous whitespace in the following situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.
Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })
E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x
nova/tests/
'# Completed on Tue Jan 18 23:47:56 2011'
Avoid extraneous whitespace in the following situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.
Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })
E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x
Related branches
- Devin Carlen (community): Approve
- Thierry Carrez (community): Approve
- Vish Ishaya (community): Approve
-
Diff: 41 lines (+4/-5)3 files modifiedAuthors (+1/-0)
bin/nova-spoolsentry (+2/-4)
nova/tests/test_virt.py (+1/-1)
tags: | added: low-hanging-fruit |
Changed in nova: | |
status: | New → Confirmed |
Changed in nova: | |
status: | Confirmed → In Progress |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → 2011.1 |
status: | Fix Committed → Fix Released |
I do not see this to be an issue in "revno: 606"
$:nova% pep8 --repeat --show-pep8 --show-source --exclude= vcsversion. py bin/* nova setup.py
$:nova%