use ip instead of ifconfig in nova/network/linux_net.py
Bug #713766 reported by
Christian Berendt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Unassigned | ||
Bug Description
there are several calls to ifconfig. i think it's better to use ip instead of ifconfig, because it's obsolete on systems with Linux kernel newer than 2.0. (Take a look into IFCONFIG(8)).
# grep -n ifconfig nova/network/
183: _execute("sudo ifconfig %s up" % interface)
198: _execute("sudo ifconfig %s %s broadcast %s netmask %s up" % \
206: _execute("sudo ifconfig %s up" % bridge)
208: _execute("sudo ifconfig %s up" % bridge)
336: (_out, err) = _execute("ifconfig %s" % device, check_exit_
Related branches
lp:~berendt/nova/lp713766
- Vish Ishaya (community): Approve
- Devin Carlen (community): Approve
-
Diff: 45 lines (+10/-9)1 file modifiednova/network/linux_net.py (+10/-9)
| Changed in nova: | |
| importance: | Undecided → Wishlist |
| status: | New → Confirmed |
Revision history for this message
| Thierry Carrez (ttx) wrote | #1 |
Revision history for this message
| Christian Berendt (berendt) wrote | #2 |
| Changed in nova: | |
| status: | Confirmed → Fix Committed |
| Changed in nova: | |
| milestone: | none → 2011.2 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We should check that the fix for bug 710959 catches all of them.