launchpad-buildd

[Natty] check-implicit-pointer-functions fails on natty, resulting possibly broken packages

Bug #719162 reported by Eugene San
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpad-buildd
Fix Released
Critical
Julian Edwards

Bug Description

lib/canonical/buildd/check-implicit-pointer-functions fails on natty due to incomplete regex parsing of build log.

Example of build where check-implicit-pointer-functions fails to report: http://launchpadlibrarian.net/64306864/buildlog_ubuntu-natty-amd64.gtk%2B3.0_3.0.0-0ubuntu1_BUILDING.txt.gz

Example of build where check-implicit-pointer-functions succeeds to report: http://launchpadlibrarian.net/64328199/buildlog_ubuntu-maverick-amd64.gtk%2B3.0_3.0.0-0ubuntu1~eugenesan~maverick1_FAILEDTOBUILD.txt.gz

Please refer to http://irclogs.ubuntu.com/2011/02/14/%23launchpad.txt @17:14

See https://launchpad.net/ubuntu/+source/gtk+3.0/3.0.0-0ubuntu1/+buildjob/2260644

See original description
Tags: qa-ok

Related branches

lp:~julian-edwards/launchpad/buildd-regex-bug-719162
Leonard Richardson (community): Approve
Diff: 184 lines (+101/-52)
2 files modified
lib/canonical/buildd/check-implicit-pointer-functions (+58/-52)
lib/canonical/buildd/tests/test_check_implicit_pointer_functions.py (+43/-0)
Revision history for this message
Julian Edwards (julian-edwards) wrote :

In the maverick build:
{{{
/build/buildd/gtk+3.0-3.0.0/./gtk/ubuntumenuproxymodule.c:94: warning: assignment makes pointer from integer without a cast
Function `_gtk_find_module' implicitly converted to pointer at /build/buildd/gtk+3.0-3.0.0/./gtk/ubuntumenuproxymodule.c:94
/build/buildd/gtk+3.0-3.0.0/./gtk/ubuntumenuproxymodule.c: In function 'ubuntu_menu_proxy_module_get':
}}}

In the natty build:
{{{
/build/buildd/gtk+3.0-3.0.0/./gtk/ubuntumenuproxymodule.c:94:8: warning: assignment makes pointer from integer without a cast
/build/buildd/gtk+3.0-3.0.0/./gtk/ubuntumenuproxymodule.c: In function 'ubuntu_menu_proxy_module_get':
}}}

I suspect that the extra :8 in the natty compiler output is breaking the regex in `check-implicit-pointer-functions`

Changed in launchpad-buildd:
status: New → Triaged
importance: Undecided → Critical
status: Triaged → In Progress
assignee: nobody → Julian Edwards (julian-edwards)
summary: - [Natty] check-implicit-pointer-functions fails on amd64, resulting
+ [Natty] check-implicit-pointer-functions fails on natty, resulting
possibly broken packages
description: updated
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12388 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12388>.

tags: added: qa-needstesting
Changed in launchpad-buildd:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

lp-buildd is not deployed as part of routine Launchpad rollouts, so this doesn't need to block anything.

tags: added: qa-ok
removed: qa-needstesting
Julian Edwards (julian-edwards)
description: updated
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Tested OK today, ready to roll.

Julian Edwards (julian-edwards)
Changed in launchpad-buildd:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.