Build dh_translations

Bug #735934 reported by Martin Pitt
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cdbs (Ubuntu)
Fix Released
Undecided
Martin Pitt
Natty
Won't Fix
Undecided
Unassigned
pkgbinarymangler (Ubuntu)
Fix Released
Medium
Martin Pitt
Natty
Fix Released
Medium
Martin Pitt

Bug Description

Binary package hint: pkgbinarymangler

As more and more packages use dh7 these days, it becomes increasingly inconvenient to have the translation handling code in /usr/share/cdbs/1/rules/langpack.mk. We need to move this to a new dh_langpack and provide a dh sequencer for it. Then aptdaemon (bug 690270), compiz, etc. can use this.

Then cdbs should depend on dh-langpack and call dh_langpack instead.

Revision history for this message
Martin Pitt (pitti) wrote :

Moving cdbs to dh_langpack is not an urgent issue, thus not targetting that part to natty.

Changed in pkgbinarymangler (Ubuntu Natty):
assignee: nobody → Martin Pitt (pitti)
importance: Undecided → Medium
status: New → In Progress
Changed in cdbs (Ubuntu Natty):
status: New → Won't Fix
Changed in cdbs (Ubuntu):
status: New → Triaged
assignee: nobody → Martin Pitt (pitti)
Martin Pitt (pitti)
summary: - Build dh_langpack
+ Build dh_translations
Revision history for this message
David Planella (dpm) wrote :

Martin, as now we can load translations from .policy files directly from the .mo files (bug 619632), do you think it might be worth creating a rule that does a similar thing as with the .desktop/.server files, but with .policy files?

I.e. strip translations from the .policy files and and add the gettext-domain to the descriptions, as in:

  <action id="org.debian.apt.clean">
    <description gettext-domain="aptdaemon">Remove downloaded package files</description>
    <message>To clean downloaded package files, you need to authenticate.</message>
    <defaults>
      <allow_any>auth_admin</allow_any>
      <allow_inactive>auth_admin</allow_inactive>
      <allow_active>yes</allow_active>
    </defaults>
  </action>

Revision history for this message
Martin Pitt (pitti) wrote :

David,

we have had this rule in cdbs' langpack.mk for quite a while now, and I also added this to dh_translations.

Changed in pkgbinarymangler (Ubuntu Natty):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

(It also adds the domain to <message>, BTW)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 92

---------------
pkgbinarymangler (92) natty; urgency=low

  * Add debhelper script for handling translation operations. This makes it
    possible to have properly i18n'ed packages that don't use cdbs without
    introducing complicated build system changes. (LP: #735934)
    - test/icecream: Add po/ dir with an example po/*.po, *.desktop, *.server,
      *.policy, *.schemas files, and a Makefile which generates the pot.
    - Add dh_translations: debhelper script. Port the logic from
      /usr/share/cdbs/1/rules/langpack.mk.
    - test/run: Add test_dh_translations() test case.
    - debian/control, debian/dh-translations.install: Install dh_translations.
    - debian/rules: Build and install manpage from dh_translations POD.
  * test/icecream/debian/rules: Simplify using an override.
  * Add translations.pm: debhelper sequencer. Switch
    test/icecream/debian/rules to use --with translations instead of calling
    dh_translations directly. Point to local translations.pm in test/run
    setup.
  * dh_translations: Try getting domain from Python setup.cfg if po/Makefile
    does not exist.
 -- Martin Pitt <email address hidden> Thu, 17 Mar 2011 12:25:09 +0100

Changed in pkgbinarymangler (Ubuntu Natty):
status: Fix Committed → Fix Released
Martin Pitt (pitti)
Changed in cdbs (Ubuntu):
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.6 KiB)

This bug was fixed in the package cdbs - 0.4.93ubuntu1

---------------
cdbs (0.4.93ubuntu1) oneiric; urgency=low

  * Remove changes to kde.mk, this is obsolete.
  * Remove kde4.mk, apparently not being used any more. If you still need
    this, please yell, and I'll put it back.
  * Dropped langpack.mk.in, and associated test cases. We have dh-translations
    now.
  * Drop some fixes for corner cases to simple-patchsys and cdbs-edit-patch.
    The world uses quilt now, no need to carry this delta forever.
  * 1/class/gnome.mk.in: Drop langpack.mk, call dh_translations instead.
    (LP: #735934)
  * Merge with Debian unstable. Remaining Ubuntu changes:
    - 1/class/gnome.mk.in: Call dh_translations.
     - Add 1/rules/clean-la.mk.in: Remove dependency_libs lines from .la files.
       Install it in Makefile.am.
    - 1/rules/debhelper.mk.in:
      + Do not install upstream changelogs by default. They are huge and thus
        waste a lot of archive and CD space, quite uninteresting for ordinary
        users, and easy to get by downloading the source package or visiting the
        upstream page pointed out in copyright.
      + Symlink /usr/share/doc/ files to identical versions in any depending
        package which is built by the source package (except copyright, to
        adhere to Debian Policy). This can be disabled by setting
        $CDBS_NO_DOC_SYMLINKING.
      + Symlink identical Gnome help files (like untranslated images). This
        can be disabled by setting $CDBS_NO_GNOME_HELP_SYMLINKING. Add fdupes
        dependency for this.
    - 1/rules/utils.mk.in: add some text before listing missing file to make
      it easier to see from the build log (LP #509249)
    - test/testsuite_functions: Set NO_PKG_MANGLE so that tests do not fail
      with pkgstriptranslations installed.
    - 1/rules/debhelper.mk.in: Call dh_scour. debian/control.in: Add scour
      build and binary dependency (build dep for test suite).
    - 1/class/python-distutils.mk.in, 1/class/python-module.mk.in: Add
      --prefix support for pysupport by DEB_PYTHON_PREFIX_ARG (LP #625581)

cdbs (0.4.93) unstable; urgency=low

  [ Jonas Smedegaard ]
  * Fix readd default compile flag -Wall, accidentally dropped in cdbs
    0.4.90. Introduce new variable $DEB_WARNING_FLAGS to ease overriding
    while still rely on dpkg-buildflags.
  * Fix comment in langcore.mk.
  * Fix support arch-independent python3 modules: Resolve
    $cdbs_curpythonindepbinary properly, used for the Python binary to
    invoke for default builds.
    Closes: bug#621749. Thanks to Tanguy Ortolo and Jakub Wilk.
  * Add variables $cdbs_python2_indep_packages and
    $cdbs_python3_indep_packages to python-vars.mk, and when used
    tighten build-dependency on cdbs to versions properly supporting
    arch-independent Python3 builds.
  * Extend long ugly build-dependency cleanup routine to include cdbs
    0.4.93~.
  * Resolve $DEB_HOST_MULTIARCH from dpkg-architecture.
    Closes: bug#617841. Thanks to Steve Langasek.
  * Bump DEP5 format to rev. 174.
  * Stop compiling or installing documentation, to avoid circular
    build-dependency. Documentation will reappear as separate package.
   ...

Read more...

Changed in cdbs (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.