Launchpad itself

Person:+delete timeouts : Connect the UI the merge jobs

Bug #736421 reported by Curtis Hovey
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Unassigned
Launchpad itself 11.05

Bug Description

This issue is a continuation of bug 162510. The infrastructure is in place to merge people an team async.

- Update call-sites to use mergeAsync() where appropriate.

- UI to show if a user is the subject of a scheduled merge request.

See original description

Related branches

lp:~sinzui/launchpad/person-merge-job-4
Benji York (community): Approve (code)
Diff: 782 lines (+154/-262)
16 files modified
lib/canonical/launchpad/browser/logintoken.py (+5/-4)
lib/lp/registry/browser/peoplemerge.py (+18/-30)
lib/lp/registry/browser/person.py (+8/-0)
lib/lp/registry/browser/tests/peoplemerge-views.txt (+9/-21)
lib/lp/registry/browser/tests/person-views.txt (+1/-0)
lib/lp/registry/browser/tests/test_peoplemerge.py (+50/-26)
lib/lp/registry/browser/tests/test_person_view.py (+18/-4)
lib/lp/registry/browser/tests/test_team.py (+17/-0)
lib/lp/registry/interfaces/person.py (+12/-7)
lib/lp/registry/interfaces/persontransferjob.py (+2/-2)
lib/lp/registry/model/person.py (+3/-4)
lib/lp/registry/stories/person/merge-people.txt (+1/-35)
lib/lp/registry/stories/person/xx-adminpeoplemerge.txt (+4/-14)
lib/lp/registry/stories/person/xx-merge-person-with-hidden-email.txt (+0/-45)
lib/lp/registry/stories/team/xx-adminteammerge.txt (+4/-68)
lib/lp/registry/tests/test_person.py (+2/-2)
Curtis Hovey (sinzui)
Changed in launchpad:
status: Triaged → In Progress
Robert Collins (lifeless)
tags: added: timeout
Curtis Hovey (sinzui)
description: updated
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: 11.04 → 11.05
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12803 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12803>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 736421] Re: Person:+delete timeouts : Connect the UI the merge jobs

fwiw I tried to delete
<https://launchpad.net/~bzr-nightly-ppa/+delete> on qastaging and it
failed with : OOPS-1929D68.

Martin

Revision history for this message
Martin Pool (mbp) wrote :

Actually i think my browser was being too helpful and corrected that to the non-qastaging site, so I only confirmed that it doesn't work yet on lpnet. Sorry. I will try again on qastaging.

Revision history for this message
Martin Pool (mbp) wrote :

With some help from wgrant and spm we killed the ppa, and I could then successfully queue deletion of the team. qastaging now seems to be down though and https://qastaging.launchpad.net/~bzr-nightly-ppa errors.

Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Martin Pool (mbp) wrote :

Once qastaging was ok again, I did manage to delete that team to the
point of getting 'queued for deletion.'

Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Eric Day (eday) wrote :

While I no longer see the timeout reported in bug #745979, the team is still not being removed. It shows that it's queued for deletion for a few minutes, but then goes back to normal without being removed. Any insight?

Revision history for this message
Curtis Hovey (sinzui) wrote :

Is this about ~gearman-java-discuss ? The queue is processed once a hour, I think we want to run the task every 10 minutes.

Revision history for this message
Curtis Hovey (sinzui) wrote :

~gearman-java-discuss just disappeared while I was reloading it. I think the merge is complete.

Revision history for this message
Eric Day (eday) wrote :

Ah, it's gone! :) I tried removing it the past couple days and nothing had happened, but it obviously worked today. Thanks!

Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.