Bazaar

deprecate Repository.iter_reverse_revision_history

Bug #739481 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Low
Jelmer Vernooij
Bazaar 2.4b4

Bug Description

Repository has too many methods - iter_reverse_revision_history is just a trivial wrapper, and should be deprecated in favor of Graph.iter_lefthand_ancestry.

See original description

Related branches

lp:~jelmer/bzr/iter-reverse-revision-history
John A Meinel: Approve
Diff: 218 lines (+37/-20)
8 files modified
bzrlib/log.py (+11/-6)
bzrlib/reconcile.py (+4/-3)
bzrlib/remote.py (+1/-0)
bzrlib/repository.py (+5/-2)
bzrlib/tests/per_repository/test_iter_reverse_revision_history.py (+7/-3)
bzrlib/tests/test_foreign.py (+4/-3)
bzrlib/uncommit.py (+1/-3)
doc/en/release-notes/bzr-2.4.txt (+4/-0)
Revision history for this message
John C Barstow (jbowtie) wrote :

This bug description makes no sense - you're going to remove a method and replace it with itself?

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 739481] Re: deprecate Repostory.iter_reverse_revision_history

On Mon, 2011-03-21 at 20:24 +0000, John C Barstow wrote:
> This bug description makes no sense - you're going to remove a method
> and replace it with itself?
 I'm proposing to remove Repository.iter_reverse_revision_history and
suggest people use Graph.iter_lefthand_ancestry instead.
Repository.iter_reverse_revision_history is currently a trivial wrapper
around Graph.iter_lefthand_ancestry.

Cheers,

Jelmer

Revision history for this message
John C Barstow (jbowtie) wrote : Re: deprecate Repostory.iter_reverse_revision_history

"and should be removed in favor of Repository.iter_reverse_revision_history" was not clear; I've updated the description to be more accurate.

description: updated
Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 739481] Re: deprecate Repostory.iter_reverse_revision_history

On Mon, 2011-03-21 at 23:54 +0000, John C Barstow wrote:
> "and should be removed in favor of
> Repository.iter_reverse_revision_history" was not clear; I've updated
> the description to be more accurate.
 Ah, I see. Thanks!

Cheers,

Jelmer

Jelmer Vernooij (jelmer)
Changed in bzr:
status: Confirmed → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
summary: - deprecate Repostory.iter_reverse_revision_history
+ deprecate Repository.iter_reverse_revision_history
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 2.4b4
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.