All image types return as 'machine' when using glance client in ec2 api

Bug #760289 reported by Ryan Lane
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Jay Pipes

Bug Description

The glance client returns the container_format in image['properties'], not in image, but _format_image in cloud.py tries to pull the container_format from image, causing the image_type mapping to fail.

A fix for this may be to pull the container_format from 'properties', but I'm not sure if this will affect other clients.

Related branches

Revision history for this message
Jay Pipes (jaypipes) wrote :

The problem is with the GlanceImageService @classmethod called _translate_base(). This is kinda why I don't like inherited @classmethods.

The fix is to not override the _translate_base() @classmethod but instead call the @staticmethod service.BaseImageService._propertify_metadata() in GlanceImageService._translate_base()

Changed in nova:
assignee: nobody → Jay Pipes (jaypipes)
status: New → Triaged
status: Triaged → In Progress
importance: Undecided → High
Revision history for this message
Ryan Lane (rlane) wrote :

Linked branch works for me.

Thierry Carrez (ttx)
Changed in nova:
milestone: none → cactus-rc
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: cactus-rc → 2011.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.