papyon doesn't answer server's pings
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| papyon |
Fix Released
|
Undecided
|
Unassigned | ||
| papyon (Ubuntu) |
Fix Released
|
High
|
Ken VanDine | ||
| Natty |
Fix Released
|
Medium
|
Unassigned | ||
| Oneiric |
Fix Released
|
High
|
Ken VanDine | ||
Bug Description
together with Luis Francis we found a nasty bug that affects the
current papyon HEAD (read: 0.5.5). In C you would get a nice linker
error, but in python you won't.
The bug consists in the method that handles QNGs from the server being
defined twice, and the 2nd one being the BAD version. So you will
(not!) see the server thinking your client is offline after some time
and silently disconnecting you. But you won't get any notification
about it because your client is like network timed out. Anyway simply
removing the offending method will solve the issue, and you'll see the
usual PNG-QNG flow back.
This is quite a critical bug to me, and if lfrb won't be able to
release a new version of papyon soon i suggest distro packagers to
manually patch the code, it's a tiny diff you can drop once the next
papyon version is out.
greets
Riccardo
__
diff --git a/papyon/
index 5aee9f3..8aa691f 100644
--- a/papyon/
+++ b/papyon/
@@ -695,9 +695,6 @@ class NotificationPro
# --------- Challenge -------
- def _handle_QNG(self, command):
- pass
-
def _handle_QRY(self, command):
pass
Related branches
- Michael Terry: Approve
-
Diff: 27 lines (+7/-3)2 files modifieddebian/changelog (+7/-0)
papyon/msnp/notification.py (+0/-3)
| Omer Akram (om26er) wrote | #1 |
| Changed in papyon (Ubuntu): | |
| assignee: | nobody → Omer Akram (om26er) |
| importance: | Undecided → Medium |
| Changed in papyon (Ubuntu Natty): | |
| status: | New → Confirmed |
| Michael Terry (mterry) wrote | #2 |
| Michael Terry (mterry) wrote | #3 |
| Changed in papyon (Ubuntu Natty): | |
| assignee: | Omer Akram (om26er) → nobody |
| tags: | added: verification-needed |
| Martin Pitt (pitti) wrote Please test proposed package | #4 |
| Changed in papyon (Ubuntu Natty): | |
| status: | Confirmed → Fix Committed |
| Pedro Villavicencio (pedro) wrote | #5 |
| Pedro Villavicencio (pedro) wrote | #6 |
| Pedro Villavicencio (pedro) wrote | #7 |
| tags: |
added: verification-done removed: verification-needed |
| Launchpad Janitor (janitor) wrote | #8 |
| Changed in papyon (Ubuntu Natty): | |
| status: | Fix Committed → Fix Released |
| Martin Pitt (pitti) wrote | #9 |
| Changed in papyon (Ubuntu Oneiric): | |
| assignee: | nobody → Ken VanDine (ken-vandine) |
| importance: | Medium → High |
| milestone: | none → oneiric-alpha-1 |
| Changed in papyon (Ubuntu Oneiric): | |
| status: | Fix Committed → Fix Released |
| Changed in papyon: | |
| status: | New → Fix Committed |
| status: | Fix Committed → Fix Released |
i'll work on this backport. didrocks in #ubuntu-desktop says the fix can be SRU'ed as we are quite late in the cycle. Hopefully it'll be a zero day SRU.