xenapi SimpleDH() is encoding password with a '\n' at the end
Bug #788979 reported by
Chris Behrens
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Chris Behrens |
Bug Description
Kind of annoying, as we've had to go through a few iterations of fixes to get this right. However, it seems openssl behaves rather weirdly. When decrypting a base64 string, there needs to be a newline at the end. When you're encoding, it encodes everything sent, including a newline. The latter makes sense. The former... eh, I dunno. In any case, right now because we're always appending a newline when writing to stdin, openssl is encoding it with the password. We need to only send a newline when decoding base64 data.
Related branches
lp:~cbehrens/nova/lp788979
- Vish Ishaya (community): Approve
- Mark Washenberger (community): Approve
-
Diff: 78 lines (+32/-18)2 files modifiednova/tests/test_xenapi.py (+22/-4)
nova/virt/xenapi/vmops.py (+10/-14)
Changed in nova: | |
status: | New → In Progress |
assignee: | nobody → Chris Behrens (cbehrens) |
Changed in nova: | |
status: | In Progress → Fix Committed |
Changed in nova: | |
milestone: | none → diablo-1 |
Changed in nova: | |
milestone: | diablo-1 → 2011.3 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.