xenapi SimpleDH() is encoding password with a '\n' at the end

Bug #788979 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Chris Behrens

Bug Description

Kind of annoying, as we've had to go through a few iterations of fixes to get this right. However, it seems openssl behaves rather weirdly. When decrypting a base64 string, there needs to be a newline at the end. When you're encoding, it encodes everything sent, including a newline. The latter makes sense. The former... eh, I dunno. In any case, right now because we're always appending a newline when writing to stdin, openssl is encoding it with the password. We need to only send a newline when decoding base64 data.

Related branches

Chris Behrens (cbehrens)
Changed in nova:
status: New → In Progress
assignee: nobody → Chris Behrens (cbehrens)
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → diablo-1
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-1 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.