OpenStack Compute (nova)

Increase code coverage for Libvirt module

Bug #809131 reported by Rohit Karajgi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Soren Hansen

Bug Description

Libvirt is a critical component of Nova and has undergone many revisions. There is a need to increase statement and branch coverage of it's classes as per the requirements of diablo testing blueprint.
https://blueprints.launchpad.net/nova/+spec/diablo-testing

Add more tests for connection.py in nova.virt.libvirt.

See original description

Related branches

lp:~rohitk/nova/libvirt_unittests
Brian Lamar (community): Needs Fixing
Matt Dietz (community): Approve
William Wolf (community): Approve
Jay Pipes (community): Approve
Diff: 2005 lines (+1769/-59)
3 files modified
Authors (+1/-0)
nova/tests/fake_network.py (+3/-0)
nova/tests/test_libvirt.py (+1765/-59)
lp:~soren/nova/virt-test-improvements
Rick Harris (community): Needs Fixing
Diff: 2428 lines (+1976/-107)
10 files modified
nova/image/fake.py (+9/-1)
nova/image/service.py (+200/-0)
nova/tests/fake_libvirt_utils.py (+94/-0)
nova/tests/fakelibvirt.py (+773/-0)
nova/tests/test_fakelibvirt.py (+391/-0)
nova/tests/test_image.py (+11/-0)
nova/tests/test_libvirt.py (+184/-2)
nova/tests/test_virt_drivers.py (+41/-4)
nova/virt/libvirt/connection.py (+44/-100)
nova/virt/libvirt/utils.py (+229/-0)
Rohit Karajgi (rohitk)
Changed in nova:
assignee: nobody → Rohit Karajgi (rohitkarajgi)
status: New → Confirmed
Rohit Karajgi (rohitk)
Changed in nova:
status: Confirmed → In Progress
Rohit Karajgi (rohitk)
description: updated
Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Wishlist
Soren Hansen (soren)
tags: added: unittests
Revision history for this message
Soren Hansen (soren) wrote :

I hadn't noticed this bug and the corresponding branch. :(

I'm working on something quite similar at lp:~soren/nova/virt-test-improvements/

Revision history for this message
Mark McLoughlin (markmc) wrote :

Soren has made good progress on this since the bug was last updated. Re-assigning

Soren - do you think this can be marked fixed?

Changed in nova:
assignee: Rohit Karajgi (rohitkarajgi) → Soren Hansen (soren)
Revision history for this message
Tom Fifield (fifieldt) wrote :

Looking at the mass of code changes of the test files, this bug seems solved. Marking this old bug as "fix released" - if I'm wrong, please re-open!

Changed in nova:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.