Inconsistent deserialization of integers
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| neutron |
Fix Released
|
High
|
dan wendlandt | ||
| quantum (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The PortCount attribute of a network is returned as an integer in /quantum/
The json deserializer properly converts this into a python integer, but the XML deserialization returns it as a string.
The unit test checks for an integer and fails.
I confirmed that if I change networks.py and the unit test to use a string, the test passes for both JSON and XML.
Seems like two fixes are possible:
1) change the XML deserialization to be able to recognize when something is an integer and parse it into a python int.
2) say that the API does not support passing integer values and change the PortCount field to be a string (PortCount does not appear anywhere on the API spec page, http://
Related branches
- Somik Behera: Approve (netstack-core)
- Salvatore Orlando: Approve
-
Diff: 40 lines (+3/-9)2 files modifiedquantum/api/views/networks.py (+1/-5)
tests/unit/test_api.py (+2/-4)
| Changed in quantum: | |
| importance: | Critical → High |
| dan wendlandt (danwent) wrote | #1 |
| summary: |
- Inconsistent deserialization on integers + Inconsistent deserialization of integers |
| dan wendlandt (danwent) wrote | #2 |
| Changed in quantum: | |
| status: | New → In Progress |
| assignee: | Salvatore Orlando (salvatore-orlando) → dan wendlandt (danwent) |
| dan wendlandt (danwent) wrote | #3 |
| Changed in quantum: | |
| status: | In Progress → Fix Committed |
| Changed in quantum: | |
| status: | Fix Committed → Fix Released |
| Changed in quantum (Ubuntu): | |
| status: | New → Fix Released |
FYI, below are the tests that are failing
=======
FAIL: test_rename_
-------
Traceback (most recent call last):
File "/home/
self.
File "/home/
network_
AssertionError: {'PortCount': 0, 'id': u'0d63c0ba-
- {'PortCount': 0,
+ {u'PortCount': u'0',
? + ++ +
- 'id': u'0d63c0ba-
+ u'id': u'0d63c0ba-
? +
- 'name': 'new_network_name'}
+ u'name': u'new_network_
? + +
=======
FAIL: test_show_
-------
Traceback (most recent call last):
File "/home/
self.
File "/home/
network_
AssertionError: {'PortCount': 0, 'id': u'86fbc2af-
- {'PortCount': 0,
+ {u'PortCount': u'0',
? + ++ +
- 'id': u'86fbc2af-
+ u'id': u'86fbc2af-
? +
- 'name': 'test_network'}
+ u'name': u'test_network'}
? + +