Some tools don't have --help or --version
Bug #821502 reported by
Baron Schwartz
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Low
|
Daniel Nichter | ||
Bug Description
--version doesn't work, and it should. We probably need some common code library to implement this by pulling it out of the POD. Example:
[baron@ginger bin]$ ./pt-sift --version
[baron@ginger bin]$
Related branches
lp:~percona-toolkit-dev/percona-toolkit/version-in-all-bash-tools-bug-821502
- Daniel Nichter: Approve
-
Diff: 3154 lines (+2722/-166)6 files modifiedbin/pt-align (+1094/-1)
bin/pt-mext (+552/-42)
bin/pt-pmp (+572/-92)
bin/pt-sift (+481/-28)
t/pt-mext/pt-mext.t (+21/-1)
t/pt-pmp/pt-pmp.t (+2/-2)
| Changed in percona-toolkit: | |
| status: | New → Confirmed |
| Changed in percona-toolkit: | |
| importance: | Undecided → Low |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
| Changed in percona-toolkit: | |
| assignee: | Daniel Nichter (daniel-nichter) → nobody |
| tags: | added: all-tools |
| tags: |
added: pt-align pt-mext pt-mysql-summary pt-pmp pt-sift pt-summary removed: all-tools |
| tags: | removed: pt-mysql-summary pt-summary |
| Changed in percona-toolkit: | |
| milestone: | none → 2.2.2 |
| summary: |
- The formerly Aspersa tools need --version implemented + Some bash tools don't have --version |
| summary: |
- Some bash tools don't have --version + Some Bash tools don't have --version |
| Changed in percona-toolkit: | |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
| Changed in percona-toolkit: | |
| status: | Confirmed → In Progress |
| summary: |
- Some Bash tools don't have --version + Some tools don't have --help or --version |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #1 |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Had to add --relative to pt-mext and make its short form -r because apparently the parse_options lib doesn't like single-letter options. --relative (-r) is backwards-