Ubuntu One Client

Should export an interface to validate udf paths

Bug #824252 reported by Roberto Alsina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Brian Curtin
Ubuntu One Client 2.99.4
Trunk
Fix Released
Medium
Brian Curtin
Ubuntu One Control Panel
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Unassigned
Ubuntu One Control Panel 2.99.92
Trunk
Fix Released
Medium
Natalia Bidart
ubuntuone-client (Ubuntu)
Fix Released
Medium
dobey
Ubuntu ubuntu-12.04-beta-1
ubuntuone-control-panel (Ubuntu)
Fix Released
Undecided
Unassigned
Ubuntu ubuntu-12.04

Bug Description

Currently, the logic to check if a path is valid for user-defined-folder (a.k.a. cloud folder) creation is in control panel's validate_path_for_folder, and in every other app that allows clients to create cloud folders in U1.

This logic belongs to the u1-client project, and it should be exported as a method in the syncdaemon IPC/DBus interface.

Also, since the logic is currently in u1cp, there are calls being made to os_helper functions, which causes unicode/bytes issues, since in u1cp everything is unicode, but os_helper API uses bytes, so we're increasing the coupling between those.

Temporarily, until the validation logic is added to u1-client, a call to is_link and the related test will be disabled in u1cp. Should be removed and replaced for a call to the new syncdaemon validation service.

See original description
Tags: u1-windows

Related branches

lp:~brian.curtin/ubuntuone-client/824252-validate-path-export
Natalia Bidart (community): Approve
Roberto Alsina (community): Approve
Diff: 303 lines (+176/-9)
9 files modified
tests/platform/test_external_interface.py (+10/-0)
tests/syncdaemon/test_interaction_interfaces.py (+10/-0)
tests/syncdaemon/test_vm.py (+107/-1)
ubuntuone/platform/linux/dbus_interface.py (+6/-0)
ubuntuone/platform/tools/__init__.py (+8/-0)
ubuntuone/platform/windows/ipc.py (+5/-0)
ubuntuone/platform/windows/ipc_client.py (+4/-0)
ubuntuone/syncdaemon/interaction_interfaces.py (+7/-0)
ubuntuone/syncdaemon/volume_manager.py (+19/-8)
lp:ubuntu/precise/ubuntuone-client
lp:~nataliabidart/ubuntuone-control-panel/validate-in-sd
Roberto Alsina (community): Approve
Diego Sarmentero (community): Approve
Diff: 233 lines (+35/-112)
4 files modified
ubuntuone/controlpanel/backend.py (+2/-28)
ubuntuone/controlpanel/sd_client/__init__.py (+4/-0)
ubuntuone/controlpanel/tests/test_backend.py (+12/-84)
ubuntuone/controlpanel/tests/test_sd_client.py (+17/-0)
lp:~nataliabidart/ubuntuone-control-panel/stable-3-0-update-2.99.92
Alejandro J. Cura (community): Approve
Diff: 1335 lines (+334/-437)
19 files modified
ubuntuone/controlpanel/backend.py (+13/-31)
ubuntuone/controlpanel/dbustests/test_sd_client/test_linux.py (+0/-94)
ubuntuone/controlpanel/gui/__init__.py (+1/-1)
ubuntuone/controlpanel/gui/qt/controlpanel.py (+3/-4)
ubuntuone/controlpanel/gui/qt/folders.py (+3/-2)
ubuntuone/controlpanel/gui/qt/gui.py (+1/-2)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+2/-1)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+10/-1)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+13/-1)
ubuntuone/controlpanel/gui/qt/tests/test_preferences.py (+15/-0)
ubuntuone/controlpanel/gui/qt/tests/test_wizard.py (+12/-1)
ubuntuone/controlpanel/gui/qt/wizard.py (+4/-8)
ubuntuone/controlpanel/sd_client/__init__.py (+10/-13)
ubuntuone/controlpanel/sd_client/linux.py (+0/-46)
ubuntuone/controlpanel/tests/test_backend.py (+66/-105)
ubuntuone/controlpanel/tests/test_sd_client.py (+23/-17)
ubuntuone/controlpanel/utils/__init__.py (+8/-4)
ubuntuone/controlpanel/utils/tests/test_windows.py (+106/-71)
ubuntuone/controlpanel/utils/windows.py (+44/-35)
lp:ubuntu/precise/ubuntuone-control-panel
Roberto Alsina (ralsina)
description: updated
Natalia Bidart (nataliabidart)
Changed in ubuntuone-control-panel:
status: New → Triaged
Changed in ubuntuone-client:
importance: Undecided → Medium
Changed in ubuntuone-control-panel:
importance: Undecided → Medium
assignee: nobody → Natalia Bidart (nataliabidart)
description: updated
Natalia Bidart (nataliabidart)
Changed in ubuntuone-client:
importance: Medium → Low
Changed in ubuntuone-control-panel:
importance: Medium → Low
Joshua Hoover (joshuahoover)
tags: added: u1-windows
Natalia Bidart (nataliabidart)
Changed in ubuntuone-client:
importance: Low → Medium
Changed in ubuntuone-control-panel:
importance: Low → Medium
tags: added: u1-windows-cleanup
Natalia Bidart (nataliabidart)
Changed in ubuntuone-client:
assignee: Natalia Bidart (nataliabidart) → Diego Sarmentero (diegosarmentero)
Changed in ubuntuone-control-panel:
assignee: Natalia Bidart (nataliabidart) → Diego Sarmentero (diegosarmentero)
Brian Curtin (brian.curtin)
Changed in ubuntuone-client:
assignee: Diego Sarmentero (diegosarmentero) → Brian Curtin (brian.curtin)
status: Triaged → In Progress
Ubuntu One Auto Pilot (otto-pilot)
Changed in ubuntuone-client:
status: In Progress → Fix Committed
dobey (dobey)
Changed in ubuntuone-client (Ubuntu):
assignee: nobody → Rodney Dawes (dobey)
importance: Undecided → Medium
milestone: none → ubuntu-12.04-beta-1
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 2.99.4-0ubuntu1

---------------
ubuntuone-client (2.99.4-0ubuntu1) precise; urgency=low

  * New upstream release.
    - Work with new gireactor from twisted. (LP: #921574, LP: #928892)
    - Export an interface to validate folder paths. (LP: #824252)
    - Fix or skip some tests causing issues. (LP: #929812, LP: #929546)
  * debian/watch:
    - Update watch file for new release.
  * debian/control:
    - Bump standards version to 3.9.2.
    - Update dependencies and recommends to prefer gir versions.
    - Require twisted 11.1.0-1ubuntu1 which provides gireactor in a patch.
 -- Rodney Dawes <email address hidden> Thu, 16 Feb 2012 11:08:42 -0500

Changed in ubuntuone-client (Ubuntu):
status: In Progress → Fix Released
Natalia Bidart (nataliabidart)
tags: removed: u1-windows-cleanup u1-zomg-windows
Natalia Bidart (nataliabidart)
description: updated
Natalia Bidart (nataliabidart)
Changed in ubuntuone-control-panel:
assignee: Diego Sarmentero (diegosarmentero) → Natalia Bidart (nataliabidart)
Natalia Bidart (nataliabidart)
Changed in ubuntuone-control-panel:
status: Triaged → In Progress
Changed in ubuntuone-control-panel (Ubuntu):
milestone: none → ubuntu-12.04
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 2.99.92-0ubuntu1

---------------
ubuntuone-control-panel (2.99.92-0ubuntu1) precise; urgency=low

  * New upstream release:
    - Using limit_bandwidth attribute to properly process the info dict
      for preferences (LP: #944256).
    - Handle errors from backend on the signin wizard page (LP: #945078).
    - Avoid the 'show/hide details' button to grow when focused (LP: #961348).
    - Modified stylesheet to use the new colours from brand, and to also ease
      the reading of white text (LP: #956077).
    - Fixed the gap tab outlines (LP: #822629).
    - Remove custom path validation and use the one provided by syncdaemon
      (LP: #824252).
    - Make use of the new feature from syncdaemon where 'refresh_volumes'
      returns a deferred that gets fired when the server info is ready
      (LP: #851810).
    - Ensured that Folders' tree view has proper texts in the columns to
      have proper column widths (LP: #965175).
    - Forced white background (LP: #961346).
  * debian/control:
    - Bumped dependency versions on ubuntu-sso-client and ubuntuone-client to
      2.99.92.
  * debian/watch:
    - Updated url to fetch tarball from latest milestone.
 -- Natalia Bidart (nessita) <email address hidden> Wed, 04 Apr 2012 13:03:50 -0300

Changed in ubuntuone-control-panel (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.