cmd line quotes around paths deleted

Bug #824381 reported by Simon Kersey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Status tracked in Trunk
0.20
Fix Released
Medium
Alexander Belchenko
0.21
Fix Released
Medium
Alexander Belchenko
Trunk
Fix Released
Medium
Alexander Belchenko

Bug Description

I have done some experimenting and if you run the following from a Windows command prompt:

bzr qrun add -- --dry-run "path with spaces\1 2.txt" "path with spaces\3 4.txt"

Then when the qrun dialog is displayed there are no quotes in the options and arguments fields

System:
Windows 7
bzrlib 2.3.4
qbzr 0.20.1

Tags: qrun easy
Revision history for this message
Alexander Belchenko (bialix) wrote :

Simon, the actual bug in lib/commands.py cmd_qrun:
Initially parameters passed is list, but then it converted to one string by simple join.

        if parameters_list:
            parameters = " ".join(parameters_list)
        else:
            parameters = None

We need to quote parameters with spaces there. I think you can re-use code from bzr-explorer to fix this. Would you?

Changed in qbzr:
status: New → Confirmed
importance: Undecided → Medium
tags: added: easy qrun
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.